blender/blender
blender/blender
195
614
Fork 956
Code Issues 6.4k Pull Requests 1.1k Projects 22 Wiki Activity

Regression: Screw Modifier Calculate Order is broken #101075

New Issue
Closed
opened 2022-09-14 23:22:04 +02:00 by Ziggy Spooner · 15 comments
Ziggy Spooner commented 2022-09-14 23:22:04 +02:00
Copy Link

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.35

Blender Version
Broken: version: 3.3.1 Release Candidate, branch: master, commit date: 2022-09-12 18:27, hash: 19ae71c113
Worked: 3.2.2

Caused by: a5190dce9d

Short description of error
Vertex ordering calculation in the Screw Modifier no longer works properly in 3.3
Calculate Order Error.blend
I have included a Solidify modifier to make the problem obvious, but solidify does not appear to be part of the problem.

Exact steps for others to reproduce the error
Load attached file
Calculate Order Error.blend
in Blender 3.3.0 or later and the vertex order is calculated incorrectly:
image.png
In Blender 3.2.2 and earlier, it works properly:
image.png

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.35 **Blender Version** Broken: version: 3.3.1 Release Candidate, branch: master, commit date: 2022-09-12 18:27, hash: `19ae71c113` Worked: 3.2.2 Caused by: a5190dce9d08a4fdaddf82d592e50083e0713e19 **Short description of error** Vertex ordering calculation in the Screw Modifier no longer works properly in 3.3 [Calculate Order Error.blend](https://archive.blender.org/developer/F13493580/Calculate_Order_Error.blend) I have included a Solidify modifier to make the problem obvious, but solidify does not appear to be part of the problem. **Exact steps for others to reproduce the error** Load attached file [Calculate Order Error.blend](https://archive.blender.org/developer/F13493580/Calculate_Order_Error.blend) in Blender 3.3.0 or later and the vertex order is calculated incorrectly: ![image.png](https://archive.blender.org/developer/F13493588/image.png) In Blender 3.2.2 and earlier, it works properly: ![image.png](https://archive.blender.org/developer/F13493603/image.png)
Ziggy Spooner commented 2022-09-14 23:22:04 +02:00
Author
Copy Link

Added subscriber: @Dudecon

Added subscriber: @Dudecon
blender-admin commented 2022-09-14 23:22:04 +02:00
Copy Link

#101879 was marked as duplicate of this issue

#101879 was marked as duplicate of this issue
Ziggy Spooner commented 2022-09-14 23:46:38 +02:00
Author
Copy Link

I recommend using the "convert to curve" method of vertex ordering (split vertex), since it is robust under 3+ edges per vertex.
image.png
The old Screw modifier did not handle these cases well (arbitrary re-ordering with unpredictable break in normals)

I recommend using the "convert to curve" method of vertex ordering (split vertex), since it is robust under 3+ edges per vertex. ![image.png](https://archive.blender.org/developer/F13493759/image.png) The old Screw modifier did not handle these cases well (arbitrary re-ordering with unpredictable break in normals)
Omar Emara commented 2022-09-15 11:47:41 +02:00
Member
Copy Link

Added subscriber: @OmarEmaraDev

Added subscriber: @OmarEmaraDev
Omar Emara commented 2022-09-15 12:31:03 +02:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Omar Emara commented 2022-09-15 12:31:03 +02:00
Member
Copy Link

Caused by a5190dce9d.

Caused by a5190dce9d08a4fdaddf82d592e50083e0713e19.
Omar Emara commented 2022-09-15 12:31:23 +02:00
Member
Copy Link

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Omar Emara changed title from Screw Modifier, Calculate Order broken to Regression: Screw Modifier Calculate Order is broken 2022-09-15 12:31:54 +02:00
Hans Goudey self-assigned this 2022-09-15 13:54:21 +02:00
Hans Goudey commented 2022-09-26 23:38:07 +02:00
Member
Copy Link

This problem was exposed by the above commit, but the actual problem is in the screw modifier, which creates invalid normals and then clears the dirty flag.

{F13576965 size=full} image.png image.png

Calculating normals eagerly in some cases is helpful, but I don't think the screw modifier is one of the places where it's necessary.

This problem was exposed by the above commit, but the actual problem is in the screw modifier, which creates invalid normals and then clears the dirty flag. | {[F13576965](https://archive.blender.org/developer/F13576965/image.png) size=full} | ![image.png](https://archive.blender.org/developer/F13577022/image.png) | ![image.png](https://archive.blender.org/developer/F13577025/image.png) | | -- | -- | -- | Calculating normals eagerly in some cases is helpful, but I don't think the screw modifier is one of the places where it's necessary.
blender-admin commented 2022-09-27 00:59:44 +02:00
Copy Link

This issue was referenced by 86538e31f5

This issue was referenced by 86538e31f5945009b6fae0f14b958ed07762f016
blender-admin commented 2022-09-27 00:59:44 +02:00
Copy Link

This issue was referenced by dcd909122f

This issue was referenced by dcd909122f9ad644dcc11e49f565e58dabe276e2
Hans Goudey commented 2022-09-27 01:06:41 +02:00
Member
Copy Link

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Chipp Walters commented 2022-09-30 21:38:24 +02:00
Copy Link

Added subscriber: @chippwalters

Added subscriber: @chippwalters
Chipp Walters commented 2022-09-30 21:38:24 +02:00
Copy Link

I think you may have inadvertly screwed up the screw modifier again. Now it won't take a solidify modifier after it. See video below.

3.3.1 Release Candidate

https://youtu.be/hev_1-JGhl4

I've been told it's fixed in 3.4-- any chance of getting it fixed in 3.3?

Here's a solution FWIW for now:unknown.png
You can also set the mode to Complex, and that fixes the issue. And because there are known workarounds and fixes, this isn't a high priority for me.

I think you may have inadvertly screwed up the screw modifier again. Now it won't take a solidify modifier after it. See video below. 3.3.1 Release Candidate https://youtu.be/hev_1-JGhl4 I've been told it's fixed in 3.4-- any chance of getting it fixed in 3.3? Here's a solution FWIW for now:![unknown.png](https://archive.blender.org/developer/F13599258/unknown.png) You can also set the mode to Complex, and that fixes the issue. And because there are known workarounds and fixes, this isn't a high priority for me.
Hans Goudey commented 2022-10-03 06:44:30 +02:00
Member
Copy Link

Yeah, that looks like the same issue from this report. I added it to #100749 (Blender LTS: Maintenance Task 3.3), so the fix should hopefully make it into 3.3.1.

Yeah, that looks like the same issue from this report. I added it to #100749 (Blender LTS: Maintenance Task 3.3), so the fix should hopefully make it into 3.3.1.
Hans Goudey commented 2022-10-18 00:01:55 +02:00
Member
Copy Link

Added subscriber: @Olliver

Added subscriber: @Olliver
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Asset datablocks, libraries, browser and shelf
Interest
Audio
Interest
Automated Testing
Interest
BlendFile
Interest
Blender Asset Bundle
Interest
Code Documentation
Code comments, Python/RNA API descriptions
Interest
Collada
Interest
Compatibility
Backward and forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
FBX I/O related topics
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms & Builds
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
USD
Interest
UV Editing
Interest
Undo
Interest
User Interface
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Wayland windowing on Unix
Interest
Workbench
Interest
glTF
glTF format I/O topics
Interest: X11
Xorg/X11 windowing
Legacy
Asset Browser Project
Archived
Legacy
Blender 2.8 Project
Archived
Legacy
Milestone 1: Basic, Local Asset Browser
Archived
Legacy
OpenGL Error
Archived
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Related to security, see policy: https://developer.blender.org/docs/handbook/bug_reports/vulnerability_reports/
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms & Builds
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
Windows
Platform
macOS
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Archived
Type
Report
Archived
Type
To Do
No Label
Interest
Modeling
Interest
Modifiers
Module
Modeling
Severity
High
Status
Resolved
Type
Bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Hoshinova James-McCarthy-4 Sebastian-Herholz casey-bianco-davis gandalf3 Blendify Aaron Carlisle quantimoney Aditya Y Jeppu Alaska Alaska angavrilov Alexander Gavrilov frogstomp Aleš Jelovčan amelief Amélie Fondevilla elubie Andrea Weikert Andy_Goralczyk Andy Goralczyk ankitm Ankit Meel Anthony-Roberts Anthony Roberts antoniov Antonio Vazquez aras_p Aras Pranckevicius Arnd Arnd Marijnissen bartvdbraak Bart van der Braak mont29 Bastien Montagne blender-bot Blender Bot bnagirniak Bogdan Nagirniak BClark Brad Clark brecht Brecht Van Lommel BrianSavery Brian Savery (AMD) ideasman42 Campbell Barton CharlesWardlaw Charles Wardlaw CharlieJolly Charlie Jolly Chris_Blackbourn Chris Blackbourn lateasusual Chris Clyne (Lateasusual) ChrisLend Christoph Lendenfeld HobbesOS Cian Jinks fclem Clément Foucault cmbasnett Colin Basnett Kdaf Colin Marmond dfelinto Dalai Felinto pioverfour Damien Picard DanielBystedt Daniel Bystedt pepe-school-land Daniel Martinez Lara zanqdo Daniel Salazar Mets Demeter Dzadik erik85 Erik Abrahamsson EAW Evan Wilson filedescriptor Falk David fsiddi Francesco Siddi GaiaClary Gaia Clary DagerD Georgiy Markelov mano-wii Germano Cavalcante zazizizou Habib Gahbiche HooglyBoogly Hans Goudey Harley Harley Acheson weasel Henrik D. Hjalti Hjalti Hjálmarsson howardt Howard Trickey nirved-1 Hristo Gueorguiev mod_moder Iliya Katushenock brita Inês Almeida JacquesLucke Jacques Lucke Jason-Fielder Jason Fielder JasonSchleifer Jason schleifer Jebbly Jeffrey Liu Jeroen-Bakker Jeroen Bakker deadpin Jesse Yurkovich neXyon Joerg Mueller eliphaz John Kiril Swenson guitargeek Johnny Matthews Brainzman Jonas Holzman JoniMercado Jonatan Mercado JorgeBernalMartinez Jorge Bernal JosephEagar Joseph Eagar JoshuaLeung Joshua Leung Bone-Studio Juan Gea jpbouza-4 Juan Pablo Bouza JulianEisel Julian Eisel JulienDuroure Julien Duroure JulienKaspar Julien Kaspar kevindietrich Kévin Dietrich lone_noel Leon Schittek LucianoMunoz Luciano Muñoz Sessarego LukasStockner Lukas Stockner LukasTonne Lukas Tönne LunaRood Luna Rood MaiLavelle Mai Lavelle EosFoxx Marion Stalke Baardaap Martijn Versteegh scorpion81 Martin Felke mendio Matias Mendiola Matt-McLin Matt McLin MetinSeven Metin Seven wave Michael B Johnson Michael-Jones Michael Jones (Apple) makowalski Michael Kowalski pragma37 Miguel Pozo nrupsis Nate Rupsis jesterking Nathan Letwory nathanvegdahl Nathan Vegdahl PrototypeNM1 Nicholas Rishel nickberckley Nika Kutsniashvili Sirgienko Nikita Sirgienko OmarEmaraDev Omar Emara pablovazquez Pablo Vazquez PaoloAcampora Paolo Acampora PascalSchon Pascal Schön pmoursnv Patrick Mours muxed-reality Peter Kim lichtwerk Philipp Oeser P2design Pierrick PICAUT PratikPB2123 Pratik Borhade Limarest Ramil Roosileht farsthary Raul Fernandez Hernandez LazyDodo Ray molenkamp iss Richard Antalik rjg Robert Guetzkow salipour Sahar A. Kashi Sayak-Biswas Sayak Biswas Sean-Kim Sean Kim sherholz Sebastian Herholz sebastian_k Sebastian Koenig ZedDB Sebastian Parborg sebbas Sebastián Barschkis Sergey Sergey Sharybin IRIEShinsuke Shinsuke Irie sidd017 Siddhartha Jejurkar SietseB Sietse Brouwer SimonThommes Simon Thommes SonnyCampbell_Unity Sonny Campbell Stefan_Werner Stefan Werner Lockal Sv. Lockal dr.sybren Sybren A. Stüvel ThomasDinges Thomas Dinges Ton Ton Roosendaal BassamKurdali Ursula kurdali Vasyl-Pidhirskyi Vasyl Pidhirskyi WannesMalfait Wannes Malfait wbmoss_dev Wayde Moss weizhen Weizhen Huang leesonw William Leeson xavierh Xavier Hallade jenkm Yevgeny Makarov ChengduLittleA YimingWu gfxcoder jon denning
No Assignees Hans Goudey
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#101075
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?