Page MenuHome

Regression: Edited action in NLA ignored settings
Confirmed, HighPublic

Description

System Information
Operating system: Ubuntu 20.04
Graphics card:

Blender Version
Broken: 3.4 alpha
Worked: 3.2

In 3.3: Influence works only when nla strip is selected. But panel is removed in 3.4 for active strip: rBb6ebd5591c7f: NLA: Remove Edited Action tab from NLA panel
Also- influence property doesn't update the base action contribution when only action is selected. Behavior changed in rB61e8310b7581: NLA: improve visibility of action & active channel

Short description of error
The action being edited ignores any settings in the NLA. It is quite possible that the problem is in the N panel itself, because in 3.3 the action reacted to changing the settings only in the "Edited Action" category

Exact steps for others to reproduce the error

  • Open .blend
  • Change influence slider


Event Timeline

Alexander (sanek2005) renamed this task from Edited in NLA ignored settings to Edited action in NLA ignored settings.Thu, Sep 22, 6:41 PM
Alexander (sanek2005) created this task.

You don't have the action selected in the second part of the video where it isn't working, you have it selected in the first part where it is.

@Brad Clark (RiggingDojo) no. either it just can't be selected, or I don't know something

Brad Clark (RiggingDojo) changed the task status from Needs Triage to Confirmed.Thu, Sep 22, 9:43 PM

Sorry, you are correct, it isn't impacting the top action blend, good find, Bug!

As far as I can see Edited action panel is missing for the selected strip. I'll check

The base action doesn't have a strip as it is just the action.. all of this part of the UI is still needing refinement but The influence should be working like it did in 3.3

Pratik Borhade (PratikPB2123) triaged this task as High priority.Fri, Sep 23, 6:07 AM

Panel was removed in b6ebd5591c7f0e7037a2af66b5e1d96125834949 which was done purposefully.
With no strip selected influence operation neither works in 3.3 but it does in 3.2
Raising the priority

The base action doesn't have a strip as it is just the action.. all of this part of the UI is still needing refinement but The influence should be working like it did in 3.3

Hello Brad, for me influence property neither works in 3.3. Could you confirm in uploaded file?

3.3 is working but sort of.
IF you accidentally click on a "strip" and the UI updates to show the Strip Info. then when you deselect it, the action no longer becomes active and the Edited Action settings no longer work.

So what I am seeing is if I create an action fresh and then try and adjust the settings it works. If I click away and select something else, the influence don't update /refresh the action but it does read it when you create a strip.

There is something not getting set back to active when you click on a strip and then deselect widh

Thanks, Few notes after testing multiple versions::
If NLA strip is selected from the stack then influence works. but now panel is removed for active strips in b6ebd5591c7f0e7037a2af66b5e1d96125834949
If base action is selected in nla editor then I expect influence slider to update the viewport based on its value but it neither contributes since rB61e8310b7581: NLA: improve visibility of action & active channel
cc @Nate Rupsis (nrupsis)
cc @Sybren A. Stüvel (sybren)

Yes, the panel is removed for active scripts because that "Edit Action panel" has nothing to do with the Selected Strips. It is only fro the Creation of and interaction with the Base action.

The issue is that somehow the base action is no longer being seen/getting updated once you deselect the strip and the UI shows the "Edited Action" tab again.

Ugh yeah. That's weird. My changes didn't necessarily cause it. But they are definitely preventing it.

Upon initial investigation, I didn't see anything that stuck out to me. I'll keep looking into it.

Do either of you know the distinction between a NLA-Track and an NLA-Strip ?

Track should be where the Strip lives but I wonder if the scene action has a default track?

Pratik Borhade (PratikPB2123) renamed this task from Edited action in NLA ignored settings to Regression: Edited action in NLA ignored settings.Tue, Sep 27, 6:15 AM

Investigating this a little more, and it comes down to (afaik) a dependency issue. Or rather, data ownership.

A log from "now hidden" action panel's influence relieves that the dependency graph updates it's owners Id, i.e the cube:

graph_id_tag_update: id=OBCube flags=TRANSFORM, GEOMETRY, ANIMATION source=USER_EDIT
graph_id_tag_update: id=OBCube flags=TRANSFORM, GEOMETRY, ANIMATION source=USER_EDIT
graph_id_tag_update: id=MECube flags=LEGACY_0 source=USER_EDIT
graph_id_tag_update: id=OBCube flags=COPY_ON_WRITE source=USER_EDIT
graph_id_tag_update: id=OBCube flags=COPY_ON_WRITE source=USER_EDIT

When acting upon the Action Strip ("scale-all") in this case, the action strip _is_ the owner of that data block, thus the dependency graph is doing what it should, but since there isn't a dependency, nothing is happening:

graph_id_tag_update: id=ACscale-all flags=TRANSFORM, GEOMETRY, ANIMATION source=USER_EDIT
graph_id_tag_update: id=ACscale-all flags=TRANSFORM, GEOMETRY, ANIMATION source=USER_EDIT
graph_id_tag_update: id=ACscale-all flags=COPY_ON_WRITE source=USER_EDIT
graph_id_tag_update: id=ACscale-all flags=COPY_ON_WRITE source=USER_EDIT

At this point, my lack of Animation Data is blocking me. I have a feeling I _could_ figure out a way to connect the Action's data to the mesh it's acting upon, but It would be hackish.

@Sybren A. Stüvel (sybren) do you have any ideas?

hmm So shouldn't the ID in the first section but cube action? the id= the strip in the second set of code but the first ID isn't showing the action it is just showing the cube?