Regression: Collapsed multi-input sockets not collapsing noodles #101361

New Issue

Erindale · 2022-09-25T14:44:17+02:00

Erindale commented

2022-09-25 14:44:17 +02:00

System Information
Operating system: Windows-10-10.0.22000-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.40

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-22 21:54, hash: e9344d329f
Worked: 3.3

Likely caused by 40d815dff6

Short description of error
When a multi-input socket is collapsed with its node, the noodles don't go to a single point as they should

Exact steps for others to reproduce the error
Add many objects and plug into a multi-input socket
Collaspe the node

**System Information** Operating system: Windows-10-10.0.22000-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 517.40 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-22 21:54, hash: `e9344d329f` Worked: 3.3 Likely caused by 40d815dff6 **Short description of error** When a multi-input socket is collapsed with its node, the noodles don't go to a single point as they should ![image.png](https://archive.blender.org/developer/F13570665/image.png) **Exact steps for others to reproduce the error** Add many objects and plug into a multi-input socket Collaspe the node

Erindale commented

2022-09-25 14:44:17 +02:00

Added subscriber: @Erindale

Iliya Katushenock commented

2022-09-25 15:21:35 +02:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-09-25 15:21:35 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Iliya Katushenock commented

2022-09-25 15:21:35 +02:00

Regression 3.4

![image.png](https://archive.blender.org/developer/F13570862/image.png) Regression 3.4

Pratik Borhade commented

2022-09-25 15:44:59 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-09-25 15:44:59 +02:00

Thanks for the report. I've not tested this myself. Raising the priority for now as it seems a regression

Iliya Katushenock commented

2022-09-25 16:12:09 +02:00

I can't find the exact commit as I'm inexperienced with it, but so far it's somewhere between September 2-3, something like
https://developer.blender.org/rB40d815dff6515834c1bce40c0a34cc80b39655d5

I can't find the exact commit as I'm inexperienced with it, but so far it's somewhere between September 2-3, something like https://developer.blender.org/rB40d815dff6515834c1bce40c0a34cc80b39655d5

Leon Schittek commented

2022-09-25 16:33:28 +02:00

Added subscriber: @lone_noel

Leon Schittek commented

2022-09-25 16:33:28 +02:00

I think it was caused by 40d815dff6 where the logic for calculating the multi input link position was changed a bit and doesn't check for the "hidden" state of the node anymore:

From:

if (!(link.tonode->flag & NODE_HIDDEN) && link.tosock->flag & SOCK_MULTI_INPUT)

To:

if (socket.flag & SOCK_MULTI_INPUT && socket.in_out == SOCK_IN)

I think it was caused by 40d815dff651 where the logic for calculating the multi input link position was changed a bit and doesn't check for the "hidden" state of the node anymore: From: ``` if (!(link.tonode->flag & NODE_HIDDEN) && link.tosock->flag & SOCK_MULTI_INPUT) ``` To: ``` if (socket.flag & SOCK_MULTI_INPUT && socket.in_out == SOCK_IN) ```

Iliya Katushenock commented

2022-09-25 16:46:36 +02:00

My haste failed me, I needed to study this particular commit in more detail. Indeed, it looks like a problem.

Iliya Katushenock self-assigned this 2022-09-25 16:53:08 +02:00

Pratik Borhade changed title from ~~Collapsed multi-input sockets not collapsing noodles~~ to Regression: Collapsed multi-input sockets not collapsing noodles

2022-09-26 04:10:42 +02:00

blender-admin commented

2022-09-27 01:10:27 +02:00

This issue was referenced by 8da253cfb6

This issue was referenced by 8da253cfb64fe578bd8136a7a0a4c4aa74fb536b

Hans Goudey commented

2022-09-27 01:11:22 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2022-09-27 01:11:22 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Collapsed multi-input sockets not collapsing noodles #101361