Info editor reports wrong transform options #101928

New Issue

Leon Schittek · 2022-10-19T12:54:45+02:00

Leon Schittek commented

2022-10-19 12:54:45 +02:00

System Information
Operating system: macOS-11.6.5-x86_64-i386-64bit 64 Bits
Graphics card: Intel Iris OpenGL Engine Intel Inc. 4.1 INTEL-16.5.9

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-18 03:54, hash: e47bf05e85
Worked: (newest version of Blender that worked as expected)

Short description of error
After transforming the info editor will report the transform with the state of use_snap_self, use_snap_edit, use_snap_nonedit flipped.

So when transforming with "Include Active" target activated it will wrongly report use_snap_self = false and vice versa.
When repeating the transform with {key shift R} the state of use_snap_self, use_snap_edit, use_snap_nonedit will flip on each iteration.

Exact steps for others to reproduce the error

Open default startup.
Open an info editor next to the viewport.
Switch to edit mode.
Select a vertex and transform it using {key G}.
Repeat that transform with {key shift R}.
Check in the info editor how e.g. use_snap_self flips between true and false on each iteration.

Note

I stumbled upon this while working on a related area. I think it's just these three boolean properties being set wrong (introduced in 236fda7faf), but I'd like to leave this to someone more familiar with this.

RNA_boolean_set(op->ptr, "use_snap_self", (target & SCE_SNAP_TARGET_NOT_ACTIVE) != 0);
RNA_boolean_set(op->ptr, "use_snap_edit", (target & SCE_SNAP_TARGET_NOT_EDITED) != 0);
RNA_boolean_set(op->ptr, "use_snap_nonedit", (target & SCE_SNAP_TARGET_NOT_NONEDITED) != 0);

I think the check should be == 0 since the flags are describing a negative state.
snap-info-report.mp4

**System Information** Operating system: macOS-11.6.5-x86_64-i386-64bit 64 Bits Graphics card: Intel Iris OpenGL Engine Intel Inc. 4.1 INTEL-16.5.9 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-18 03:54, hash: `e47bf05e85` Worked: (newest version of Blender that worked as expected) **Short description of error** After transforming the info editor will report the transform with the state of `use_snap_self`, `use_snap_edit`, `use_snap_nonedit` flipped. So when transforming with "Include Active" target activated it will wrongly report `use_snap_self = false` and vice versa. When repeating the transform with {key shift R} the state of `use_snap_self`, `use_snap_edit`, `use_snap_nonedit` will flip on each iteration. **Exact steps for others to reproduce the error** 1. Open default startup. 2. Open an info editor next to the viewport. 3. Switch to edit mode. 4. Select a vertex and transform it using {key G}. 6. Repeat that transform with {key shift R}. 7. Check in the info editor how e.g. `use_snap_self` flips between `true` and `false` on each iteration. --- **Note** I stumbled upon this while working on a related area. I think it's just these three boolean properties being set wrong (introduced in 236fda7faf), but I'd like to leave this to someone more familiar with this. ``` RNA_boolean_set(op->ptr, "use_snap_self", (target & SCE_SNAP_TARGET_NOT_ACTIVE) != 0); RNA_boolean_set(op->ptr, "use_snap_edit", (target & SCE_SNAP_TARGET_NOT_EDITED) != 0); RNA_boolean_set(op->ptr, "use_snap_nonedit", (target & SCE_SNAP_TARGET_NOT_NONEDITED) != 0); ``` I think the check should be `== 0` since the flags are describing a negative state. [snap-info-report.mp4](https://archive.blender.org/developer/F13714829/snap-info-report.mp4)

Leon Schittek commented

2022-10-19 12:54:45 +02:00

Added subscriber: @lone_noel