Coordinate and Distance Texture Nodes #17998

New Issue

Mathias Panzenböck · 2008-11-16T18:38:45+01:00

2008-11-16 18:38:45 +01:00

%%%This patch adds a input node that gets the pixels coordinate as a vector and a node that calculates the distance between two points (given as vectors).

However, there seems to be a bug somewhere. The two nodes are very simple so I really can't figure what I did wrong.

See the attached screenshots for the bug. Both times the preview should be a blurry black sphere, but one time it's a bar. Both time the "other" input coordinate is (0, 0, 0).

Essentially the Coordinate Node does:
static void valuefn(float *out, float *coord, bNode *node, bNodeStack **in, short thread)
{
out- [x] = coord[0];
out- [x] = coord[1];
out- [x] = coord[2];
}

And the Distance Node does:
static void valuefn(float *out, float *coord, bNode *node, bNodeStack **in, short thread)
{
float coord1- [x], coord2[3];
float x, y, z;

tex_input_vec(coord1, in- [x], coord, thread);
tex_input_vec(coord2, in- [x], coord, thread);

x = coord2- [x] - coord1[0];
y = coord2- [x] - coord1[1];
z = coord2- [x] - coord1[2];

*out = sqrt(x * x + y * y + z * z);

}%%%

%%%This patch adds a input node that gets the pixels coordinate as a vector and a node that calculates the distance between two points (given as vectors). However, there seems to be a bug somewhere. The two nodes are very simple so I really can't figure what I did wrong. See the attached screenshots for the bug. Both times the preview should be a blurry black sphere, but one time it's a bar. Both time the "other" input coordinate is (0, 0, 0). Essentially the Coordinate Node does: static void valuefn(float *out, float *coord, bNode *node, bNodeStack **in, short thread) { out- [x] = coord[0]; out- [x] = coord[1]; out- [x] = coord[2]; } And the Distance Node does: static void valuefn(float *out, float *coord, bNode *node, bNodeStack **in, short thread) { float coord1- [x], coord2[3]; float x, y, z; tex_input_vec(coord1, in- [x], coord, thread); tex_input_vec(coord2, in- [x], coord, thread); x = coord2- [x] - coord1[0]; y = coord2- [x] - coord1[1]; z = coord2- [x] - coord1[2]; *out = sqrt(x * x + y * y + z * z); }%%%

Mathias Panzenböck commented

2008-11-16 18:38:45 +01:00

Changed status to: 'Open'

Mathias Panzenböck commented

2008-11-16 18:49:00 +01:00

%%%PS: Using this nodes (+displacement modifier + weight paint) you can build nice terrains (see appended screenshots).%%%

Robin Allen commented

2008-11-17 12:05:57 +01:00

%%%tex_input_vec expects a 4-vector as its first argument; could be what's causing it. Rewriting to use 3-vectors is on the todo list.%%%

Mathias Panzenböck commented

2008-11-17 13:56:13 +01:00

%%%Oh, then this bug exists in TEX_translate.c too, because I copied this code from there.%%%

Mathias Panzenböck commented

2008-11-17 14:27:14 +01:00

%%%Added new bugfixed patch "tex_nodes_coord_dist_v2.patch".%%%

Robin Allen commented

2008-11-26 14:09:54 +01:00

%%%Committed this patch today. Thanks!%%%

Robin Allen commented

2008-11-26 14:10:54 +01:00

Changed status from 'Open' to: 'Archived'

Robin Allen closed this issue

2008-11-26 14:10:54 +01:00

Mathias Panzenböck commented

2008-11-26 20:06:55 +01:00

%%%Very nice!
Cool, some code of mine ended up in blender. :)%%%

%%%Very nice! Cool, some code of mine ended up in blender. :)%%%

Matt Ebb commented

2008-11-27 01:39:52 +01:00

%%%PS. There is also a function for finding distance in BLI_arithb.h : VecLenf(), which is probably better to use to keep things centralised, and to make the code a lot cleaner.

I also wonder whether it would be better to put that distance function as a mode within the math node, rather than making too many different nodes, or even if the mix node 'difference' can do the same thing?%%%

%%%PS. There is also a function for finding distance in BLI_arithb.h : VecLenf(), which is probably better to use to keep things centralised, and to make the code a lot cleaner. I also wonder whether it would be better to put that distance function as a mode within the math node, rather than making too many different nodes, or even if the mix node 'difference' can do the same thing?%%%

Mathias Panzenböck commented

2008-11-27 02:29:00 +01:00

%%%I figured there have to be such an function somewhere but because I don't know blenders source well I did not find it. Someone with commit rights should change this.

I thought the math node only accepts "values", and not vectors?

The difference option of the mix nodes does a completely different thing.%%%

%%%I figured there have to be such an function somewhere but because I don't know blenders source well I did not find it. Someone with commit rights should change this. I thought the math node only accepts "values", and not vectors? The difference option of the mix nodes does a completely different thing.%%%

Robin Allen commented

2008-11-29 17:25:47 +01:00

%%%Matt, the math node won't accept vectors, and the mix node clamps its values to colour range [0..1f]. Could generalize this to a 'vector math' node in the future though.

Thanks for the tip about BLI_arithb, I'll update the code to use that. (Some of my code could probably use it too...)%%%

%%%Matt, the math node won't accept vectors, and the mix node clamps its values to colour range [0..1f]. Could generalize this to a 'vector math' node in the future though. Thanks for the tip about BLI_arithb, I'll update the code to use that. (Some of my code could probably use it too...)%%%

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Coordinate and Distance Texture Nodes #17998