2dFilter actuator is always pulsed #18070

New Issue

Dalai Felinto · 2008-12-10T10:11:26+01:00

Dalai Felinto commented

2008-12-10 10:11:26 +01:00

Group: current SVN version
Category: Game engine

%%%To test this bug you will need:

EnableFilterBUG.blend (attached)
a graphic card with GLSL support
a building environment with debug enable
recent svn and some minutes (not so much)

To test the bug add 2 breakpoints in the file RAS_2DFilterManager.cpp

line 477: [need_tex_update=true;]
line 419: [SetupTextures(need depth, need luminance);]

In my system, even though I'm not using a pulsed sensor, the function UpdateFilter() is being called every frame (more than once I think).
Then the function EnableFilter is been called as well.

In EnableFilter the first BP is called and consequently the second one (it's a code that runs if need_tex_updte == true).

According to my understanding of this part of the code, this is not supposed to be happen and can be causing some real performance decreasing for 2dfilters. I hope I'm wrong, but if the breakpoints never stop been called, then ... Houston we have a problem :)

Blender SVN (ie 17752) Windows Vista 64, cmake + MSVC, NVidia 9600%%%

**Group**: current SVN version **Category**: Game engine %%%To test this bug you will need: 1) EnableFilterBUG.blend (attached) 2) a graphic card with GLSL support 3) a building environment with debug enable 4) recent svn and some minutes (not so much) To test the bug add 2 breakpoints in the file RAS_2DFilterManager.cpp 1) line 477: [need_tex_update=true;] 2) line 419: [SetupTextures(need depth, need luminance);] In my system, even though I'm not using a pulsed sensor, the function UpdateFilter() is being called every frame (more than once I think). Then the function EnableFilter is been called as well. In EnableFilter the first BP is called and consequently the second one (it's a code that runs if need_tex_updte == true). According to my understanding of this part of the code, this is not supposed to be happen and can be causing some real performance decreasing for 2dfilters. I hope I'm wrong, but if the breakpoints never stop been called, then ... Houston we have a problem :) Blender SVN (ie 17752) Windows Vista 64, cmake + MSVC, NVidia 9600%%%

Dalai Felinto commented

2008-12-10 10:11:26 +01:00

Changed status to: 'Open'

Nobody commented

2008-12-10 10:11:26 +01:00

This task was automatically closed as archived as part of migration, because the project or tracker this task belonged to is no longer active.

Benoit Bolsee commented

2008-12-16 00:52:25 +01:00

%%%Indeed there is an error with the 2D filter actuator: it stays enabled and runs on each frame, which results in the shader program to be recompiled each time... big performance waste.

Hopefully the fix is extremely simple.
Replace the "return true" at line 77 of SCA_2DFilterActuator.cpp by:

  // once the filter is in place, no need to update it
  return false;

That's it.
Can you test the fix will all the shader stuff that you have?
%%%

%%%Indeed there is an error with the 2D filter actuator: it stays enabled and runs on each frame, which results in the shader program to be recompiled each time... big performance waste. Hopefully the fix is extremely simple. Replace the "return true" at line 77 of SCA_2DFilterActuator.cpp by: ``` // once the filter is in place, no need to update it return false; ``` That's it. Can you test the fix will all the shader stuff that you have? %%%

Dalai Felinto commented

2008-12-17 03:40:46 +01:00

%%%Benoit so far I tested and this fix helps.
I want to run some more tests though.

And I asked Mike (Pan) to test with some of his shaders as well. As soon as we get a position I let you know.

Thanks a lot !%%%

%%%Benoit so far I tested and this fix helps. I want to run some more tests though. And I asked Mike (Pan) to test with some of his shaders as well. As soon as we get a position I let you know. Thanks a lot !%%%

Benoit Bolsee commented

2009-01-02 23:16:16 +01:00

%%%I did not receive more feedback so I assume the fix is working.

Fix commited in trunk and ticket closed
%%%

%%%I did not receive more feedback so I assume the fix is working. Fix commited in trunk and ticket closed %%%

Benoit Bolsee commented

2009-01-02 23:16:16 +01:00

Changed status from 'Open' to: 'Archived'

Benoit Bolsee closed this issue

2009-01-02 23:16:16 +01:00

Dalai Felinto commented

2009-01-03 02:53:11 +01:00

%%%Sorry about the lack of feedback. I was trying to talk with zaghaghi about that, but I couldnt find him online since then.

Your fix solves the problem of the 2dfilter been called every logic tic.
We are still re-creating the textures every frame though, instead of only copying. But this is something that was introduced in the last zaghaghi commit (17469) - http://lists.blender.org/pipermail/bf-blender-cvs/2008-November/016678.html

It was introduced as a bug fix, so the better would be to talk with zaghaghi directly.

Thanks Benoit %%%

%%%Sorry about the lack of feedback. I was trying to talk with zaghaghi about that, but I couldnt find him online since then. Your fix solves the problem of the 2dfilter been called every logic tic. We are still re-creating the textures every frame though, instead of only copying. But this is something that was introduced in the last zaghaghi commit (17469) - http://lists.blender.org/pipermail/bf-blender-cvs/2008-November/016678.html It was introduced as a bug fix, so the better would be to talk with zaghaghi directly. Thanks Benoit %%%

Benoit Bolsee commented

2009-01-04 12:11:38 +01:00

%%%The commit that you refer to is not on the same file: I patched SCA_2DFilterActuator.cpp while the commit is about RAS_2DFilterManager.cpp.

I am pretty sure of my fix but I will pass the ticker to Zaghaghi to let him comment on that.
%%%

%%%The commit that you refer to is not on the same file: I patched SCA_2DFilterActuator.cpp while the commit is about RAS_2DFilterManager.cpp. I am pretty sure of my fix but I will pass the ticker to Zaghaghi to let him comment on that. %%%

Hamed Zaghaghi commented

2009-01-04 16:07:47 +01:00

%%%hi benoit,

thank you for fixing the bad bug ;), i should take care of these mistakes.

%%%

%%%hi benoit, thank you for fixing the bad bug ;), i should take care of these mistakes. %%%

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

2dFilter actuator is always pulsed #18070