Image editor paint icon missing until enter weight paint #25649

New Issue

Danny McGrath · 2011-01-15T08:59:23+01:00

Danny McGrath commented

2011-01-15 08:59:23 +01:00

%%%I am using Ubuntu 10.10 64b r34328.

The problem is that the preview icon for the image editor for the paint brush, are missing. At least until I caused the 3D display to enter a paint mode (weight paint in this case), which displays the icons. The result is that the icons start showing up in the image editor (see attached images).%%%

%%%I am using Ubuntu 10.10 64b r34328. The problem is that the preview icon for the image editor for the paint brush, are missing. At least until I caused the 3D display to enter a paint mode (weight paint in this case), which displays the icons. The result is that the icons start showing up in the image editor (see attached images).%%%

Danny McGrath commented

2011-01-15 08:59:23 +01:00

Changed status to: 'Open'

Ton Roosendaal commented

2011-01-16 15:18:35 +01:00

%%%Nicholas, do you have time to investigate this? You worked on better display for icons before...%%%

Nicholas Bishop commented

2011-01-16 19:37:28 +01:00

%%%Fixed in trunk.%%%

Danny McGrath commented

2011-01-17 18:40:00 +01:00

%%%hmm, seems like its still broken in latest SVN. I attached a blend showing the problem now.

Basically, if you add a texture, the thumbnail for the default clouds preview thumbnail is generated. The problem is that if you change the texture type to magic, lets say, the brush preview doesn't update (although it seems the brush itself in sculpt uses the right brush). Also, if you create the texture from the texture panel instead of via the tool shelf, the preview thumbnail doesn't get generated at all, and stays empty.%%%

%%%hmm, seems like its still broken in latest SVN. I attached a blend showing the problem now. Basically, if you add a texture, the thumbnail for the default clouds preview thumbnail is generated. The problem is that if you change the texture type to magic, lets say, the brush preview doesn't update (although it seems the brush itself in sculpt uses the right brush). Also, if you create the texture from the texture panel instead of via the tool shelf, the preview thumbnail doesn't get generated at all, and stays empty.%%%

Nicholas Bishop commented

2011-01-18 03:24:35 +01:00

%%%Thanks, reopened. Thought you meant an entirely different problem, but this is indeed still a bug :)%%%

Nicholas Bishop commented

2011-01-18 05:33:15 +01:00

%%%OK, brush texture should get regenerated now. Marking fixed again.%%%

Danny McGrath commented

2011-01-18 06:12:17 +01:00

%%%Not to be a pest or anything (hehe), but now I noticed that my tiny preview icons of the current texture, in the texture panel, are missing again (they only started working for me a few days ago). Im guessing this is a bug again?

I also attached a screenshot "Missing icons 3.png" to this report. Lemmie know if you need anything else.%%%

%%%Not to be a pest or anything (hehe), but now I noticed that my tiny preview icons of the current texture, in the texture panel, are missing again (they only started working for me a few days ago). Im guessing this is a bug again? I also attached a screenshot "Missing icons 3.png" to this report. Lemmie know if you need anything else.%%%

Danny McGrath commented

2011-01-19 19:11:17 +01:00

%%%Okay, it seems that this bug is back again, possibly since #25720 fixed the broken mini thumbnails that I reported above.

I mentioned the problem to Ton on irc, so I think he is at least looking into the problem.

In the meantime, I will also attach a screenshot to confirm, to this post. I will also reply back here if the matter is resolved (assuming Ton doesn't comment here first, of course).

%%%

%%%Okay, it seems that this bug is back again, possibly since #25720 fixed the broken mini thumbnails that I reported above. I mentioned the problem to Ton on irc, so I think he is at least looking into the problem. In the meantime, I will also attach a screenshot to confirm, to this post. I will also reply back here if the matter is resolved (assuming Ton doesn't comment here first, of course). %%%

Ton Roosendaal commented

2011-01-19 19:29:49 +01:00

%%%I reopen this report, I suggest Nicholas should consult me first before working more here :)%%%

Sergey Sharybin commented

2011-09-22 20:53:47 +02:00

%%%Any update here?%%%

Nicholas Bishop commented

2011-09-24 19:19:32 +02:00

%%%Sergey - my original fix for this bug was completely wrong, but I haven't looked into it since then.%%%

ronan ducluzeau commented

2012-01-19 16:19:52 +01:00

%%%ubuntu 11.04 64bits rev43524

I can't reproduce initial bug about brushes preview icons in UV editor.

About little preview icons in texture panel, I noticed that texture panel have no list template for brushes.
Tiny texture icons seem to be created for these lists.

%%%

%%%ubuntu 11.04 64bits rev43524 I can't reproduce initial bug about brushes preview icons in UV editor. About little preview icons in texture panel, I noticed that texture panel have no list template for brushes. Tiny texture icons seem to be created for these lists. %%%

Nicholas Bishop commented

2012-02-06 06:57:06 +01:00

%%%Unassigning self, following UI code makes my head hurt too much :)%%%

Sergey Sharybin commented

2012-02-09 09:53:21 +01:00

%%%Looking into this issue.%%%

Sergey Sharybin commented

2012-02-11 12:44:33 +01:00

%%%Ok, issue is caused by starting Icon Preview render job from two places: from texture buttons for small icon preview and from properties panel in image editor for large icon of texture. This preview job is starting in suspended mode and if new instance of the same job is starting, suspended job will be totally stopped. This is normally for cases when you're changing different settings -- in this case you'd wouldn't want re-render be triggered on every slide change. But what we've have with brush preview is that two instances of this job were creating for large and small icon separately, but because of described policy only one icon was rendered. Can see several ways to resolve the issue:

Make job's owner icon rect instead of ID. But it'll lead to extra renderers created, so don't like this.
Render all icon sizes if one of icons was changed. It'll require minimal changes but will introduce slowdown in cases if large texture icon isn't needed (i.e. texture isn't used by any brushes). So also don't like this approach.
If suspended job is getting to be stopped, check if it was started for the same icon resolution and if not, that resolution will be also rendered in new job. So it'll be still minimal re-rendering happens, but in cases when job was started from two places for different icon sizes it'll work just fine.
There's patch in attachments where third approach was implemented.
Don't think i'll want such changes be commited so close to release..%%%

%%%Ok, issue is caused by starting Icon Preview render job from two places: from texture buttons for small icon preview and from properties panel in image editor for large icon of texture. This preview job is starting in suspended mode and if new instance of the same job is starting, suspended job will be totally stopped. This is normally for cases when you're changing different settings -- in this case you'd wouldn't want re-render be triggered on every slide change. But what we've have with brush preview is that two instances of this job were creating for large and small icon separately, but because of described policy only one icon was rendered. Can see several ways to resolve the issue: - Make job's owner icon rect instead of ID. But it'll lead to extra renderers created, so don't like this. - Render all icon sizes if one of icons was changed. It'll require minimal changes but will introduce slowdown in cases if large texture icon isn't needed (i.e. texture isn't used by any brushes). So also don't like this approach. - If suspended job is getting to be stopped, check if it was started for the same icon resolution and if not, that resolution will be also rendered in new job. So it'll be still minimal re-rendering happens, but in cases when job was started from two places for different icon sizes it'll work just fine. There's patch in attachments where third approach was implemented. Don't think i'll want such changes be commited so close to release..%%%

Nicholas Bishop commented

2012-02-11 12:58:42 +01:00

%%%From default blend:

In Textures panel, select Brush textures
Press New
Select Material textures
Click Browse button to show texture list

The small icon in the menu has not been updated. (Selecting the entry in the menu does then update the icon.)%%%

%%%From default blend: * In Textures panel, select Brush textures * Press New * Select Material textures * Click Browse button to show texture list The small icon in the menu has not been updated. (Selecting the entry in the menu does then update the icon.)%%%

Sergey Sharybin commented

2012-02-11 14:01:43 +01:00

%%%Managed to reproduce and fix issue. In fact, it wasn't so nice idea of always using large icons for search menus in commit 28779. Now it should behave properly.%%%

Sergey Sharybin commented

2012-02-11 14:15:50 +01:00

%%%It was wrong patch attached. Attaching correct one.%%%

Sergey Sharybin commented

2012-02-11 14:21:29 +01:00

%%%Fixed update of brush texture in sculpt mode.%%%

Brecht Van Lommel commented

2012-02-17 15:35:17 +01:00

%%%Patch looks ok to me, only suggestion from me is in interface_layout.c and interface_templates.c, it could use the ICON_SIZE_PREVIEW/ICON_SIZE_ICON constants there?%%%

Sergey Sharybin commented

2012-02-17 17:08:26 +01:00

%%%Fixed in svn rev44192. Thanks for the report, tests and review!%%%

Sergey Sharybin commented

2012-02-17 17:08:27 +01:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2012-02-17 17:08:27 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Image editor paint icon missing until enter weight paint #25649