Island Select Mode Change #31869

New Issue

Anthony Edlin · 2012-06-19T02:59:16+02:00

Anthony Edlin commented

2012-06-19 02:59:16 +02:00

Patch for: #31830

%%%Changed island select mode to select by nearest vert or edge or face, instead of just by nearest vert.
Also changed island select mode to draw face centers because of this change.%%%

**Patch for**: #31830 %%%Changed island select mode to select by nearest vert or edge or face, instead of just by nearest vert. Also changed island select mode to draw face centers because of this change.%%%

Anthony Edlin commented

2012-06-19 02:59:16 +02:00

Changed status to: 'Open'

Anthony Edlin commented

2012-06-24 20:22:53 +02:00

%%%Added a second patch (has to be applied after the first patch) that fixes up some comments in the uv system and renames find_nearest_uv_face to uv_find_nearest_face to be consistent with other functions.%%%

Dalai Felinto commented

2012-06-25 19:19:43 +02:00

%%%quick suggestion for future patches: better always attach only the final patch, instead of incremental ones.%%%

Anthony Edlin commented

2012-06-25 20:00:35 +02:00

%%%Actually I think I disagree here, the second patch is only style cleanup with no functional change, and from what I understand it is better to not mix functional change with style cleanup, no? If I had mixed them together then someone (if they follow that convention) should really seperate them out. That said, I could have made a second patch in the tracker, but as applying either patch would break the other they really are interdependent. It doesn't matter much to me, but, if I mix a bunch of style cleanup into the patches that I put here then they tend to be bigger and harder to review, and getting anyone to review patches in this tracker is hard enough, that I don't want to let anyone have an excuse not to do it. I think these patches are fairly simple to understand if you actually look at them.

If this isn't going to get reviewed because I've done the work of seperating out style cleanup from functional change, then I just uploaded another patch that mixes them together, so there really is no excuse now.

Thanks.%%%

%%%Actually I think I disagree here, the second patch is only style cleanup with no functional change, and from what I understand it is better to not mix functional change with style cleanup, no? If I had mixed them together then someone (if they follow that convention) should really seperate them out. That said, I could have made a second patch in the tracker, but as applying either patch would break the other they really are interdependent. It doesn't matter much to me, but, if I mix a bunch of style cleanup into the patches that I put here then they tend to be bigger and harder to review, and getting anyone to review patches in this tracker is hard enough, that I don't want to let anyone have an excuse not to do it. I think these patches are fairly simple to understand if you actually look at them. If this isn't going to get reviewed because I've done the work of seperating out style cleanup from functional change, then I just uploaded another patch that mixes them together, so there really is no excuse now. Thanks.%%%

Anthony Edlin commented

2012-06-25 20:35:15 +02:00

%%%Don't get me wrong I've done it both ways here on this tracker, but it would be nice to know if there is an official stance on how much to include in patches. I develop using git branches and I keep most of the changes separate, but then collect them to put a patch here on the tracker, and sometimes I've changed a bunch of stuff, including style that isn't related to functional change, and it just makes the patches bigger and harder to understand, so this time I kept it separate.%%%

Anthony Edlin commented

2012-10-29 21:45:10 +01:00

%%%I've attached another version of the patch that fixes some breakages from trunk. Also I removed turning on face centers and island select no longer uses face centers to find the nearest island. This is better because when using island select on dense meshes showing face centers it can become noisy. Also just including edges in island select was enough to fix the issue. The new file is island_select_v2.patch.

I've also made a video demonstrating this patch at: https://www.youtube.com/watch?v=Vngz1JJwm1M

Thanks.

%%%

%%%I've attached another version of the patch that fixes some breakages from trunk. Also I removed turning on face centers and island select no longer uses face centers to find the nearest island. This is better because when using island select on dense meshes showing face centers it can become noisy. Also just including edges in island select was enough to fix the issue. The new file is island_select_v2.patch. I've also made a video demonstrating this patch at: https://www.youtube.com/watch?v=Vngz1JJwm1M Thanks. %%%

Anthony Edlin commented

2014-09-18 09:52:58 +02:00

Changed status from 'Open' to: 'Resolved'

Anthony Edlin closed this issue

2014-09-18 09:52:58 +02:00

Anthony Edlin self-assigned this 2014-09-18 09:52:58 +02:00

Anthony Edlin commented

2014-09-18 09:52:58 +02:00

A change similar to what this patch did was added a while ago when some UV code was getting refactored.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Island Select Mode Change #31869