Logical operations (AND, XOR, OR, NOT, ==) in maths nodes #32566

New Issue

Stuart Broadfoot · 2012-09-16T21:35:29+02:00

Stuart Broadfoot commented

2012-09-16 21:35:29 +02:00

%%%I have added the operations for bitwise (XOR, OR, AND) operations in the maths node. These convert the floating variable into integers before appying. I have also included a NOT operation, which acts by simply taking the float value from 1, and a equals(==) test. These operations are available in all the math nodes (cycles, compositing and textures). All of these operations can already be performed by combining other basic maths operations but I found that for certain advanced cycles materials this added unnecessary complexity.

This is actually my first patch, so if there's any mistake or advice then please let me know.

Stuart%%%

%%%I have added the operations for bitwise (XOR, OR, AND) operations in the maths node. These convert the floating variable into integers before appying. I have also included a NOT operation, which acts by simply taking the float value from 1, and a equals(==) test. These operations are available in all the math nodes (cycles, compositing and textures). All of these operations can already be performed by combining other basic maths operations but I found that for certain advanced cycles materials this added unnecessary complexity. This is actually my first patch, so if there's any mistake or advice then please let me know. Stuart%%%

Stuart Broadfoot commented

2012-09-16 21:35:29 +02:00

Changed status to: 'Open'

Yasuhiro Fujii commented

2012-09-17 10:18:54 +02:00

%%%I think this patch would be more useful if it supports real value from 0 to 1.
For example, following equations can be derived if we interpret input/output values as probabilities.

AND: result = x * y
NOT: result = 1 - x
OR: result = 1 - (1 - x) * (1 - y) = x + y - xy
XOR: result = (x + y - xy) * (1 - x * y)

Here, x, y are input values and should be clipped from 0 to 1.%%%

%%%I think this patch would be more useful if it supports real value from 0 to 1. For example, following equations can be derived if we interpret input/output values as probabilities. AND: result = x * y NOT: result = 1 - x OR: result = 1 - (1 - x) * (1 - y) = x + y - xy XOR: result = (x + y - xy) * (1 - x * y) Here, x, y are input values and should be clipped from 0 to 1.%%%

Yasuhiro Fujii commented

2012-09-17 11:16:11 +02:00

%%%Sorry. XOR equation was wrong.

XOR extension for real values has some choices, I recommended

  x + y - 2xy

for better symmetries.%%%

%%%Sorry. XOR equation was wrong. XOR extension for real values has some choices, I recommended ``` x + y - 2xy ``` for better symmetries.%%%

Stuart Broadfoot commented

2012-09-26 00:00:36 +02:00

%%%I agree and have made an updated patch exactly as you describe. Thanks!%%%

Cody Wilson commented

2014-01-13 03:06:23 +01:00

Added subscriber: @Etherian

Sergey Sharybin commented

2015-04-16 13:41:40 +02:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2015-04-16 13:41:40 +02:00

Sergey Sharybin self-assigned this 2015-04-16 13:41:40 +02:00

Sergey Sharybin commented

2015-04-16 13:41:40 +02:00

The issue with this patch is that it adds quite reasonable amount of complexity to SVM node, which does not have chance to be optimized out (as it's possible with OSL nodes). This means regular kernel might become slower just because some really specific operations.

I'd prefer to keep nodes a small basis which then can be used to construct expressions. The thing which would help with this is having some node group templates, which is actually in the list to be done anyway.

So thanks for the patch, but we can't apply it.

The issue with this patch is that it adds quite reasonable amount of complexity to SVM node, which does not have chance to be optimized out (as it's possible with OSL nodes). This means regular kernel might become slower just because some really specific operations. I'd prefer to keep nodes a small basis which then can be used to construct expressions. The thing which would help with this is having some node group templates, which is actually in the list to be done anyway. So thanks for the patch, but we can't apply it.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Logical operations (AND, XOR, OR, NOT, ==) in maths nodes #32566