Do not recalculate normals when rendering. #33009

Closed
opened 2012-10-29 09:47:14 +01:00 by Alexander Trum · 13 comments

%%%Patch introducing a switch which prevents the recalculation of mesh normals when rendering.%%%

%%%Patch introducing a switch which prevents the recalculation of mesh normals when rendering.%%%
Author

Changed status to: 'Open'

Changed status to: 'Open'

%%%Please, please, please include this patch into trunk!%%%

%%%Please, please, please include this patch into trunk!%%%

%%%This would be very useful for game devs. who are making foliage. Please merge to trunk :)%%%

%%%This would be very useful for game devs. who are making foliage. Please merge to trunk :)%%%

%%%And even more important for rendering models coming from CAD packages.%%%

%%%And even more important for rendering models coming from CAD packages.%%%
Author

%%%One of our users found a case where the normals are recalculated even with the patch.
So I am working on an enhanced patch now.
I will merge to trunk as soon as I am successful.%%%

%%%One of our users found a case where the normals are recalculated even with the patch. So I am working on an enhanced patch now. I will merge to trunk as soon as I am successful.%%%

%%%It is global preference switch?
I think better solution is to make switch within mesh RNA, so both auto recalculated and manual normals mesh objects will be possible in scene.%%%

%%%It is global preference switch? I think better solution is to make switch within mesh RNA, so both auto recalculated and manual normals mesh objects will be possible in scene.%%%
Author

%%%Now I had the time to enhance the patch. Normals will now be preserved when switching to the edit mode, too. I will attach the new patch file.

I am very new in Blender. So I do not know what Mr. Caslava means with "I think better solution is to make switch within mesh RNA ...". So i still have a global preference switch for preserving the original normals.

Furthermore I have made the changes in Blender 2.63a.
Can anybody help me with merging to trunk?%%%

%%%Now I had the time to enhance the patch. Normals will now be preserved when switching to the edit mode, too. I will attach the new patch file. I am very new in Blender. So I do not know what Mr. Caslava means with "I think better solution is to make switch within mesh RNA ...". So i still have a global preference switch for preserving the original normals. Furthermore I have made the changes in Blender 2.63a. Can anybody help me with merging to trunk?%%%
Author

%%%Now the new patch file.%%%

%%%Now the new patch file.%%%

%%%I can see this functionality is useful but a proper implementation is more complicated than this patch.

  • This shouldn't be a user preference, but rather a setting on a mesh datablock.
  • This patch only modifies two functions, I don't think this will reliably disable normal map calculation in all places and will still calculate them when needed. Did you go over all mesh related tools and check if they work as expected with this patch?
  • New vertices or faces should still get their normals calculated?
  • There shouldn't be printf debug messages left in the patch%%%
%%%I can see this functionality is useful but a proper implementation is more complicated than this patch. * This shouldn't be a user preference, but rather a setting on a mesh datablock. * This patch only modifies two functions, I don't think this will reliably disable normal map calculation in all places and will still calculate them when needed. Did you go over all mesh related tools and check if they work as expected with this patch? * New vertices or faces should still get their normals calculated? * There shouldn't be printf debug messages left in the patch%%%
Author

%%%1. I'm new to Blender. Is there an example how to add a new setting to the mesh datablock?

  1. I haven't checked all Blender source (i'm a newbie). We have only used the patched Blender intensively.

  2. If this can happen, then I have to check, if normals already exist or not.

  3. Sorry.

What must I provide? How can we proceed?%%%

%%%1. I'm new to Blender. Is there an example how to add a new setting to the mesh datablock? 2. I haven't checked all Blender source (i'm a newbie). We have only used the patched Blender intensively. 3. If this can happen, then I have to check, if normals already exist or not. 4. Sorry. What must I provide? How can we proceed?%%%

%%%I'm also interested in this patch, if any bump is worth the effort.%%%

%%%I'm also interested in this patch, if any bump is worth the effort.%%%

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Bastien Montagne self-assigned this 2014-08-15 19:40:14 +02:00

Thinks it’s time to archive, we have custom normals support (internal/cycles included) incoming now…

Thinks it’s time to archive, we have custom normals support (internal/cycles included) incoming now…
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#33009
No description provided.