ALTERNATE improvements to spline behavior with a SINGLE handle selected #36048

New Issue

David Jeske · 2013-07-07T21:15:29+02:00

David Jeske commented

2013-07-07 21:15:29 +02:00

%%%This patch is an ALTERNATIVE to my previous spline patch here:

http://projects.blender.org/tracker/?func=detail&aid=36029&group_id=9&atid=127

Personally, I think the OTHER patch is MUCH better and more intuitive behavior. However, this patch is more conservative in that it changes NOTHING about the way the menu works.. .it merely adds tooltips, fixes some visual bugs, adds single-handle scaling, and adds a rotation-constraint visual.

I think it is MUCH better to evaluate these patches by trying them out than by thinking about it. Set a handle-pair to "align", then choose one handle and choose "Free". Patch [#36029] will always allow that handle to be freely rotated. This patch keeps the current behavior that the handle freely rotates, unless the other handle type is align, in which case the other handle becomes rotation constrained.

A good way to understand the difference is to consider the tooltips.

Patch [#36029] KEEP-DOCS / FIX-BEHAVIOR
Free - allows the handle to rotate independently from the other handle.
Align - aligns the handle with the other handle
Align + Constrain - aligns the handle with the other hand and constrains it's rotation

Patch [this one] KEEP-BEHAVIOR / FIX-DOCS
Free - Align the handle(s) to the other. If the other handle is Free, Vector, or Auto, this will cause the handle to be rotation constrained.
Align - Allow the handle(s) to freely rotate. To allow the handle to rotate independently, set the other handle to Free, Vector, or Auto.

%%%

%%%This patch is an ALTERNATIVE to my previous spline patch here: http://projects.blender.org/tracker/?func=detail&aid=36029&group_id=9&atid=127 Personally, I think the OTHER patch is *MUCH* better and more intuitive behavior. However, this patch is more conservative in that it changes NOTHING about the way the menu works.. .it merely adds tooltips, fixes some visual bugs, adds single-handle scaling, and adds a rotation-constraint visual. I think it is MUCH better to evaluate these patches by trying them out than by thinking about it. Set a handle-pair to "align", then choose one handle and choose "Free". Patch [#36029] will always allow that handle to be freely rotated. This patch keeps the current behavior that the handle freely rotates, unless the other handle type is align, in which case the other handle becomes rotation constrained. A good way to understand the difference is to consider the tooltips. Patch [#36029] KEEP-DOCS / FIX-BEHAVIOR Free - allows the handle to rotate independently from the other handle. Align - aligns the handle with the other handle Align + Constrain - aligns the handle with the other hand and constrains it's rotation Patch [this one] KEEP-BEHAVIOR / FIX-DOCS Free - Align the handle(s) to the other. If the other handle is Free, Vector, or Auto, this will cause the handle to be rotation constrained. Align - Allow the handle(s) to freely rotate. To allow the handle to rotate independently, set the other handle to Free, Vector, or Auto. %%%

David Jeske commented

2013-07-07 21:15:29 +02:00

Changed status to: 'Open'

David Jeske commented

2013-07-07 21:31:18 +02:00

%%%small typo in the tooltip on v1, new v2 uploaded%%%

David Jeske commented

2013-07-20 16:12:13 +02:00

%%%also, looks like my summary above was wrong at the end.. it should say...

Patch [this one] KEEP-BEHAVIOR / FIX-DOCS

Align - Align the handle(s) to the other. If the other handle is Free, Vector, or Auto, this will cause the handle to be rotation constrained.
Free - Allow the handle(s) to freely rotate. To allow the handle to rotate independently, set the other handle to Free, Vector, or Auto.
%%%

%%%also, looks like my summary above was wrong at the end.. it should say... Patch [this one] KEEP-BEHAVIOR / FIX-DOCS Align - Align the handle(s) to the other. If the other handle is Free, Vector, or Auto, this will cause the handle to be rotation constrained. Free - Allow the handle(s) to freely rotate. To allow the handle to rotate independently, set the other handle to Free, Vector, or Auto. %%%

David Jeske commented

2013-09-02 20:57:44 +02:00

%%%.... as I've mentioned in my bf-committers thread on these two patches.. I now see the value in accepting this patch vs the other one, because it's the conservative choice which does not change behavior (it just fixes bugs, adds tooltips, and adds a rotation constraint visual)

The patch might need one portability tweak, which is to use int instead of the enum in the function paramater declaration.. it compiles fine on gcc, but I'm told MSVC might not like this because of the way blender avoids header includes and standard C dislikes forward declared enums.

void BKE_nurbList_handles_set(struct ListBase *editnurb, enum eHandleSetModes mode)

so blender uses this instead..

void BKE_nurbList_handles_set(struct ListBase editnurb, int mode) / enum eHandleSetModes mode */
%%%

%%%.... as I've mentioned in my bf-committers thread on these two patches.. I now see the value in accepting this patch vs the other one, because it's the conservative choice which does not change behavior (it just fixes bugs, adds tooltips, and adds a rotation constraint visual) The patch might need one portability tweak, which is to use int instead of the enum in the function paramater declaration.. it compiles fine on gcc, but I'm told MSVC might not like this because of the way blender avoids header includes and standard C dislikes forward declared enums. void BKE_nurbList_handles_set(struct ListBase *editnurb, enum eHandleSetModes mode) so blender uses this instead.. void BKE_nurbList_handles_set(struct ListBase *editnurb, int mode) /* enum eHandleSetModes mode */ %%%

Campbell Barton commented

2013-09-30 18:47:49 +02:00

%%%closing requested by David Jeske%%%

Campbell Barton commented

2013-09-30 18:47:49 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2013-09-30 18:47:49 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

ALTERNATE improvements to spline behavior with a SINGLE handle selected #36048