IMAGE_OT_invert() misses UNDO support, won't update if buffer is float #37326

New Issue

CodeManX · 2013-11-05T15:48:03+01:00

CodeManX commented

2013-11-05 15:48:03 +01:00

%%%--- Operating System, Graphics card ---
Windows 7

- Blender version with error, and version that worked ---

2.69

- Short description of error ---

The Invert Channels operator does not properly support UNDO, images will corrupt if used together with Paint strokes.

If the buffer type is float, the image won't update in Image editor (buffer itself is fine though, Image.update(), Area.update() with python correct it).

- Steps for others to reproduce the error (preferably based on attached .blend file) ---

Create a new image, 32bit float
Go to Paint mode
Draw a few strokes
Image > Invert > Invert Red Channel (for instance)
Black won't change to red
Ctrl + Z
Invert op result becomes visible, last stroke is removed and around the stroke path, color is reverted to black in squares (see attached image)

There is no image undo stack, only paint. Would it still be appropriate to use?%%%

%%%--- Operating System, Graphics card --- Windows 7 - Blender version with error, and version that worked --- 2.69 - Short description of error --- The Invert Channels operator does not properly support UNDO, images will corrupt if used together with Paint strokes. If the buffer type is float, the image won't update in Image editor (buffer itself is fine though, Image.update(), Area.update() with python correct it). - Steps for others to reproduce the error (preferably based on attached .blend file) --- 1. Create a new image, 32bit float 2. Go to Paint mode 3. Draw a few strokes 4. Image > Invert > Invert Red Channel (for instance) 5. Black won't change to red 6. Ctrl + Z 7. Invert op result becomes visible, last stroke is removed and around the stroke path, color is reverted to black in squares (see attached image) There is no image undo stack, only paint. Would it still be appropriate to use?%%%

CodeManX commented

2013-11-05 15:48:03 +01:00

Changed status to: 'Open'

Sergey Sharybin commented

2013-11-06 09:53:47 +01:00

%%%Bastien, if you're looking into the issue please assign it to self. Otherwise assign to me :)%%%

Bastien Montagne commented

2013-11-06 09:56:42 +01:00

%%%Nah, had just a very quick look at it, the UNDO flag is enabled for this op, so it’s not a simple fix (at least for me)… :/%%%

Antonis Ryakiotakis commented

2013-11-07 18:25:55 +01:00

%%%This could use the paint undo stack. Maybe it's not so good abusing this for out of paint operations. But if you think it's a good idea assign to me and I'll do it.%%%

Sergey Sharybin removed their assignment 2013-11-18 09:24:10 +01:00

Antonis Ryakiotakis was assigned by Sergey Sharybin

2013-11-18 09:24:10 +01:00

Sergey Sharybin commented

2013-11-18 09:24:10 +01:00

Fixed part of the issue in master branch now, so now float buffers will be nicely updated.

Antony, fixing remaining issue with undo in paint mode seems a bit more tricky. This is stack conflicts (global one where Invert operator pushes the data and local one where the strokes are stored). Seems to be the only way is to use paint undo stack for invert when in paint mode..

Will re-assign to you, since you're more familiar with that system :)

Fixed part of the issue in master branch now, so now float buffers will be nicely updated. Antony, fixing remaining issue with undo in paint mode seems a bit more tricky. This is stack conflicts (global one where Invert operator pushes the data and local one where the strokes are stored). Seems to be the only way is to use paint undo stack for invert when in paint mode.. Will re-assign to you, since you're more familiar with that system :)

Antonis Ryakiotakis commented

2013-11-26 00:54:41 +01:00

Attached a patch. I could use a LGTM from other devs as well. Mostly wondering about bad level calls from inclusion of sculpt-paint headers in space_image operations. Also having an operator only undoable on certain situations seems slightly bad to me.

Antonis Ryakiotakis commented

2013-11-26 00:57:04 +01:00

Note, do not commit patch without scons inclusion for sculpt_paint as well

Antonis Ryakiotakis commented

2013-12-09 22:13:18 +01:00

Changed status from 'Open' to: 'Resolved'

Antonis Ryakiotakis closed this issue

2013-12-09 22:13:18 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

IMAGE_OT_invert() misses UNDO support, won't update if buffer is float #37326