Mist and global ambient for Multitexture and GLSL #37492

New Issue

Thomas Szepe · 2013-11-16T15:44:57+01:00

Thomas Szepe commented

2013-11-16 15:44:57 +01:00

This patch fixes the most mist and ambient bugs for the BGE. It is also adding mist and ambient render to the viewport for the multitexture mode.

Changing the mist values are now working in GLSL in the BGE
F-Curve now working for in the BGE for Ambient Color, Horizon Color, Start, Distance, Maximum Intensity.
Blender UI mode now grays out the values that does not effect the mist (multitexture).
Blender viewport now renders the mist and ambient light in multitexture mode.
World value and F-Curve changes now update immediately the Blender view port.
The background color for BGE and Blender viewport in GLSL is now displaying correct if the Color management is inactive.
Add "Render Mist" button to the properties panel under display (disable mist while working).
Move the world API from render to sce.world.
Mist now not automatically activated when a value will be changed.
Changed "MistEnd" to "mist_distance".
Add "mist_intensity" and "mist_type" to the API.
Enable the material render for GLSL + Solid, to display the material and GLSL mist correct (http://developer.blender.org/T37415).
Removed unnecessary BlenderWorldInfo.
Fixed (bug) double called KX_PYATTRIBUTE_RO_FUNCTION("lights", KX_Scene, pyattr_get_lights). Replaced it with the new world.

Known issues.

Ambient light in multitexture is different between Blender viewport and BGE.
Material ambient value not working in Blender viewport.
Font objects not renders with ambient light in the BGE (no material, bug in the trunk).
Font objects in GLSL not renders with mist and ambient light (no material, bug in the trunk).
Disabling mist for material (Use Mist button) only works in GLSL + textured.
The Blender viewport render in GLSL + Solid is different to BGE (GLSL + Solid = Multitexture, bug in the trunk).
If are two F-Curves activated to a different time, one F-Cvurve will overwrite the values form the other curve while the are running (bug in the trunk).
For textured objects ambient light in the BGE only works if "face Textures" or if "alpha" is enable or a blend mode higher then "Screen" is used (texture pipeline problem).

mist10.2.patch

This patch fixes the most mist and ambient bugs for the BGE. It is also adding mist and ambient render to the viewport for the multitexture mode. 1. Changing the mist values are now working in GLSL in the BGE 2. F-Curve now working for in the BGE for Ambient Color, Horizon Color, Start, Distance, Maximum Intensity. 3. Blender UI mode now grays out the values that does not effect the mist (multitexture). 4. Blender viewport now renders the mist and ambient light in multitexture mode. 5. World value and F-Curve changes now update immediately the Blender view port. 6. The background color for BGE and Blender viewport in GLSL is now displaying correct if the Color management is inactive. 7. Add "Render Mist" button to the properties panel under display (disable mist while working). 8. Move the world API from render to sce.world. 9. Mist now not automatically activated when a value will be changed. 10. Changed "MistEnd" to "mist_distance". 11. Add "mist_intensity" and "mist_type" to the API. 12. Enable the material render for GLSL + Solid, to display the material and GLSL mist correct (http://developer.blender.org/T37415). 13. Removed unnecessary BlenderWorldInfo. 14. Fixed (bug) double called KX_PYATTRIBUTE_RO_FUNCTION("lights", KX_Scene, pyattr_get_lights). Replaced it with the new world. Known issues. 1. Ambient light in multitexture is different between Blender viewport and BGE. 2. Material ambient value not working in Blender viewport. 3. Font objects not renders with ambient light in the BGE (no material, bug in the trunk). 4. Font objects in GLSL not renders with mist and ambient light (no material, bug in the trunk). 5. Disabling mist for material (Use Mist button) only works in GLSL + textured. 6. The Blender viewport render in GLSL + Solid is different to BGE (GLSL + Solid = Multitexture, bug in the trunk). 7. If are two F-Curves activated to a different time, one F-Cvurve will overwrite the values form the other curve while the are running (bug in the trunk). 8. For textured objects ambient light in the BGE only works if "face Textures" or if "alpha" is enable or a blend mode higher then "Screen" is used (texture pipeline problem). [mist10.2.patch](https://archive.blender.org/developer/F28024/mist10.2.patch)

Thomas Szepe commented

2013-11-16 15:44:57 +01:00

Changed status to: 'Open'

Thomas Szepe commented

2013-11-16 15:44:57 +01:00

Added subscriber: @hg1

Mitchell Stokes was assigned by Brecht Van Lommel

2013-11-18 13:06:32 +01:00

Mitchell Stokes commented

2013-11-18 17:41:52 +01:00

I wonder if this would be a good candidate for using Differential (Phabricator's code review module). Would you mind uploading a diff to Differential and adding Kupoman and myself as reviewers?

Thomas Szepe commented

2013-11-18 19:26:59 +01:00

I generated a GIT diff from the mist patch. I don't have much experience with git, I hope that it works.

Mitchell Stokes commented

2013-11-18 21:21:43 +01:00

Upload the diff here: http://developer.blender.org/differential/diff/create/ and add me as reviewer.

solarlune commented

2014-01-17 16:55:47 +01:00

Added subscriber: @solarlune

Nicholas Polet commented

2014-01-24 19:47:56 +01:00

Added subscriber: @NickPolet

Thomas Szepe commented

2014-01-24 23:01:26 +01:00

@ solarlune and klauser I made a series of patch like Brecht suggested.
This are the actual patches.
D148, D149, D150, D151, D152, D154, D155, D156, D157, D158, D159, D200.

@ solarlune and klauser I made a series of patch like Brecht suggested. This are the actual patches. [D148](https://archive.blender.org/developer/D148), [D149](https://archive.blender.org/developer/D149), [D150](https://archive.blender.org/developer/D150), [D151](https://archive.blender.org/developer/D151), [D152](https://archive.blender.org/developer/D152), [D154](https://archive.blender.org/developer/D154), [D155](https://archive.blender.org/developer/D155), [D156](https://archive.blender.org/developer/D156), [D157](https://archive.blender.org/developer/D157), [D158](https://archive.blender.org/developer/D158), [D159](https://archive.blender.org/developer/D159), [D200](https://archive.blender.org/developer/D200).

lopata commented

2014-01-25 00:30:46 +01:00

Added subscriber: @lopataasdf

lopata commented

2014-01-25 00:30:46 +01:00

Is it possible to add ssao to the viewport in GLSL mode? This would be useful for fast rendering many scenes using OpenGL

http://blenderartists.org/forum/showthread.php?234822-new-and-fast-SSAO
http://blenderartists.org/forum/showthread.php?184102-nicer-and-faster-SSAO

Is it possible to add ssao to the viewport in GLSL mode? This would be useful for fast rendering many scenes using OpenGL http://blenderartists.org/forum/showthread.php?234822-new-and-fast-SSAO http://blenderartists.org/forum/showthread.php?184102-nicer-and-faster-SSAO

Thomas Szepe commented

2014-01-25 10:13:26 +01:00

@lopataasdf yes it is possible. But this is not topic of this patch. Please do not discuss here about non-related topics.

Nicholas Polet commented

2014-01-26 15:17:46 +01:00

@hg1, great to see that most of these revisions have been accepted, can't wait for this to be part of the master repo. Also like the more pythonic naming convention. It's a shame that some of the bge api is Camel Case and some of it pep8, but at least new additions like this are opting for the pep8 naming conventions. Great work.

Adam Friesen commented

2014-05-09 05:50:23 +02:00

Added subscriber: @Ace_Dragon

Adam Friesen commented

2014-05-09 05:50:23 +02:00

Hey Moguri, now that you have a contract with the BF, perhaps you will now be able to review this patch for HG1?

HG1 himself has mentioned on Blenderartists that it's been frustrating to not get a timely review and is on the verge of giving up, so that's why I want to bring this back to your attention.

Hey Moguri, now that you have a contract with the BF, perhaps you will now be able to review this patch for HG1? HG1 himself has mentioned on Blenderartists that it's been frustrating to not get a timely review and is on the verge of giving up, so that's why I want to bring this back to your attention.

Mitchell Stokes commented

2014-05-09 05:58:49 +02:00

@Ace_Dragon, see the individual Differential patches, I've already reviewed all of them.

Mitchell Stokes commented

2014-07-11 08:48:40 +02:00

Changed status from 'Open' to: 'Archived'

Mitchell Stokes closed this issue

2014-07-11 08:48:40 +02:00

Mitchell Stokes commented

2014-07-11 08:48:40 +02:00

Closing this task since it's now in Differential (D148, D149, D150, D151, D152, D154, D155, D156, D157, D158, D159, D200).

Closing this task since it's now in Differential ([D148](https://archive.blender.org/developer/D148), [D149](https://archive.blender.org/developer/D149), [D150](https://archive.blender.org/developer/D150), [D151](https://archive.blender.org/developer/D151), [D152](https://archive.blender.org/developer/D152), [D154](https://archive.blender.org/developer/D154), [D155](https://archive.blender.org/developer/D155), [D156](https://archive.blender.org/developer/D156), [D157](https://archive.blender.org/developer/D157), [D158](https://archive.blender.org/developer/D158), [D159](https://archive.blender.org/developer/D159), [D200](https://archive.blender.org/developer/D200)).

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Mist and global ambient for Multitexture and GLSL #37492