Remove Hard-Coded Keymap Items #37520

New Issue

Jonathan Williamson · 2013-11-18T17:27:42+01:00

2013-11-18 17:27:42 +01:00

A few keymap items are still hard-coded in C. These should be removed and implemented in Python through the normal keymap instead.

Hard-coded Keys

I to insert keyframe on a value

//Edit, there are quite a few others remaining,
see: https://www.blender.org/manual/interface/common_shortcuts.html

A few keymap items are still hard-coded in C. These should be removed and implemented in Python through the normal keymap instead. **Hard-coded Keys** - **I** to insert keyframe on a value ---- //Edit, there are quite a few others remaining, see: https://www.blender.org/manual/interface/common_shortcuts.html

Jonathan Williamson commented

2013-11-18 17:27:42 +01:00

Changed status to: 'Open'

Jonathan Williamson self-assigned this 2013-11-18 17:27:42 +01:00

Jonathan Williamson commented

2013-11-18 17:27:42 +01:00

Added subscribers: @JonathanWilliamson, @brecht, @cessen, @PawelLyczkowski-1, @billrey

Brecht Van Lommel commented

2013-11-18 18:18:52 +01:00

Basically the entire keymap to interact with buttons and panels is hardcoded, and we can make this partially configureable without too much effort. So what you could configure is keys like E eye dropper, I insert keyframe, D insert driver, K keying sets.

The other part like mouse clicks on buttons, up/down keys in a menu, backspace to remove text, etc would not be configureable but that's not a usual thing to be able to configure anyway, as the way all those things interact is necessarily quite complex and not something you want to expose.

For developers: this requires adding a UI 'modal' keymap (the name is a bit poor but these keymaps are used now during modal tools and this is basically the same kind of data structure we need). This then needs to get used in the UI code somehow in the place where these particular shortcut keys are used, where rather than checking the hardcoded event values you look them up in the keymap.

Basically the entire keymap to interact with buttons and panels is hardcoded, and we can make this partially configureable without too much effort. So what you could configure is keys like E eye dropper, I insert keyframe, D insert driver, K keying sets. The other part like mouse clicks on buttons, up/down keys in a menu, backspace to remove text, etc would not be configureable but that's not a usual thing to be able to configure anyway, as the way all those things interact is necessarily quite complex and not something you want to expose. For developers: this requires adding a UI 'modal' keymap (the name is a bit poor but these keymaps are used now during modal tools and this is basically the same kind of data structure we need). This then needs to get used in the UI code somehow in the place where these particular shortcut keys are used, where rather than checking the hardcoded event values you look them up in the keymap.

Jonathan Williamson commented

2013-11-18 18:20:49 +01:00

The eye dropper, insert keyframe, insert driver, etc are the only things that need to be configurable I think. They're so closely related to similar behaviors, such as Insert Keyframe in the 3D View.

The other things, like backspace don't need to be configured. I think so far as the user is concerned those are basically OS level keys (even if they're not technically.)

The eye dropper, insert keyframe, insert driver, etc are the only things that need to be configurable I think. They're so closely related to similar behaviors, such as *Insert Keyframe* in the 3D View. The other things, like backspace don't need to be configured. I think so far as the user is concerned those are basically OS level keys (even if they're not technically.)

Nadir commented

2013-11-18 20:06:11 +01:00

Added subscriber: @Nadirchibane

Nadir commented

2013-11-18 20:06:11 +01:00

It would be a better idea to add a button on the menu window Header. this button when clicked shows a ghost window (=with transparency), this window contain a keyboard layout where you can see and/or configure your key map.

Jonathan Williamson commented

2013-11-18 20:18:19 +01:00

@Nadirchibane I'm not sure I understand what you're referring to. But I believe you're suggesting a different way of accessing and editing the user keymap? If so that's completely unrelated to this task.

Jonathan Williamson removed their assignment 2013-11-24 18:07:15 +01:00

dennyrahadian commented

2014-01-02 21:15:20 +01:00

(Migrated from localhost:3001)

Added subscriber: @dennyrahadian

dennyrahadian commented

2014-01-02 21:15:20 +01:00

(Migrated from localhost:3001)

How about making the XYZ axes shortcuts remappable?
I think it's quite reasonable for (at least) two reasons:

Those who had experience with Maya usually prefers to use ZXC instead of XYZ since it's much easier to reach.
I heard a lot of complains from people who are using non conventional keyboards (like TrulyErgonomics or Ergodox), saying that they'd rather use the manipulator widget since the Y key is located too far.

How about making the XYZ axes shortcuts remappable? I think it's quite reasonable for (at least) two reasons: - Those who had experience with Maya usually prefers to use ZXC instead of XYZ since it's much easier to reach. - I heard a lot of complains from people who are using non conventional keyboards (like TrulyErgonomics or Ergodox), saying that they'd rather use the manipulator widget since the Y key is located too far.

KiJeon commented

2014-09-01 09:35:30 +02:00

Added subscriber: @0o00o0oo

KiJeon commented

2014-09-01 09:35:30 +02:00

I'd like to add that trackball rotate and edge slide both also seem to be hard-coded.
If they could be changed, it'd also provide a workaround until the "event system" issue is resolved (#40537)

I'd like to add that **trackball rotate** and **edge slide** both also seem to be hard-coded. If they could be changed, it'd also provide a workaround until the "event system" issue is resolved (#40537)

michael knubben commented

2014-09-07 11:29:51 +02:00

Added subscriber: @michaelknubben

Julian Eisel self-assigned this 2015-05-05 16:24:23 +02:00

Julian Eisel commented

2016-09-21 22:46:48 +02:00

Changed status from 'Open' to: 'Resolved'

Julian Eisel closed this issue

2016-09-21 22:46:48 +02:00

Julian Eisel commented

2016-09-21 22:46:48 +02:00

Finally found a surprisingly easy way to support operators with custom keymaps for UI (84b1d67b6, d10f54ee75) and added support for customizing shortcuts of...

Keyframe operators (e8d953000)
Driver and Keying Set operators (f6c09eadf0)
Eyedropper shortcut (e9bcdcdbbd)

Will close this task for now, if there are shortcuts that should get customization support we can do that as part of usual development. Don't think we really need to have a task sitting around at least.

Finally found a surprisingly easy way to support operators with custom keymaps for UI (84b1d67b6, d10f54ee75) and added support for customizing shortcuts of... * Keyframe operators (e8d953000) * Driver and Keying Set operators (f6c09eadf0) * Eyedropper shortcut (e9bcdcdbbd) ![ui_keymap.png](https://archive.blender.org/developer/F365960/ui_keymap.png) Will close this task for now, if there are shortcuts that should get customization support we can do that as part of usual development. Don't think we really need to have a task sitting around at least.

Jonathan Williamson commented

2016-09-25 19:55:16 +02:00

Fantastic, thanks @JulianEisel!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Remove Hard-Coded Keymap Items #37520