Customize keytype Color #37579

New Issue

Jose Molina Garcia · 2013-11-22T11:55:27+01:00

2013-11-22 11:55:27 +01:00

HI,

I've made a little modification to enable the customization of the keyframes color, separatly in "keyframe", "extreme","jitter","breakdown" and also for customize the keyframe border color, normal and selected.

I uploaded few screenshots and an example file to show the change made.

color_keyframes.blend

patch_keyframes_color.txt

HI, I've made a little modification to enable the customization of the keyframes color, separatly in "keyframe", "extreme","jitter","breakdown" and also for customize the keyframe border color, normal and selected. I uploaded few screenshots and an example file to show the change made. ![color_keyframes_custom_colorkeys1.png](https://archive.blender.org/developer/F29947/color_keyframes_custom_colorkeys1.png) ![color_keyframes_custom_colorkeys2.png](https://archive.blender.org/developer/F29948/color_keyframes_custom_colorkeys2.png) ![color_keyframes_color_default.png](https://archive.blender.org/developer/F29949/color_keyframes_color_default.png) ![color_keyframes_custom_colorborder](https://archive.blender.org/developer/F29950/color_keyframes_custom_colorborder) [color_keyframes.blend](https://archive.blender.org/developer/F29953/color_keyframes.blend) [patch_keyframes_color.txt](https://archive.blender.org/developer/F29956/patch_keyframes_color.txt)

Jose Molina Garcia commented

2013-11-22 11:55:27 +01:00

Changed status to: 'Open'

Jose Molina Garcia commented

2013-11-22 11:55:27 +01:00

Added subscriber: @JoseMolinaGarcia

Joshua Leung self-assigned this 2013-11-22 12:18:42 +01:00

Joshua Leung commented

2013-11-22 12:20:02 +01:00

Assigning to self.

venomgfx had a similar patch a few years ago, but that overlooked a few things, so I didn't apply it at the time (and then got busy). Will try to check on this sometime soon :)

Assigning to self. venomgfx had a similar patch a few years ago, but that overlooked a few things, so I didn't apply it at the time (and then got busy). Will try to check on this sometime soon :)

Joshua Leung commented

2013-11-22 13:36:28 +01:00

Ok, I've taken a look at the patch. IMO, there are a few things which need to be fixed before this can be applied.

Fixes Required:

It would be better if the selected and unselected colours for key types could be set independently instead of being automatically determined by a hardcoded metric. (See point 2)
Do not change the default colours in use already. This applies particularly for selected vs unselected ("normal") keyframes, and for the selected keyframe borders.

The RNA names for these settings aren't good ("KeyType" is too obscure jargon).

Change these to something like: "Keyframe" and "Breakdown Keyframe", etc.
Don't go changing the capitalisation of the names! Use the names as they are shown in the other menus

The same goes for the tooltips; drop the "KeyType" prefixes and adjust these to match the property names

Please submit a revised patch containing these fixes and/or a screenshot showing the default colours of keyframes after those changes.

Thanks for your efforts so far :)

Ok, I've taken a look at the patch. IMO, there are a few things which need to be fixed before this can be applied. **Fixes Required**: - It would be better if the **selected and unselected colours for key types could be set independently** instead of being automatically determined by a hardcoded metric. (See point 2) - **Do not change the default colours in use already**. This applies particularly for selected vs unselected ("normal") keyframes, and for the selected keyframe borders. # **The RNA names for these settings aren't good** ("KeyType" is too obscure jargon). - Change these to something like: "Keyframe" and "Breakdown Keyframe", etc. - Don't go changing the capitalisation of the names! Use the names as they are shown in the other menus # **The same goes for the tooltips**; drop the "KeyType" prefixes and adjust these to match the property names Please submit a revised patch containing these fixes and/or a screenshot showing the default colours of keyframes after those changes. Thanks for your efforts so far :)

Jose Molina Garcia commented

2013-11-23 11:09:13 +01:00

Hi,

I've made the fixes required, I hope the text from points 3 and 4 be better now. I upload the patch, and 2 screenshots with the default colours.

Thanks to you for review it so fast

patch_keyframes_colors_selected.txt

Hi, I've made the fixes required, I hope the text from points 3 and 4 be better now. I upload the patch, and 2 screenshots with the default colours. Thanks to you for review it so fast ![keyframe_colors_default_selected.png](https://archive.blender.org/developer/F31489/keyframe_colors_default_selected.png) ![keyframe_colors_default.png](https://archive.blender.org/developer/F31490/keyframe_colors_default.png) [patch_keyframes_colors_selected.txt](https://archive.blender.org/developer/F31488/patch_keyframes_colors_selected.txt)

Joshua Leung commented

2013-11-26 01:30:49 +01:00

Ok, I've tested your patch. I've found 2 bugs which need to be fixed:

The version patch for old theme files is wrong. The place you've put it will end up skipping userpref files saved with current trunk (2.69.3)
You also need to specify the keyframe border colours for the NLA editor, where the keyframe drawing code is used for drawing the keyframe indicators in the "tweaking track"

Ok, I've tested your patch. I've found 2 bugs which need to be fixed: 1) The version patch for old theme files is wrong. The place you've put it will end up skipping userpref files saved with current trunk (2.69.3) 2) You also need to specify the keyframe border colours for the NLA editor, where the keyframe drawing code is used for drawing the keyframe indicators in the "tweaking track"

Jose Molina Garcia commented

2013-11-27 11:07:32 +01:00

Hi,

One small question, in the NLA editor the keys never will be printed as selected, isn't it?

It's to include the border color selected or not. I think it's not necessary

Hi, One small question, in the NLA editor the keys never will be printed as selected, isn't it? It's to include the border color selected or not. I think it's not necessary

Joshua Leung commented

2013-12-05 06:45:10 +01:00

Hi,

I just got back from vacation in Hong Kong :)

In the NLA Editor, only the plain border colour will be used/needed. Selection status and fill colours are not drawn.

Hi, I just got back from vacation in Hong Kong :) In the NLA Editor, only the plain border colour will be used/needed. Selection status and fill colours are not drawn.

Joshua Leung commented

2014-01-17 03:09:28 +01:00

Changed status from 'Open' to: 'Resolved'

Joshua Leung closed this issue

2014-01-17 03:09:28 +01:00

Joshua Leung commented

2014-01-17 03:09:28 +01:00

Hi,

I've gone ahead and committed your patch to Git, along with a followup patch for a few more issues I hadn't noticed before.

Congratulations and thanks for your hard work :)

Hi, I've gone ahead and committed your patch to Git, along with a followup patch for a few more issues I hadn't noticed before. Congratulations and thanks for your hard work :)

Erick Tukuniata commented

2014-01-17 22:21:52 +01:00

Added subscriber: @ErickNyanduKabongo

Erick Tukuniata commented

2014-01-17 22:21:52 +01:00

Thanks for this commit :)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Customize keytype Color #37579

The RNA names for these settings aren't good ("KeyType" is too obscure jargon).

The same goes for the tooltips; drop the "KeyType" prefixes and adjust these to match the property names