Scroll bar in text-editor shows the wrong mouse cursor #37867

New Issue

Alexander N. · 2013-12-19T11:08:56+01:00

Alexander N. commented

2013-12-19 11:08:56 +01:00

in text-editor when you got with the mouse cursor to the scroll-bar on the right side, the mouse-cursor does not change to the arrow-cursor as expected form normal behavior of scroll-bars outside of blender application.

open blender
change view to text-editor
create a new text
hover with the mouse-cursor above the scroll-bar on the right-side

the mouse-cursor stays with the cursor for text input, but usually is should be an arrow cursor

issue_-_scroll_bar.blend

in text-editor when you got with the mouse cursor to the scroll-bar on the right side, the mouse-cursor does not change to the arrow-cursor as expected form normal behavior of scroll-bars outside of blender application. 1. open blender 2. change view to text-editor 3. create a new text 4. hover with the mouse-cursor above the scroll-bar on the right-side - >> the mouse-cursor stays with the cursor for text input, but usually is should be an arrow cursor ![issue_-_scroll_bar_-_current.PNG](https://archive.blender.org/developer/F46505/issue_-_scroll_bar_-_current.PNG) ![issue_-_scroll_bar_-_wanted.PNG](https://archive.blender.org/developer/F46508/issue_-_scroll_bar_-_wanted.PNG) [issue_-_scroll_bar.blend](https://archive.blender.org/developer/F46510/issue_-_scroll_bar.blend)

Alexander N. commented

2013-12-19 11:08:56 +01:00

Changed status to: 'Open'

Alexander N. commented

2013-12-19 11:08:56 +01:00

Added subscriber: @beta-tester

Brecht Van Lommel changed title from ~~scroll bar in text-editor shows the wrong mouse cursor~~ to Scroll bar in text-editor shows the wrong mouse cursor

2013-12-19 16:56:12 +01:00

Brecht Van Lommel commented

2013-12-19 16:56:50 +01:00

Added subscriber: @brecht

Brecht Van Lommel commented

2013-12-19 16:56:50 +01:00

I'm making this a To Do task, would be nice if it worked better but would not consider it a bug.

NikoLeopold self-assigned this 2014-02-08 16:50:57 +01:00

NikoLeopold commented

2014-02-08 16:50:57 +01:00

i would like to claim this as a very first task to dip into the blender code and get a bit of an idea of the patching process. if you are in need for this to be assigned to someone more competent, please take it! :)

Harshit Mehta commented

2014-02-16 10:00:21 +01:00

Added subscriber: @Harshit-3

NikoLeopold commented

2014-02-21 19:45:23 +01:00

got back to try my luck on this task today.
so far found out how to change mouse cursor icon. the following function calls seem of relevance:

WM_cursor_set(CTX_wm_window(C), SYSCURSOR);
WM_cursor_set(CTX_wm_window(C), BC_TEXTEDITCURSOR);

(where C is a pointer to bContext struct)
unfortunately since this is my first venture into the huge code base i am quite lost about where to put those calls...
in text_ops.c i found text_scroll_bar_invoke() and putting it there makes it possible to change the cursor when the scrollbar is clicked, but nothing about when the mouse is hovering over it.

got back to try my luck on this task today. so far found out how to change mouse cursor icon. the following function calls seem of relevance: ``` WM_cursor_set(CTX_wm_window(C), SYSCURSOR); WM_cursor_set(CTX_wm_window(C), BC_TEXTEDITCURSOR); ``` (where C is a pointer to bContext struct) unfortunately since this is my first venture into the huge code base i am quite lost about where to put those calls... in `text_ops.c` i found `text_scroll_bar_invoke()` and putting it there makes it possible to change the cursor when the scrollbar is clicked, but nothing about when the mouse is hovering over it.

NikoLeopold removed their assignment 2014-02-21 19:54:04 +01:00

NikoLeopold commented

2014-02-21 19:54:04 +01:00

Added subscriber: @NikoLeopold

NikoLeopold commented

2014-02-21 19:54:04 +01:00

i guess this would be easy for someone more experienced and since i don't want to destroy the code factorization through my limited knowledge i place this up for grabs again...
i would really love to know how this would be done however :)

i guess this would be easy for someone more experienced and since i don't want to destroy the code factorization through my limited knowledge i place this up for grabs again... i would really love to know how this would be done however :)

Harshit Mehta commented

2014-02-21 19:58:14 +01:00

I am also new to blender source code. I have spent some time working on this problem i.e studying various data structures used and event handles. I would like to grab it.

NikoLeopold commented

2014-02-21 19:59:56 +01:00

sure that would be great :)
id love to see how this should be done...

sure that would be great :) id love to see how this should be done...

chipgw commented

2014-03-03 05:06:54 +01:00

(Migrated from localhost:3001)

Added subscriber: @chipgw

chipgw commented

2014-03-03 05:06:54 +01:00

(Migrated from localhost:3001)

this seems to work, but now the normal text input cursor flickers a little bit when moving the cursor around...

text_editor_scroll_cursor.patch

(BTW I'm new here, so this could very well NOT be the way it should be done.)

this seems to work, but now the normal text input cursor flickers a little bit when moving the cursor around... [text_editor_scroll_cursor.patch](https://archive.blender.org/developer/F79755/text_editor_scroll_cursor.patch) (BTW I'm new here, so this could very well NOT be the way it should be done.)

Brecht Van Lommel commented

2014-03-03 16:53:44 +01:00

The method seems ok, two comments:

The check for sa->spacetype == SPACE_TEXT is not needed, this callback will only be called for the text space.
Why not use win->eventstate->y - ar->winrct.ymin for the Y coordinates? Not strictly needed but might as well not make any assumptions about the positioning of the scrollbar.

For the flickering, I didn't see that here on OS X, I'm not sure how that would happen. You could check if it is actually it is actually setting a different value in text_cursor when it flickers, or if it's some other place calling WM_cursor_set that causes it, or if somehow calling WM_cursor_set with the same value multiple times causes the flicker.

The method seems ok, two comments: * The check for `sa->spacetype == SPACE_TEXT` is not needed, this callback will only be called for the text space. * Why not use `win->eventstate->y - ar->winrct.ymin` for the Y coordinates? Not strictly needed but might as well not make any assumptions about the positioning of the scrollbar. For the flickering, I didn't see that here on OS X, I'm not sure how that would happen. You could check if it is actually it is actually setting a different value in text_cursor when it flickers, or if it's some other place calling WM_cursor_set that causes it, or if somehow calling WM_cursor_set with the same value multiple times causes the flicker.

NikoLeopold commented

2014-03-03 22:37:26 +01:00

the patch works nice for me! no flickering here either (also OS X).
interestingly enough, the second thing brecht suggested doesn't seem to work for me, don't really see why...

the patch works nice for me! no flickering here either (also OS X). interestingly enough, the second thing brecht suggested doesn't seem to work for me, don't really see why...

chipgw commented

2014-03-03 22:44:25 +01:00

(Migrated from localhost:3001)

apparently the y part of st->txtscroll is something else, st->txtbar is the actual scrollbar rectangle.

text_editor_scrollbar_cursor.patch

this still has the slight flickering on ArchLinux KDE. it isn't a steady flicker, just every second or so it blips to the standard cursor and back, probably just for one frame.

EDIT: wait, now it bugs when there is no file open and therefore the scrollbar isn't visible.

EDIT2: checking st->text fixes that. (st->txtbar isn't set if st->text is null)

text_editor_scrollbar_cursor.patch

apparently the y part of st->txtscroll is something else, st->txtbar is the actual scrollbar rectangle. [text_editor_scrollbar_cursor.patch](https://archive.blender.org/developer/F79838/text_editor_scrollbar_cursor.patch) this still has the slight flickering on ArchLinux KDE. it isn't a steady flicker, just every second or so it blips to the standard cursor and back, probably just for one frame. EDIT: wait, now it bugs when there is no file open and therefore the scrollbar isn't visible. EDIT2: checking st->text fixes that. (st->txtbar isn't set if st->text is null) [text_editor_scrollbar_cursor.patch](https://archive.blender.org/developer/F79842/text_editor_scrollbar_cursor.patch)

chipgw commented

2014-03-04 01:07:17 +01:00

(Migrated from localhost:3001)

as far as I can tell the flicker problem is from

GHOST_WindowX11::setWindowCustomCursorShape()

redefining the cursor every time it's called.
so sometimes the time between XFreeCursor and XDefineCursor/XFlush is long enough that the standard cursor is briefly visible. does this sound right?

as far as I can tell the flicker problem is from ``` GHOST_WindowX11::setWindowCustomCursorShape() ``` redefining the cursor every time it's called. so sometimes the time between XFreeCursor and XDefineCursor/XFlush is long enough that the standard cursor is briefly visible. does this sound right?

Brecht Van Lommel commented

2014-03-04 03:22:25 +01:00

That seems like a good hypothesis, perhaps the flicker can be avoided by delaying the XFreeCursor call like this: x11_custom_cursor_flicker.diff

We can also detect if the cursor shape actually changes before changing it in GHOST, but it really shouldn't be flickering to begin with.

That seems like a good hypothesis, perhaps the flicker can be avoided by delaying the `XFreeCursor` call like this: [x11_custom_cursor_flicker.diff](https://archive.blender.org/developer/F79862/x11_custom_cursor_flicker.diff) We can also detect if the cursor shape actually changes before changing it in GHOST, but it really shouldn't be flickering to begin with.

chipgw commented

2014-03-04 03:56:06 +01:00

(Migrated from localhost:3001)

Hm, I thought that would do it but apparently not. it even still happens if I comment out XFreeCursor completely. but it is only for custom cursors. with a different system one it's fine. (also if I set any of the node editor resize cursors to a custom cursor it flickers there as well)

EDIT: it happens if I build with WITH_GHOST_SDL as well.

Hm, I thought that would do it but apparently not. it even still happens if I comment out `XFreeCursor` completely. but it *is* only for custom cursors. with a different system one it's fine. (also if I set any of the node editor resize cursors to a custom cursor it flickers there as well) EDIT: it happens if I build with WITH_GHOST_SDL as well.

chipgw commented

2014-03-04 05:13:04 +01:00

(Migrated from localhost:3001)

this almost works, but it doesn't change when switching screen layouts. text_editor_scrollbar_cursor.patch

this almost works, but it doesn't change when switching screen layouts. [text_editor_scrollbar_cursor.patch](https://archive.blender.org/developer/F79866/text_editor_scrollbar_cursor.patch)

chipgw commented

2014-03-06 03:23:33 +01:00

(Migrated from localhost:3001)

so is passing swin_changed from region_cursor_set a problem at all? this works without any issues as far as I can tell. text_editor_scrollbar_cursor.patch (I don't think the X11 flicker bug itself will be fixed short of only defining the cursor once at startup and reusing it)

so is passing `swin_changed` from `region_cursor_set` a problem at all? this works without any issues as far as I can tell. [text_editor_scrollbar_cursor.patch](https://archive.blender.org/developer/F80065/text_editor_scrollbar_cursor.patch) (I don't think the X11 flicker bug itself will be fixed short of only defining the cursor once at startup and reusing it)

blender-admin commented

2014-03-06 18:23:21 +01:00

This issue was referenced by blender/blender-addons-contrib@19e74f1d4f

This issue was referenced by blender/blender-addons-contrib@19e74f1d4f9bc955c6c7616cadcde65e6f6d2d3d

blender-admin commented

2014-03-06 18:23:21 +01:00

This issue was referenced by 19e74f1d4f

This issue was referenced by 19e74f1d4f9bc955c6c7616cadcde65e6f6d2d3d

Brecht Van Lommel commented

2014-03-06 18:25:34 +01:00

Changed status from 'Open' to: 'Resolved'

Brecht Van Lommel closed this issue

2014-03-06 18:25:34 +01:00

Brecht Van Lommel commented

2014-03-06 18:25:34 +01:00

Closed by commit 19e74f1d4f.

Closed by commit 19e74f1d4f.

Brecht Van Lommel commented

2014-03-06 18:26:20 +01:00

I committed a fix for the X11 mouse cursor problem, the problem was in the function that sets the cursor visibility (see f04fd50073).

Committed the earlier patch now, thanks!

I committed a fix for the X11 mouse cursor problem, the problem was in the function that sets the cursor visibility (see f04fd500731). Committed the earlier patch now, thanks!

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Scroll bar in text-editor shows the wrong mouse cursor #37867