Incorrect calls to DNA_find_struct_nr #38290

New Issue

Lawrence D'Oliveiro · 2014-01-20T02:08:07+01:00

2014-01-20 02:08:07 +01:00

In the process of adding SCons support to #37228, I came across a couple of incorrect checks for the result from ##DNA_find_struct_nr##, in ##source/blender/makesrna/intern/rna_define.c##. The code was treating a result of 0 as failure and nonzero as success, when in fact a successful return is any non-negative integer, with -1 representing failure. This may have worked fine before, but it was triggering build failures for me.

Fixing the code to check the right result still resulted in build failures. This suggests to me that the calls are not even necessary. Commenting one of them out allowed my build to succeed.

The enclosed patch rna_define.patch changes the two problem calls, and comments out the one that still remains troublesome afterwards.

In the process of adding SCons support to #37228, I came across a couple of incorrect checks for the result from ##DNA_find_struct_nr##, in ##source/blender/makesrna/intern/rna_define.c##. The code was treating a result of 0 as failure and nonzero as success, when in fact a successful return is any non-negative integer, with -1 representing failure. This may have worked fine before, but it was triggering build failures for me. Fixing the code to check the right result still resulted in build failures. This suggests to me that the calls are not even necessary. Commenting one of them out allowed my build to succeed. The enclosed patch [rna_define.patch](https://archive.blender.org/developer/F70775/rna_define.patch) changes the two problem calls, and comments out the one that still remains troublesome afterwards.

Lawrence D'Oliveiro commented

2014-01-20 02:08:07 +01:00

Changed status to: 'Open'

Lawrence D'Oliveiro commented

2014-01-20 02:08:07 +01:00

Added subscriber: @ldo

Campbell Barton self-assigned this 2014-01-20 03:19:34 +01:00

Campbell Barton commented

2014-01-20 03:19:34 +01:00

Checking on this, I think the check in RNA_def_struct_sdna can be used, it just needs to check DefRNA.verify first. will try modify the patch so the check can be kept.

Campbell Barton commented

2014-01-20 04:16:50 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2014-01-20 04:16:50 +01:00

Campbell Barton commented

2014-01-20 04:16:50 +01:00

Good find, committed ece504aff8

Note, I looked into optionally enabling this check but turns out to be a bit of a mess and would mean adding new arguments or begin/end verification calls all over.

Good find, committed ece504aff8 Note, I looked into optionally enabling this check but turns out to be a bit of a mess and would mean adding new arguments or begin/end verification calls all over.

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#38290

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Incorrect calls to DNA_find_struct_nr #38290