Page MenuHome

Double click list renaming not working on heavy scenes
Confirmed, NormalPublicKNOWN ISSUE

Description

Vista64, 2.7a, gtx470
When the scene is heavy, so that interface becomes slightly laggy, double click list rename stops working, especially for fast clicking.

  • Add subdivision modifiers to any mesh until interface becomes laggy.
  • Add a vertex group or UV map.
  • Double click to rename - renaming is not activated.

Event Timeline

Bastien Montagne (mont29) lowered the priority of this task from 90 to 50.May 3 2014, 3:03 PM

@Konstantins Visnevskis (kivig): you can ctrl-click (or ctrl-enter), works fine.

Dev note: looks like in this case, a 'single click' event is processed before a double-one gets generated, which turns to selecting the listrow instead of editing the label (i.e. ui_do_but_LISTROW() never gets the KM_DBL_CLICK event, unless you triple-click, which will then select the item and then edit its label).

Not quite sure we consider this a bug, or a todo of our event system?

@Bastien Montagne (mont29), ideally none of the RNA update should do heavy operations (look into shape key update function, i.e.). But that's also kind of separate issue because you'll need to tag update here anyway which would make first click tagging the object, then object update happens and only them second click is handled which doesn't really help.

What we can do instead is to not activate row if we're single-clicking an active one. Here's a real dirty hack for this http://www.pasteall.org/51656/diff Maybe you'll have ideas how to clean it up a bit.

Bastien Montagne (mont29) changed the task status from Unknown Status to Unknown Status.May 20 2014, 7:13 PM

This is in fact an “issue” with current event system, you just can’t avoid getting a click first before getting a doubleclick event… More a TODO/internal limitation than a bug, so closing as such (see also our TODO list).

Philipp Oeser (lichtwerk) reopened this task as Confirmed.May 19 2021, 1:00 PM
Philipp Oeser (lichtwerk) changed the subtype of this task from "Report" to "Known Issue".

Since the TODO list is dead, the issue is still there (has been reported again), will set to Known Issue to have something as reference.

This is a task for a developer to fix, not a UI design issue I think.

Changing the vertex group name should update the dependency graph, because bones and vertex groups are linked by name. I think the problem is that the first click is for changing the active vertex group, which can affect the viewport in weight paint mode for example.

There are a few things that could be improved here:

  1. If a vertex group is already active, then clicking it again should not cause any depsgraph update. (probably simple)
  2. Ideally changing the active vertex group would have more fine-grained tagging so it doesn't affect anything when it doesn't affect any viewport. (may be simple if it's a matter of checking if the object is in weight paint mode in the RNA update function, would need to be checked)
  3. Events coming from GHOST should ideally have a timestamp, and that timestamp should be used to determine the double clicking time. (too much work to handle as a bug report)

The issue is that on double click two different things are done:

  • On the first click, it makes the item active which require a dependency graph update.
  • On the second click, it starts renaming.

It's not the renaming that's the problem, but the making active that happens right before that.