Boolean modifier with Freestyle edges #40315

New Issue

Fazekas Laszlo · 2014-05-22T17:26:18+02:00

Fazekas Laszlo commented

2014-05-22 17:26:18 +02:00

System Information
Ubuntu 14.04 64bit NVidia 440

Blender Version
Broken: 2.70 c56bbcc
Worked: (optional)

Short description of error
Boolean modifier keeps only the Freestyle edges of the original mesh (not like the Sharp/Seam edges, they are merged with the masking mesh). If you apply the modifier, all Freestyle edge attributes are lost.

Exact steps for others to reproduce the error
Create two mesh objects. Set boolean modifier for one of them using the other. Set some Freestyle edges for both of them in Edit mode. Disable the masking layer for rendering so you can see only the modifier's output. Render it with Freestyle enabled. You can see only the original mesh's Freestyle edges are there. Apply the modifier. Render again. No Freestyle edges at all.
bool_edge_mark.blend

**System Information** Ubuntu 14.04 64bit NVidia 440 **Blender Version** Broken: 2.70 c56bbcc Worked: (optional) **Short description of error** Boolean modifier keeps only the Freestyle edges of the original mesh (not like the Sharp/Seam edges, they are merged with the masking mesh). If you apply the modifier, all Freestyle edge attributes are lost. **Exact steps for others to reproduce the error** Create two mesh objects. Set boolean modifier for one of them using the other. Set some Freestyle edges for both of them in Edit mode. Disable the masking layer for rendering so you can see only the modifier's output. Render it with Freestyle enabled. You can see only the original mesh's Freestyle edges are there. Apply the modifier. Render again. No Freestyle edges at all. [bool_edge_mark.blend](https://archive.blender.org/developer/F89714/bool_edge_mark.blend)

Fazekas Laszlo commented

2014-05-22 17:26:18 +02:00

Changed status to: 'Open'

Fazekas Laszlo commented

2014-05-22 17:26:18 +02:00

Added subscriber: @totoro-4

Sergey Sharybin self-assigned this 2014-05-22 18:29:57 +02:00

Tamito Kajiyama commented

2014-05-26 07:39:56 +02:00

Added subscriber: @kjym3

Tamito Kajiyama commented

2014-05-26 07:39:56 +02:00

Just FYI, Campbell recently addressed a similar problem with the subsurf modifier in the commit 3182c54da6.

Just FYI, Campbell recently addressed a similar problem with the subsurf modifier in the commit 3182c54da6.

Fazekas Laszlo commented

2014-05-26 11:07:29 +02:00

The exporter_SetEdge() in MOD_boolean_util.c copies the edge customdata. It seems for me (but not sure, I apologize for the things below if I'm wrong) that CARVE_MESH_LEFT means the original object and CARVE_MESH_RIGHT is the masking object. But I don't know what CustomData_copy_data() copies here. Maybe this supposed to copy the edge customdata from the CARVE_MESH_RIGHT object? Because the CARVE_MESH_LEFT object's data comes from somewhere else. If I comment out this copy instruction the freestyle edges are still there (before applying of course).

I think 'orig_edge_index' has a meaning only together with 'which_orig_mesh' here.

But even this copied data won't be in the final result if the applyModifier() gets the MOD_APPLY_USECACHE flag in MOD_boolean.c.

The exporter_SetEdge() in MOD_boolean_util.c copies the edge customdata. It seems for me (but not sure, I apologize for the things below if I'm wrong) that CARVE_MESH_LEFT means the original object and CARVE_MESH_RIGHT is the masking object. But I don't know what CustomData_copy_data() copies here. Maybe this supposed to copy the edge customdata from the CARVE_MESH_RIGHT object? Because the CARVE_MESH_LEFT object's data comes from somewhere else. If I comment out this copy instruction the freestyle edges are still there (before applying of course). I think 'orig_edge_index' has a meaning only together with 'which_orig_mesh' here. But even this copied data won't be in the final result if the applyModifier() gets the MOD_APPLY_USECACHE flag in MOD_boolean.c.

blender-admin commented

2014-05-26 12:45:43 +02:00

This issue was referenced by 3b4f792ce1

This issue was referenced by 3b4f792ce102f5c892e4108c19512dd3b9968335

Sergey Sharybin commented

2014-05-26 12:47:32 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2014-05-26 12:47:32 +02:00

Sergey Sharybin commented

2014-05-26 12:47:32 +02:00

Closed by commit 3b4f792ce1.

Closed by commit 3b4f792ce1.

Fazekas Laszlo commented

2014-05-26 14:34:44 +02:00

Added subscriber: @Sergey

Fazekas Laszlo commented

2014-05-26 14:34:44 +02:00

@Sergey thank you! But something still missing. Now the edges are there from both objects AFTER applying the modifier, but through the modifier the edges from the masking object are still missing. Render my original example scene before and after apply to see the difference.

Fazekas Laszlo commented

2014-05-26 21:51:31 +02:00

I don't know if it helps, but I've made some debugging with this MOD_boolean_util.c. The output DerivedMesh always contains the good freestyle edge customdata layer, but later (I don't know where) something overwrites this information. This happening after the modifier, and it rebuilds the freestyle edge layer (and perhaps others too) using the contents of the CD_ORIGINDEX layer as an index to the original mesh's edges. The exporter_SetEdge() function fills the contents of this index layer but it refers only to the original mesh (left) and not to the masking mesh (right).

Tamito Kajiyama commented

2014-05-27 03:27:50 +02:00

Changed status from 'Resolved' to: 'Open'

Tamito Kajiyama reopened this issue

2014-05-27 03:27:50 +02:00

Tamito Kajiyama commented

2014-05-27 03:27:50 +02:00

Hi @Sergey,
Thank to the commit, now applying the modifier gives a correct boolean result with all Freestyle edge marks kept. Still only edge marks of the modified object (left object) are kept when rendering without applying the modifier, and those edge marks from the modifier parameter object (right object) are lost.

Hi @Sergey, Thank to the commit, now applying the modifier gives a correct boolean result with all Freestyle edge marks kept. Still only edge marks of the modified object (left object) are kept when rendering without applying the modifier, and those edge marks from the modifier parameter object (right object) are lost.

Fazekas Laszlo commented

2014-05-27 06:51:13 +02:00

I think this is a design bug in the modifier system. The 3182c54da6 bug was the same thing. Now the modifiers must serve two different workflows at once. For applying it creates the customdata by itself, but without applying it passes a list about the edges mapping (and perhaps faces etc.). I think the modifier knows better what is what, so this postprocessing is not a good idea. It restricts design of future modifiers too. Was this originally a speedup to not copy all the data during the modifier chain but only reference?

I think this is a design bug in the modifier system. The 3182c54da6 bug was the same thing. Now the modifiers must serve two different workflows at once. For applying it creates the customdata by itself, but without applying it passes a list about the edges mapping (and perhaps faces etc.). I think the modifier knows better what is what, so this postprocessing is not a good idea. It restricts design of future modifiers too. Was this originally a speedup to not copy all the data during the modifier chain but only reference?

Sergey Sharybin commented

2014-05-27 16:21:56 +02:00

@kjym3, afraid that's up to you, not me ;)

Seems that the issue is inside make_freestyle_edge_mark_hash() which for some reason uses CD layer from original mesh, not DM. Hence it'll fail to get flags for edges which doesn't ORIGINDEX.

Here's a patch which makes it so flags from DM are used, but not sure maybe it was a reason to use flags from the base mesh (which i don't actually see): http://www.pasteall.org/51902/diff

@kjym3, afraid that's up to you, not me ;) Seems that the issue is inside `make_freestyle_edge_mark_hash()` which for some reason uses CD layer from original mesh, not DM. Hence it'll fail to get flags for edges which doesn't ORIGINDEX. Here's a patch which makes it so flags from DM are used, but not sure maybe it was a reason to use flags from the base mesh (which i don't actually see): http://www.pasteall.org/51902/diff

Fazekas Laszlo commented

2014-05-27 17:50:46 +02:00

I'm happy to hear it is not a general problem in Blender. Actually I didn't check the freestyle part... Thank you @Sergey!

Sergey Sharybin removed their assignment 2014-05-28 15:46:03 +02:00

Tamito Kajiyama was assigned by Sergey Sharybin

2014-05-28 15:46:03 +02:00

Tamito Kajiyama commented

2014-05-28 16:56:35 +02:00

Thank you Sergey for the fix for make_freestyle_edge_mark_hash(). I found a related issue that edge marks from the parameter object of the boolean modifier were still missing when the object has modifiers in its own modifier stack. Please, consider a code review of D558 which includes fixes of the two issues.

Thank you Sergey for the fix for make_freestyle_edge_mark_hash(). I found a related issue that edge marks from the parameter object of the boolean modifier were still missing when the object has modifiers in its own modifier stack. Please, consider a code review of [D558](https://archive.blender.org/developer/D558) which includes fixes of the two issues.

Fazekas Laszlo commented

2014-05-28 17:17:52 +02:00

Hello @kjym3, thank you! I hope this finishes this bug. I cannot try it yet, the code review is not in the git. As a notice, I see a very similar part in convertblender.c at lines 3327 and 3366 for the CD_FREESTYLE_FACE marks, using the CD_ORIGINDEX again. Maybe it also needs a correction?

Tamito Kajiyama commented

2014-05-28 17:20:58 +02:00

Yes, the CD_FREESTYLE_FACE stuff also requires a code revision. Patch D558 focuses on edge marks. I will address the face marks issue separately.

Yes, the CD_FREESTYLE_FACE stuff also requires a code revision. Patch [D558](https://archive.blender.org/developer/D558) focuses on edge marks. I will address the face marks issue separately.

blender-admin commented

2014-06-01 09:24:18 +02:00

This issue was referenced by edfd989e86

This issue was referenced by edfd989e864f2c87d2bbceef1acf88bbb46db497

Tamito Kajiyama commented

2014-06-01 09:34:58 +02:00

Changed status from 'Open' to: 'Resolved'

Tamito Kajiyama closed this issue

2014-06-01 09:34:58 +02:00

Tamito Kajiyama commented

2014-06-01 09:34:58 +02:00

Closed by commit edfd989e86.

Closed by commit edfd989e86.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Boolean modifier with Freestyle edges #40315