Missing refresh on Undo for nodes (mask example) #41818

New Issue

Alexey · 2014-09-13T23:06:45+02:00

Alexey commented

2014-09-13 23:06:45 +02:00

*System Information
windows7 64
ASUS ATI Radeon HD6870

Blender Version
Broken: (All)
Worked: (None)

Short description of error

Exact steps for others to reproduce the error
open this
mask_undo.blend
press F12 to receive rendered result with compositing
try to change anything in this mask and press ctrl+Z to undo - we will see don't update.

*System Information windows7 64 ASUS ATI Radeon HD6870 Blender Version Broken: (All) Worked: (None) **Short description of error** ![1.png](https://archive.blender.org/developer/F110196/1.png) ![2.png](https://archive.blender.org/developer/F110198/2.png) ![3.png](https://archive.blender.org/developer/F110200/3.png) ![4.png](https://archive.blender.org/developer/F110202/4.png) **Exact steps for others to reproduce the error** open this [mask_undo.blend](https://archive.blender.org/developer/F110204/mask_undo.blend) press F12 to receive rendered result with compositing try to change anything in this mask and press ctrl+Z to undo - we will see don't update.

Alexey commented

2014-09-13 23:06:45 +02:00

Changed status to: 'Open'

Alexey self-assigned this 2014-09-13 23:06:45 +02:00

Alexey commented

2014-09-13 23:06:45 +02:00

Added subscriber: @Inwader77

Bastien Montagne changed title from ~~mask undo error~~ to Missing refresh on Undo for nodes (mask example)

2014-09-14 00:03:48 +02:00

Alexey was unassigned by Bastien Montagne

2014-09-14 00:03:48 +02:00

Bastien Montagne commented

2014-09-14 00:03:48 +02:00

Added subscribers: @Sergey, @LukasTonne

Bastien Montagne commented

2014-09-14 00:10:07 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-09-14 00:10:07 +02:00

In fact, this affect any undo in nodes (at least for compo, but suspect others as well).

Undo just triggers (in usual cases) a generic NC_WINDOW message - which is unknown from Node space listener. This may also affect other spaces, btw, like clip editor?

Anyway, this seems to be some kind of 'brute force' approach, so I guess we’d just have to handle that message in nodes and trigger refresh for it? Quick test shows it works, but quite unsure whether we have more subtle ways to handle the issue?

In fact, this affect any undo in nodes (at least for compo, but suspect others as well). Undo just triggers (in usual cases) a generic `NC_WINDOW` message - which is unknown from Node space listener. This may also affect other spaces, btw, like clip editor? Anyway, this seems to be some kind of 'brute force' approach, so I guess we’d just have to handle that message in nodes and trigger refresh for it? Quick test shows it works, but quite unsure whether we have more subtle ways to handle the issue?

Alexey commented

2014-09-14 01:46:24 +02:00

![node.png](https://archive.blender.org/developer/F110231/node.png)

Sergey Sharybin was assigned by Bastien Montagne

2014-09-15 14:05:25 +02:00

blender-admin commented

2014-09-16 10:44:47 +02:00

This issue was referenced by 1e948b251d

This issue was referenced by 1e948b251d63cb9141ff71d24fbcf343d38c7da4

Sergey Sharybin commented

2014-09-16 10:45:49 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2014-09-16 10:45:49 +02:00

Sergey Sharybin commented

2014-09-16 10:45:49 +02:00

Closed by commit 1e948b251d.

Closed by commit 1e948b251d.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Missing refresh on Undo for nodes (mask example) #41818