AFTER 2.73 - startup.blend: updates for proper re-ordering of newly added Freestyle panels #42032

New Issue

Tamito Kajiyama · 2014-10-01T08:08:18+02:00

Tamito Kajiyama commented

2014-10-01 08:08:18 +02:00

For the 2.72 final release, please consider updating the factory settings (startup.blend) to properly arrange newly added Freestyle panels in the properties window as requested by Thomas in a review comment of patch D632 for Freestyle in Cycles. Specifically,

In the Render tab, the "Freestyle" tab should be beneath the "Post Processing" tab.
In the Render Layers tab, the three Freestyle panels (showing up when Freestyle is turned on) should be beneath the "Layer" and "Passes" tabs.
In the Material tab, "Freestyle Line" should be put beneath all other ones.

I would appreciate it if more and less the same ordering of tabs is maintained for all rendering engines, since the tab arrangement may vary in each of them.

For the 2.72 final release, please consider updating the factory settings (`startup.blend`) to properly arrange newly added Freestyle panels in the properties window as [requested by Thomas in a review comment ](https://developer.blender.org/D632#8928) of patch [D632](https://archive.blender.org/developer/D632) for Freestyle in Cycles. Specifically, * In the Render tab, the "Freestyle" tab should be beneath the "Post Processing" tab. * In the Render Layers tab, the three Freestyle panels (showing up when Freestyle is turned on) should be beneath the "Layer" and "Passes" tabs. * In the Material tab, "Freestyle Line" should be put beneath all other ones. I would appreciate it if more and less the same ordering of tabs is maintained for all rendering engines, since the tab arrangement may vary in each of them.

Tamito Kajiyama commented

2014-10-01 08:08:18 +02:00

Changed status to: 'Open'

Tamito Kajiyama commented

2014-10-01 08:08:18 +02:00

Added subscriber: @kjym3

Lukas Tönne commented

2014-10-08 10:46:04 +02:00

Added subscriber: @LukasTonne

Lukas Tönne commented

2014-10-08 10:46:04 +02:00

Don't see the problem here - i get the desired panel placement both in my current startup.blend and when using factory defaults.

Tamito Kajiyama commented

2014-10-08 16:32:46 +02:00

Added subscribers: @ThomasDinges, @ideasman42

Tamito Kajiyama commented

2014-10-08 16:32:46 +02:00

Well, at least in the Windows 64-bit build of the 2.72 release, the Freestyle tabs in the properties window are not placed as requested in this task, when the factory settings are used and the rendering engine is set to Cycles. I guess I should have assigned the task to @ThomasDinges or @ideasman42 for sure to get it addressed before the release...

Thomas Dinges was assigned by Lukas Tönne

2014-10-08 17:52:17 +02:00

Lukas Tönne commented

2014-10-08 17:52:17 +02:00

@ThomasDinges Could you check this?

Bastien Montagne commented

2014-10-10 16:23:40 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2014-10-10 16:23:40 +02:00

I do can confirm the "issue" with Cycles engine, but not sure we consider this a bug? Thing is, Cycles being an addon, it's UI is loaded after 'main' UI, can't do much about it… You can even see, in Material buttons e.g., that the 'Custom Data' panel, which is supposed to be the last one, is in first position :/

Imho until we have a real way to define panels' positions in our UI code, this remains a known TODO?

I do can confirm the "issue" with Cycles engine, but not sure we consider this a bug? Thing is, Cycles being an addon, it's UI is loaded after 'main' UI, can't do much about it… You can even see, in Material buttons e.g., that the 'Custom Data' panel, which is supposed to be the last one, is in first position :/ Imho until we have a real way to **define** panels' positions in our UI code, this remains a known TODO?

Tamito Kajiyama commented

2014-10-13 02:35:57 +02:00

It would be ideal to have a systematic way to define the positions of panels, but this specific task was not meant to request such a solution. Instead I was proposing manual updates of startup.blend to refine panel positions for the 2.72 release. The addition of new panels does not happen so often, and fixes are necessary only for some of the panel positions that appears inappropriate. Manual fixes would be easier for the time being.

Thomas Dinges commented

2014-10-13 07:09:45 +02:00

@mont29: Yes I guess it's a todo, but one that has been pushed for quite too long. Having this Custom Data panel before Cycles panels is just one example of how bad the current solution is. :/

Campbell Barton changed title from ~~startup.blend updates for proper re-ordering of newly added Freestyle panels~~ to startup.blend: updates for proper re-ordering of newly added Freestyle panels

2014-11-10 17:38:11 +01:00

blender-admin commented

2014-12-04 11:04:15 +01:00

This issue was referenced by 54c0dcbf696f5342eaf46767c6ab995458f55602

Campbell Barton commented

2014-12-04 11:04:42 +01:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2014-12-04 11:04:42 +01:00

Campbell Barton commented

2014-12-04 11:04:42 +01:00

Closed by commit 54c0dcbf69.

Campbell Barton commented

2014-12-04 11:06:25 +01:00

Changed status from 'Resolved' to: 'Open'

Campbell Barton reopened this issue

2014-12-04 11:06:25 +01:00

Campbell Barton commented

2014-12-04 11:06:25 +01:00

Committed to temp branch, please check the startup.blend is OK, we can use in master if no issues are found.

Thomas Dinges commented

2014-12-04 21:29:14 +01:00

Doesn't work for me.

I switched to the branch (splash screen confirms it), and I made sure to load the factor default (File menu).
The Freestyle panel order is as before in Cycles. For BI, it's now on the bottom, the concern was specifically about Cycles though.

Doesn't work for me. I switched to the branch (splash screen confirms it), and I made sure to load the factor default (File menu). The Freestyle panel order is as before in Cycles. For BI, it's now on the bottom, the concern was specifically about Cycles though.

Thomas Dinges was unassigned by Julian Eisel

2014-12-05 00:14:17 +01:00

Julian Eisel self-assigned this 2014-12-05 00:14:17 +01:00

Julian Eisel removed their assignment 2014-12-05 00:14:46 +01:00

Thomas Dinges was assigned by Julian Eisel

2014-12-05 00:14:46 +01:00

Julian Eisel commented

2014-12-05 00:15:00 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2014-12-05 00:15:00 +01:00

Ehh, this shouldnt be a bug report!?

Campbell Barton commented

2014-12-05 16:53:55 +01:00

It turns out panels read from in-memory startup.blend git their positions reset,
3af9015139

https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/versioning_defaults.c$123

Options are:

Change definition order in code
Revert 3af9015139 and use panels from startup file.
Leave as-is

Edit, think its best to change this in the Python scripts class registration

It turns out panels read from in-memory startup.blend git their positions reset, 3af9015139 https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/versioning_defaults.c$123 Options are: - Change definition order in code - Revert 3af9015139 and use panels from startup file. - Leave as-is ---- Edit, think its best to change this in the Python scripts class registration

Julian Eisel commented

2014-12-14 14:59:06 +01:00

Also think it's better to change from python. It can be confusing to see that panels are ordered differently in the GUI as defined through the python scripts, especially for newer devs.
Better to do it always like this IMHO.

Also think it's better to change from python. It can be confusing to see that panels are ordered differently in the GUI as defined through the python scripts, especially for newer devs. Better to do it always like this IMHO.

Sergey Sharybin commented

2014-12-18 09:57:40 +01:00

Added subscriber: @Sergey

Sergey Sharybin commented

2014-12-18 09:57:40 +01:00

@ideasman42, is it something to be addressed for 2.73 still?

Campbell Barton commented

2014-12-18 10:14:56 +01:00

No, this is general since it requires code changes.

Issue is panel definition order.

No, this is general since it requires code changes. Issue is panel definition order.

Sergey Sharybin changed title from ~~startup.blend: updates for proper re-ordering of newly added Freestyle panels~~ to AFTER 2.73 - startup.blend: updates for proper re-ordering of newly added Freestyle panels

2014-12-18 10:15:56 +01:00

Campbell Barton commented

2015-06-08 08:42:42 +02:00

This seems to be fixed? Checked recent build, resetting factory settings.

Checked to fix this... and seems its fixed in master?

Can someone else check this?

This seems to be fixed? Checked recent build, resetting factory settings. Checked to fix this... and seems its fixed in master? Can someone else check this?

Tamito Kajiyama commented

2015-06-09 17:59:34 +02:00

When the rendering engine is set to Cycles,

in the Render properties window, the Freestyle panel comes between the Output and Sampling panels. The Freestyle panel is closed (folded) by default.
in the Render Layers properties window, the Freestyle, Freestyle Line Set, and Freestyle Line Style panels comes in this order on top of the Layer panel. Only the last panel is closed by default, and the other two are open.
in the Material properties window, the Freestyle Line panel comes between the Custom Properties and Preview panels. The Freestyle Line panel is closed by default.
So the positioning needs to be fixed (preferably as highlighted in the task description in the very beginning).

It is also remarked that Freestyle is an opt-in post-processing tool enabled by the user. For this reason, IMHO the Freestyle-related panels should be open/closed by default as follows:

in the Render properties window, the Freestyle panel should be closed (as it is now).
in the Render Layers properties window, all the 3 Freestyle-related panels should be open.
in the Material properties window, the Freestyle Line panel should be open.

When the rendering engine is set to Cycles, * in the Render properties window, the Freestyle panel comes between the Output and Sampling panels. The Freestyle panel is closed (folded) by default. * in the Render Layers properties window, the Freestyle, Freestyle Line Set, and Freestyle Line Style panels comes in this order on top of the Layer panel. Only the last panel is closed by default, and the other two are open. * in the Material properties window, the Freestyle Line panel comes between the Custom Properties and Preview panels. The Freestyle Line panel is closed by default. So the positioning needs to be fixed (preferably as highlighted in the task description in the very beginning). It is also remarked that Freestyle is an opt-in post-processing tool enabled by the user. For this reason, IMHO the Freestyle-related panels should be open/closed by default as follows: * in the Render properties window, the Freestyle panel should be closed (as it is now). * in the Render Layers properties window, all the 3 Freestyle-related panels should be open. * in the Material properties window, the Freestyle Line panel should be open.

Lukas Tönne commented

2015-06-09 18:20:36 +02:00

Removed subscriber: @LukasTonne

Julian Eisel commented

2020-08-03 14:29:58 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Julian Eisel closed this issue

2020-08-03 14:29:58 +02:00

Julian Eisel commented

2020-08-03 14:29:58 +02:00

For 2.8 the properties were reorganized. I think this task is addressed now and can be closed.
What's currently there isn't precisely what's proposed here but it's similar.

For 2.8 the properties were reorganized. I think this task is addressed now and can be closed. What's currently there isn't precisely what's proposed here but it's similar.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

AFTER 2.73 - startup.blend: updates for proper re-ordering of newly added Freestyle panels #42032