Page MenuHome
Maniphest T42032

AFTER 2.73 - startup.blend: updates for proper re-ordering of newly added Freestyle panels
Open, Confirmed, LowPublic
Actions

Description

For the 2.72 final release, please consider updating the factory settings (startup.blend) to properly arrange newly added Freestyle panels in the properties window as requested by Thomas in a review comment of patch D632 for Freestyle in Cycles. Specifically,

  • In the Render tab, the "Freestyle" tab should be beneath the "Post Processing" tab.
  • In the Render Layers tab, the three Freestyle panels (showing up when Freestyle is turned on) should be beneath the "Layer" and "Passes" tabs.
  • In the Material tab, "Freestyle Line" should be put beneath all other ones.

I would appreciate it if more and less the same ordering of tabs is maintained for all rendering engines, since the tab arrangement may vary in each of them.

Details

Commits
rB54c0dcbf696f: Fix T42032: Freestyle panel order
Type
To Do

Related Objects

Event Timeline

Tamito Kajiyama (kjym3) updated the task description. (Show Details)Oct 1 2014, 8:08 AM
Tamito Kajiyama (kjym3) added a project: BF Blender: Regressions.
Tamito Kajiyama (kjym3) set Type to Bug.
Tamito Kajiyama (kjym3) added a subscriber: Tamito Kajiyama (kjym3).
Tamito Kajiyama (kjym3) created this task.
Tamito Kajiyama (kjym3) raised the priority of this task from to Needs Triage by Developer.
Lukas Toenne (lukastoenne) added a project: BF Blender: Unconfirmed.EditedOct 8 2014, 10:46 AM
Lukas Toenne (lukastoenne) added a subscriber: Lukas Toenne (lukastoenne).

Don't see the problem here - i get the desired panel placement both in my current startup.blend and when using factory defaults.

Tamito Kajiyama (kjym3) added subscribers: Thomas Dinges (dingto), Campbell Barton (campbellbarton).Oct 8 2014, 4:32 PM

Well, at least in the Windows 64-bit build of the 2.72 release, the Freestyle tabs in the properties window are not placed as requested in this task, when the factory settings are used and the rendering engine is set to Cycles. I guess I should have assigned the task to @Thomas Dinges (dingto) or @Campbell Barton (campbellbarton) for sure to get it addressed before the release...

Bastien Montagne (mont29) edited projects, added User Interface; removed BF Blender: Regressions.Oct 10 2014, 4:19 PM
Bastien Montagne (mont29) triaged this task as Normal priority.
Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).Oct 10 2014, 4:23 PM

I do can confirm the "issue" with Cycles engine, but not sure we consider this a bug? Thing is, Cycles being an addon, it's UI is loaded after 'main' UI, can't do much about it… You can even see, in Material buttons e.g., that the 'Custom Data' panel, which is supposed to be the last one, is in first position :/

Imho until we have a real way to define panels' positions in our UI code, this remains a known TODO?

Tamito Kajiyama (kjym3) added a comment.Oct 13 2014, 2:35 AM

It would be ideal to have a systematic way to define the positions of panels, but this specific task was not meant to request such a solution. Instead I was proposing manual updates of startup.blend to refine panel positions for the 2.72 release. The addition of new panels does not happen so often, and fixes are necessary only for some of the panel positions that appears inappropriate. Manual fixes would be easier for the time being.

Thomas Dinges (dingto) added a comment.Oct 13 2014, 7:09 AM

@Bastien Montagne (mont29): Yes I guess it's a todo, but one that has been pushed for quite too long. Having this Custom Data panel before Cycles panels is just one example of how bad the current solution is. :/

Campbell Barton (campbellbarton) added a project: BF Blender: Next.Nov 10 2014, 5:38 PM
Campbell Barton (campbellbarton) renamed this task from startup.blend updates for proper re-ordering of newly added Freestyle panels to startup.blend: updates for proper re-ordering of newly added Freestyle panels.
Campbell Barton (campbellbarton) reopened this task as Open.Dec 4 2014, 11:06 AM

Committed to temp branch, please check the startup.blend is OK, we can use in master if no issues are found.

Thomas Dinges (dingto) added a comment.Dec 4 2014, 9:29 PM

Doesn't work for me.

I switched to the branch (splash screen confirms it), and I made sure to load the factor default (File menu).
The Freestyle panel order is as before in Cycles. For BI, it's now on the bottom, the concern was specifically about Cycles though.

Julian Eisel (Severin) changed Type from Bug to To Do.Dec 5 2014, 12:14 AM
Julian Eisel (Severin) added a subscriber: Julian Eisel (Severin).
Julian Eisel (Severin) claimed this task.
Julian Eisel (Severin) reassigned this task from Julian Eisel (Severin) to Thomas Dinges (dingto).

Ehh, this shouldnt be a bug report!?

Campbell Barton (campbellbarton) added a comment.EditedDec 5 2014, 4:53 PM

It turns out panels read from in-memory startup.blend git their positions reset,
rB3af90151399fb0ce011c42a531cf3ca8eb437e6a

https://developer.blender.org/diffusion/B/browse/master/source/blender/blenloader/intern/versioning_defaults.c$123

Options are:

Edit, think its best to change this in the Python scripts class registration

Julian Eisel (Severin) added a comment.Dec 14 2014, 2:59 PM

Also think it's better to change from python. It can be confusing to see that panels are ordered differently in the GUI as defined through the python scripts, especially for newer devs.
Better to do it always like this IMHO.

Campbell Barton (campbellbarton) added a comment.Dec 18 2014, 10:14 AM

No, this is general since it requires code changes.

Issue is panel definition order.

Sergey Sharybin (sergey) renamed this task from startup.blend: updates for proper re-ordering of newly added Freestyle panels to AFTER 2.73 - startup.blend: updates for proper re-ordering of newly added Freestyle panels.Dec 18 2014, 10:15 AM
Sergey Sharybin (sergey) lowered the priority of this task from Normal to Confirmed, Low.
Campbell Barton (campbellbarton) added a comment.Jun 8 2015, 8:42 AM

This seems to be fixed? Checked recent build, resetting factory settings.

Checked to fix this... and seems its fixed in master?

Can someone else check this?

Tamito Kajiyama (kjym3) added a comment.Jun 9 2015, 5:59 PM

When the rendering engine is set to Cycles,

  • in the Render properties window, the Freestyle panel comes between the Output and Sampling panels. The Freestyle panel is closed (folded) by default.
  • in the Render Layers properties window, the Freestyle, Freestyle Line Set, and Freestyle Line Style panels comes in this order on top of the Layer panel. Only the last panel is closed by default, and the other two are open.
  • in the Material properties window, the Freestyle Line panel comes between the Custom Properties and Preview panels. The Freestyle Line panel is closed by default.

So the positioning needs to be fixed (preferably as highlighted in the task description in the very beginning).

It is also remarked that Freestyle is an opt-in post-processing tool enabled by the user. For this reason, IMHO the Freestyle-related panels should be open/closed by default as follows:

  • in the Render properties window, the Freestyle panel should be closed (as it is now).
  • in the Render Layers properties window, all the 3 Freestyle-related panels should be open.
  • in the Material properties window, the Freestyle Line panel should be open.