Freestyle method join_upred_predicates missing from rel. 2.71 to 2.72b #42508

New Issue

Wolfgang Geithner · 2014-11-05T21:05:42+01:00

Wolfgang Geithner commented

2014-11-05 21:05:42 +01:00

System Information
Windows 7 Pro

Blender Version
Broken: 2.72b
Worked: 2.71

Short description of error
method join_upred_predicates deleted in module predicates.py. This leads to crash of "Freestyle SVG export" scripts

Exact steps for others to reproduce the error

Create some model
Use Freestyle rendering
Use one of the "Freestyle SVG export" scripts (svg_*.py)
render (Blender / Cycles)

> In Blender render freestyle blacklining does not happen, in Cycles screen simply stays black, error message hinting to missing join_upred_predicates

**System Information** Windows 7 Pro **Blender Version** Broken: 2.72b Worked: 2.71 **Short description of error** method join_upred_predicates deleted in module predicates.py. This leads to crash of "Freestyle SVG export" scripts **Exact steps for others to reproduce the error** * Create some model * Use Freestyle rendering * Use one of the "Freestyle SVG export" scripts (svg_*.py) * render (Blender / Cycles) ## > In Blender render freestyle blacklining does not happen, in Cycles screen simply stays black, error message hinting to missing join_upred_predicates

Wolfgang Geithner commented

2014-11-05 21:05:42 +01:00

Changed status to: 'Open'

Wolfgang Geithner commented

2014-11-05 21:05:42 +01:00

Added subscriber: @WolfgangGeithner

Tamito Kajiyama was assigned by Bastien Montagne

2014-11-07 09:09:13 +01:00

Bastien Montagne commented

2014-11-07 09:09:13 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2014-11-07 09:09:13 +01:00

Tamito, you should know whether this is a bug or expected API change? Thanks for checking.

Tamito Kajiyama commented

2014-11-07 15:03:08 +01:00

Changed status from 'Open' to: 'Archived'

Tamito Kajiyama closed this issue

2014-11-07 15:03:08 +01:00

Tamito Kajiyama commented

2014-11-07 15:03:08 +01:00

The join_unary_predicates() function (not join_upred_predicates() -- I guess it's a typo) was indeed removed in the Blender 2.72 release as part of Freestyle Python API updates (D623). This function was however a helper function only used in the Parameter Editor implementation and was not part of the public API. I was not expecting that there were application codes that used it.

The removed function was used to concatenate multiple predicate objects with logical AND/OR operators. This function was necessary because the operators (AndUP1D and OrUP1D) were accepting only two predicates. Starting from 2.72 these operators accept more than two operands, so the missing function is no longer needed.

There are several SVG export scripts for Freestyle, but I guess the reported problem concerns the SVG export scripts by Francesco Fantoni and Jarno Leppänen. In their svg_*.py scripts in fact there are lines like below:

preds = [
    pyNatureUP1D(Nature.SILHOUETTE),
    pyNatureUP1D(Nature.CREASE),
    ContourUP1D()
]
upred = join_unary_predicates(preds, OrUP1D)
upred = AndUP1D(QuantitativeInvisibilityUP1D(0), upred)

These lines need updating for 2.72, for example as follows:

upred = AndUP1D(QuantitativeInvisibilityUP1D(0),
                OrUP1D(pyNatureUP1D(Nature.SILHOUETTE),
                       pyNatureUP1D(Nature.CREASE),
                       ContourUP1D()))

The join_unary_predicates() function (not join_upred_predicates() -- I guess it's a typo) was indeed removed in the Blender 2.72 release as part of Freestyle Python API updates ([D623](https://archive.blender.org/developer/D623)). This function was however a helper function only used in the Parameter Editor implementation and was not part of the public API. I was not expecting that there were application codes that used it. The removed function was used to concatenate multiple predicate objects with logical AND/OR operators. This function was necessary because the operators (AndUP1D and OrUP1D) were accepting only two predicates. Starting from 2.72 these operators accept more than two operands, so the missing function is no longer needed. There are several SVG export scripts for Freestyle, but I guess the reported problem concerns the [SVG export scripts ](https://github.com/hvfrancesco/freestylesvg) by Francesco Fantoni and Jarno Leppänen. In their svg_*.py scripts in fact there are lines like below: ``` preds = [ pyNatureUP1D(Nature.SILHOUETTE), pyNatureUP1D(Nature.CREASE), ContourUP1D() ] upred = join_unary_predicates(preds, OrUP1D) upred = AndUP1D(QuantitativeInvisibilityUP1D(0), upred) ``` These lines need updating for 2.72, for example as follows: ``` upred = AndUP1D(QuantitativeInvisibilityUP1D(0), OrUP1D(pyNatureUP1D(Nature.SILHOUETTE), pyNatureUP1D(Nature.CREASE), ContourUP1D())) ```

francesco fantoni commented

2014-12-05 10:05:56 +01:00

Added subscriber: @hva

francesco fantoni commented

2014-12-05 10:05:56 +01:00

I've updated the SVG export scripts on github to use 2.72 API

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Freestyle method join_upred_predicates missing from rel. 2.71 to 2.72b #42508

> In Blender render freestyle blacklining does not happen, in Cycles screen simply stays black, error message hinting to missing join_upred_predicates