install_deps.sh gives slight misinformation [patch attached] #42555

New Issue

inactive account · 2014-11-09T23:14:38+01:00

inactive account commented

2014-11-09 23:14:38 +01:00

System Information
Ubuntu 14.10, but probably applies to other Linux and Linux-like systems

Blender Version
Broken: 2.72, git hash 8c712eaa29

Short description of error
In short, the final message of install_deps.sh could be interpreted that you either pass options to CMake, or you run make. This is only correct when CMake has already been succesfully run before.

Exact steps for others to reproduce the error
Run install_deps.sh, then check this message:

If you're using CMake add this to your configuration flags:
  -D OPENCOLORIO_ROOT_DIR=/opt/lib/ocio
  -D OPENEXR_ROOT_DIR=/opt/lib/openexr
  -D OPENIMAGEIO_ROOT_DIR=/opt/lib/oiio
  -D WITH_CYCLES_OSL=ON
  -D WITH_LLVM=ON
  -D LLVM_VERSION=3.4
  -D CYCLES_OSL=/opt/lib/osl
  -D WITH_CODEC_FFMPEG=ON
  -D FFMPEG_LIBRARIES='avformat;avcodec;avutil;avdevice;swscale;rt;theoradec;theoraenc;theora;vorbisfile;vorbis;vorbisenc;ogg;x264;openjpeg_JPWL;openjpeg'
  -D FFMPEG=/opt/lib/ffmpeg

Or even simpler, just run (in your blender-source dir):
  make -j8 BUILD_CMAKE_ARGS=" -D OPENCOLORIO_ROOT_DIR=/opt/lib/ocio -D OPENEXR_ROOT_DIR=/opt/lib/openexr -D OPENIMAGEIO_ROOT_DIR=/opt/lib/oiio -D WITH_CYCLES_OSL=ON -D WITH_LLVM=ON -D LLVM_VERSION=3.4 -D CYCLES_OSL=/opt/lib/osl -D WITH_CODEC_FFMPEG=ON -D FFMPEG_LIBRARIES='avformat;avcodec;avutil;avdevice;swscale;rt;theoradec;theoraenc;theora;vorbisfile;vorbis;vorbisenc;ogg;x264;openjpeg_JPWL;openjpeg' -D FFMPEG=/opt/lib/ffmpeg"

The text "Or even simpler..." could mean "never mind reading the above, the next thing is simpler, so just do that". This is incorrect, as there is no Makefile to begin with. Somebody (read: me) could be inclined to run CMake without reading the instructions to pass it certain options, just to try and create that missing Makefile (which won't work).

IMO the attached patch 0001-Clarified-the-note-that-you-can-give-CMake-arguments.patch cleans this up with only a minimal change in the text.

**System Information** Ubuntu 14.10, but probably applies to other Linux and Linux-like systems **Blender Version** Broken: 2.72, git hash 8c712eaa297162669fc0be849da115dd8db400d5 **Short description of error** In short, the final message of install_deps.sh could be interpreted that you either pass options to CMake, or you run make. This is only correct when CMake has already been succesfully run before. **Exact steps for others to reproduce the error** Run install_deps.sh, then check this message: ``` If you're using CMake add this to your configuration flags: -D OPENCOLORIO_ROOT_DIR=/opt/lib/ocio -D OPENEXR_ROOT_DIR=/opt/lib/openexr -D OPENIMAGEIO_ROOT_DIR=/opt/lib/oiio -D WITH_CYCLES_OSL=ON -D WITH_LLVM=ON -D LLVM_VERSION=3.4 -D CYCLES_OSL=/opt/lib/osl -D WITH_CODEC_FFMPEG=ON -D FFMPEG_LIBRARIES='avformat;avcodec;avutil;avdevice;swscale;rt;theoradec;theoraenc;theora;vorbisfile;vorbis;vorbisenc;ogg;x264;openjpeg_JPWL;openjpeg' -D FFMPEG=/opt/lib/ffmpeg Or even simpler, just run (in your blender-source dir): make -j8 BUILD_CMAKE_ARGS=" -D OPENCOLORIO_ROOT_DIR=/opt/lib/ocio -D OPENEXR_ROOT_DIR=/opt/lib/openexr -D OPENIMAGEIO_ROOT_DIR=/opt/lib/oiio -D WITH_CYCLES_OSL=ON -D WITH_LLVM=ON -D LLVM_VERSION=3.4 -D CYCLES_OSL=/opt/lib/osl -D WITH_CODEC_FFMPEG=ON -D FFMPEG_LIBRARIES='avformat;avcodec;avutil;avdevice;swscale;rt;theoradec;theoraenc;theora;vorbisfile;vorbis;vorbisenc;ogg;x264;openjpeg_JPWL;openjpeg' -D FFMPEG=/opt/lib/ffmpeg" ``` The text "Or even simpler..." could mean "never mind reading the above, the next thing is simpler, so just do that". This is incorrect, as there is no Makefile to begin with. Somebody (read: me) could be inclined to run CMake without reading the instructions to pass it certain options, just to try and create that missing Makefile (which won't work). IMO the attached patch [0001-Clarified-the-note-that-you-can-give-CMake-arguments.patch](https://archive.blender.org/developer/F122962/0001-Clarified-the-note-that-you-can-give-CMake-arguments.patch) cleans this up with only a minimal change in the text.

inactive account commented

2014-11-09 23:14:38 +01:00

Changed status to: 'Open'