Corrective smooth apply as shape key does not work #44663

New Issue

Jack Simpson · 2015-05-11T04:17:03+02:00

Jack Simpson commented

2015-05-11 04:17:03 +02:00

System Information
Window 8.1, Nvidia GTX 770

Blender Version
Broken: 2.74. f8540d7 (from build bot)
Also reported by BlenderArtists forum user DanPro for build dc95ca9

Short description of error
Apply as shape on the corrective smooth modifier creates an empty shape key.
Apply as shape in the same conditions for the smooth modifier works fine.

Exact steps for others to reproduce the error

create mesh skinned to armature (e.g. cylinder skinned to two bones)
add corrective smooth modifier after armature modifier
pose armature
apply corrective smooth modifier as shape (or to mesh)
the resulting shape key would be empty (should contain the corrective smoothing effect for that pose)
File: corrsmooth_shape_bug.blend

**System Information** Window 8.1, Nvidia GTX 770 **Blender Version** Broken: 2.74. f8540d7 (from build bot) Also reported by [BlenderArtists forum user DanPro for build dc95ca9 ](http://blenderartists.org/forum/showthread.php?366313-Delta-Mush-Modifier&p=2867232&viewfull=1#post2867232) **Short description of error** Apply as shape on the corrective smooth modifier creates an empty shape key. Apply as shape in the same conditions for the smooth modifier works fine. **Exact steps for others to reproduce the error** 1. create mesh skinned to armature (e.g. cylinder skinned to two bones) 2. add corrective smooth modifier after armature modifier 3. pose armature 4. apply corrective smooth modifier as shape (or to mesh) 5. the resulting shape key would be empty (should contain the corrective smoothing effect for that pose) File: [corrsmooth_shape_bug.blend](https://archive.blender.org/developer/F172392/corrsmooth_shape_bug.blend)

Jack Simpson commented

2015-05-11 04:17:03 +02:00

Changed status to: 'Open'

Jack Simpson self-assigned this 2015-05-11 04:17:03 +02:00

Jack Simpson commented

2015-05-11 04:17:03 +02:00

Added subscriber: @sazerac

Campbell Barton commented

2015-05-11 05:35:22 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2015-05-11 05:35:22 +02:00

This isnt exactly a bug, in at least that the behavior is working as intended, it just happens not to be very useful behavior in the case of corrective smooth modifier, because this is one of the few modifiers that relies on previous modifiers to be applied before it has any effect.

Apply as shape key disables all modifiers except for one, applies it on its own, then applies any changes as a shape.

This happens not to do what you want with Corrective Smooth, because this modifier relies on preceding modifiers to deform the original coordinates, before it makes any difference.

You can see that it is working, because enabling 'Only Smooth' before applying as shape, does what you would expect.

I can think of a few ways this could be made to work...

It could just apply all deform modifiers up until the corrective smooth modifier. (but that will bake the pose in too - which isn't typically what you want)
It could calculate the deformation thats being applied to the previous modifier, then apply the deltas to a shape key on the base mesh (using per vertex tangents).

I'm interested to see how this could work, but its not a software error, moving to design task.

This isnt exactly a bug, in at least that the behavior is working as intended, it just happens not to be very useful behavior in the case of corrective smooth modifier, because this is one of the few modifiers that relies on previous modifiers to be applied before it has any effect. Apply as shape key disables all modifiers except for one, applies it on its own, then applies any changes as a shape. This happens not to do what you want with *Corrective Smooth*, because this modifier relies on preceding modifiers to deform the original coordinates, before it makes any difference. You can see that it is working, because enabling 'Only Smooth' before applying as shape, does what you would expect. ---- I can think of a few ways this could be made to work... - It could just apply all deform modifiers up until the corrective smooth modifier. *(but that will bake the pose in too - which isn't typically what you want)* - It could calculate the deformation thats being applied to the previous modifier, then apply the deltas to a shape key on the base mesh (using per vertex tangents). I'm interested to see how this could work, but its not a software error, moving to design task.

Jack Simpson was unassigned by Bastien Montagne

2015-05-11 09:31:36 +02:00

Jack Simpson commented

2015-05-13 11:23:42 +02:00

In #44663#307874, @ideasman42 wrote:

I can think of a few ways this could be made to work...

It could just apply all deform modifiers up until the corrective smooth modifier. (but that will bake the pose in too - which isn't typically what you want)

It could calculate the deformation thats being applied to the previous modifier, then apply the deltas to a shape key on the base mesh (using per vertex tangents).

I'm interested to see how this could work, but its not a software error, moving to design task.

Thanks for the suggestions. I think the second option would be much more useful.
I'm assuming the relevant code here is:
object_modifier.c : modifier_apply_shape
and
DerivedMesh.c : mesh_create_derived_for_modifier

Am I right that mesh_create_derived_for_modifier is only called by the apply/apply as shape functionality?

Looking at how this is done in blender, it looks like any change here would be awfully special-casey just for the one modifier. I guess the second option for apply as shape could potentially work for any modifier at the moment and may actually product more intuitive results in some cases (shrinkwrap on a posed char comes to mind, also useful in some cases for making corrective shapes). However this will obviously change the results of this option, so isn't a change to make lightly.

@ideasman42, what do you think?

> In #44663#307874, @ideasman42 wrote: > > I can think of a few ways this could be made to work... > > - It could just apply all deform modifiers up until the corrective smooth modifier. *(but that will bake the pose in too - which isn't typically what you want)* > - It could calculate the deformation thats being applied to the previous modifier, then apply the deltas to a shape key on the base mesh (using per vertex tangents). > > I'm interested to see how this could work, but its not a software error, moving to design task. Thanks for the suggestions. I think the second option would be much more useful. I'm assuming the relevant code here is: object_modifier.c : modifier_apply_shape and DerivedMesh.c : mesh_create_derived_for_modifier Am I right that mesh_create_derived_for_modifier is only called by the apply/apply as shape functionality? Looking at how this is done in blender, it looks like any change here would be awfully special-casey just for the one modifier. I guess the second option for apply as shape could potentially work for any modifier at the moment and may actually product more intuitive results in some cases (shrinkwrap on a posed char comes to mind, also useful in some cases for making corrective shapes). However this will obviously change the results of this option, so isn't a change to make lightly. @ideasman42, what do you think?

Campbell Barton commented

2015-05-13 23:15:52 +02:00

@sazerac, yep, modifier_apply_shape would need to be changed quite a bit.

Agree using deltas is most useful here, and probably best this is first added as an option, then we can see how to expose.

eg: [Apply, Copy] buttons use quite a bit if space, we could move all into a small single icon menu.
(like what we have already for vertex groups containing options to sort, copy, lock ... etc).

Then we can have Different menu items for applying the shape key.

Or as an alternative we could tag modifier types where it only makes sense to apply the difference as a shape, and do it automatically. (though there could be rare cases you want either options)

@sazerac, yep, `modifier_apply_shape` would need to be changed quite a bit. Agree using deltas is most useful here, and probably best this is first added as an option, then we can see how to expose. ---- eg: [Apply, Copy] buttons use quite a bit if space, we could move all into a small single icon menu. (like what we have already for vertex groups containing options to sort, copy, lock ... etc). Then we can have Different menu items for applying the shape key. Or as an alternative we could tag modifier types where it only makes sense to apply the difference as a shape, and do it automatically. (though there could be rare cases you want either options)

Jack Simpson commented

2015-05-23 07:07:37 +02:00

Had a bit more of a look/think about this and deriving the correct shape is not trivial, I think this kind of functionality would make more sense as an extension on what is in the corrective shape keys addon.

Andreas commented

2015-07-06 21:43:09 +02:00

Added subscriber: @LuckyTea

Andreas commented

2015-07-06 21:43:09 +02:00

I too noticed this behavior and expected something different. I created this report here:
https://developer.blender.org/T45293

before finding this thread.

Creating corrective shape keys with the corrective smooth modifier would be really great indeed. I hope it will be added at some point!

I too noticed this behavior and expected something different. I created this report here: https://developer.blender.org/T45293 before finding this thread. Creating corrective shape keys with the corrective smooth modifier would be really great indeed. I hope it will be added at some point!

Demeter Dzadik commented

2019-09-05 15:00:24 +02:00

Added subscriber: @Mets

SavMartin commented

2020-03-01 16:33:34 +01:00

Added subscriber: @SavMartin

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Corrective smooth apply as shape key does not work #44663