Save Buffers cancelled renders show nothing in Image Editor #44682

New Issue

Dalai Felinto · 2015-05-12T07:30:01+02:00

Dalai Felinto commented

2015-05-12 07:30:01 +02:00

System Information
OSX 10.9

Blender Version
Broken: master (e38f9144)
Worked: 2.74 (or rather, pre-multiview)

Short description of error
After cancelling a render that uses "Save Buffers" the rendered so far result is not flushed to the Image Editor.

Also I get a message along those lines, which seems to be clearly related:

//OpenEXR-readPixels: ERROR: Error reading pixel data from image file
"/tmp/blender_aWGCTb/display_buffer_progress_blend_Scene_Cube_exr". Tile (0, 0, 0, 0) is missing.//

Exact steps for others to reproduce the error
Open the file: display_buffer_progress.blend , press render, and Esc after a few of the tiles are rendered.

(note: originally reported here - 1227e5c3 since it was masked by the bug fixed by that commit)

**System Information** OSX 10.9 **Blender Version** Broken: master (e38f9144) Worked: 2.74 (or rather, pre-multiview) **Short description of error** After cancelling a render that uses "Save Buffers" the rendered so far result is not flushed to the Image Editor. Also I get a message along those lines, which seems to be clearly related: //OpenEXR-readPixels: ERROR: Error reading pixel data from image file "/tmp/blender_aWGCTb/display_buffer_progress_blend_Scene_Cube_exr". Tile (0, 0, 0, 0) is missing.// **Exact steps for others to reproduce the error** Open the file: [display_buffer_progress.blend](https://archive.blender.org/developer/F173134/display_buffer_progress.blend) , press render, and Esc after a few of the tiles are rendered. (note: originally reported here - 1227e5c3 since it was masked by the bug fixed by that commit)

Dalai Felinto commented

2015-05-12 07:30:01 +02:00

Changed status to: 'Open'

Dalai Felinto commented

2015-05-12 07:30:01 +02:00

Added subscriber: @dfelinto

Dalai Felinto was assigned by Sergey Sharybin

2015-05-12 13:44:52 +02:00

Sergey Sharybin commented

2015-05-12 13:44:52 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2015-05-12 13:44:52 +02:00

Dalai, isn't it up to you? :)

Dalai Felinto commented

2015-05-12 16:05:12 +02:00

Yes it is, but I'm having a hard time pinning this out and thought it was worthy reporting it officially :)

I believe this may have to do with all RenderLayers now having a COMBINED pass. display_buffer relies on a strange design in my opinion :/

Yes it is, but I'm having a hard time pinning this out and thought it was worthy reporting it officially :) I believe this may have to do with all RenderLayers now having a COMBINED pass. display_buffer relies on a strange design in my opinion :/

Sergey Sharybin commented

2015-05-12 16:08:03 +02:00

display_buffer is needed to prevent having full-frame float buffer during rendering, so memory footprint is as low as possible. If the COMBINED pass you're referring to is allocated for the whole frame the concept of saving buffers is totally violated then.

`display_buffer` is needed to prevent having full-frame float buffer during rendering, so memory footprint is as low as possible. If the COMBINED pass you're referring to is allocated for the whole frame the concept of saving buffers is totally violated then.

Dalai Felinto commented

2015-05-12 16:28:07 +02:00

The COMBINED pass I'm referring to is the one created in render_result.c::render_result_new(). Before (pre-multiview) we were adding a COMBINED pass only for rr->do_exr_tile.

But that would leave the RenderLayers with no place to store their (pre-view) combined pass (given that "rl->rectf" was extinct), so we create a RenderPass for each layer that is a COMBINED one.

The COMBINED pass I'm referring to is the one created in render_result.c::render_result_new(). Before (pre-multiview) we were adding a COMBINED pass only for rr->do_exr_tile. But that would leave the RenderLayers with no place to store their (pre-view) combined pass (given that "rl->rectf" was extinct), so we create a RenderPass for each layer that is a COMBINED one.

Dalai Felinto commented

2015-05-12 18:21:19 +02:00

Just a thought, maybe the issue here is that instead of using TiledOutputFile we are now using MultiPartOutputFile (in IMB_exrtile_begin_write()).

If you use multiview you can see that you can even cancel after one of the views is complete, and get it fully back, when we read back the EXR.

I don't remember now, but maybe a multi-part file can only have a part read back when its complete, while a TiledOutput allowed for incomplete tiles?

Just a thought, maybe the issue here is that instead of using TiledOutputFile we are now using MultiPartOutputFile (in IMB_exrtile_begin_write()). If you use multiview you can see that you can even cancel after one of the views is complete, and get it fully back, when we read back the EXR. I don't remember now, but maybe a multi-part file can only have a part read back when its complete, while a TiledOutput allowed for incomplete tiles?

Dalai Felinto commented

2015-05-12 19:00:01 +02:00

It doesn't seem to be it, I just replaced the MultiPartOutputFile calls by TiledOutputFile and nothing changed (apart from the fact that multiview + save buffers stops working, which is to be expected)

blender-admin commented

2015-06-17 17:50:50 +02:00

This issue was referenced by fc35b758ad

This issue was referenced by fc35b758ade7062b194076c7dd3b848792c1a4ea

Sergey Sharybin commented

2015-06-17 17:51:05 +02:00

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2015-06-17 17:51:05 +02:00

blender-admin commented

2015-06-18 17:24:19 +02:00

This issue was referenced by 4fe9fe74ae

This issue was referenced by 4fe9fe74ae674eef12556888fa948ecd7967dccb

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Save Buffers cancelled renders show nothing in Image Editor #44682