bpy.ops.graph.sound_bake() doesn't check valid filepath #44815

New Issue

Dealga McArdle · 2015-05-23T16:14:46+02:00

Dealga McArdle commented

2015-05-23 16:14:46 +02:00

System Information
any

Blender Version
any

Short description of error
The operator does not seem to check the validity of the filepath, because normally it is triggered from the UI
after a fileselect dialog. If filepath passed by the user in the form of a script is invalid then the operator
can't assume the filepath is valid, but it does and still tries to run. It will give errors, some of which are listed here,
and none of which are as informative as they could be.

errors

~~SyntaxError (unicode-error) 'unicodescape' codec can't decode bytes in position 2-3 truncated \UXXXXXXXX escape~~
RuntimeError: Error: Unsupported audio format

Ideally it would check the filepath, and return an error about how to construct a valid file path or a reference to a docstring with tips for the various operating systems. Something like:

valid filepaths are.

windows

 filepath = "C:\\some\\folder\\file.mp3"
 filepath = r"C:\some\folder\file.mp3"
 filepath = "C:/some/folder/file.mp3"

posix style (linux, osx)

 filepath = "/home/folder/file.mp3"

why the verbose message?
because paths are hard for people who make this kind of mistake, why not be more helpful. Alternatively a more verbose entry in the helpfile for that operator.

Exact steps for others to reproduce the error
plenty of posts to pick from:
http://blender.stackexchange.com/questions/15288/sound-bake-by-script-unsupported-audio-format-error?rq=1

**System Information** any **Blender Version** any **Short description of error** The operator does not seem to check the validity of the filepath, because normally it is triggered from the UI after a fileselect dialog. If filepath passed by the user in the form of a script is invalid then the operator can't assume the filepath is valid, but it does and still tries to run. It will give errors, some of which are listed here, and none of which are as informative as they could be. errors - ~~SyntaxError (unicode-error) 'unicodescape' codec can't decode bytes in position 2-3 truncated \UXXXXXXXX escape~~ - RuntimeError: Error: Unsupported audio format Ideally it would check the filepath, and return an error about how to construct a valid file path or a reference to a docstring with tips for the various operating systems. Something like: ``` valid filepaths are. ``` # windows ``` filepath = "C:\\some\\folder\\file.mp3" filepath = r"C:\some\folder\file.mp3" filepath = "C:/some/folder/file.mp3" ``` # posix style (linux, osx) ``` filepath = "/home/folder/file.mp3" ``` **why the verbose message?** because paths are hard for people who make this kind of mistake, why not be more helpful. Alternatively a more verbose entry in the helpfile for that operator. **Exact steps for others to reproduce the error** plenty of posts to pick from: http://blender.stackexchange.com/questions/15288/sound-bake-by-script-unsupported-audio-format-error?rq=1

Dealga McArdle commented

2015-05-23 16:14:46 +02:00

Changed status to: 'Open'

Dealga McArdle commented

2015-05-23 16:14:46 +02:00

Added subscriber: @tetha.z

Campbell Barton was assigned by Bastien Montagne

2015-05-24 18:41:25 +02:00

Bastien Montagne commented

2015-05-24 18:41:25 +02:00

Added subscriber: @mont29

Campbell Barton commented

2015-05-25 03:18:44 +02:00

I can see if the path isn't writable it will give a general (and incorrect) error: "Unsupported audio format".
That can be fixed quite easily.

But there are no steps in this report to redo the error SyntaxError (unicode-error).

Please include a blend file that generates this error with minimal number of steps.

I can see if the path isn't writable it will give a general (and incorrect) error: **"Unsupported audio format"**. That can be fixed quite easily. But there are no steps in this report to redo the error `SyntaxError (unicode-error)`. Please include a blend file that generates this error with minimal number of steps.

Dealga McArdle commented

2015-05-25 09:14:52 +02:00

Unsupported audio format is the error I get too with invalid paths.

The unicode error is not one i've been able to reproduce but, passing the correct path has supposedly cleared that error. If it's OK with you i'll remove that error message from the bug report and consider this fixed if patched?

The anecdotal nature of the unicode error made me think twice about including it..i shouldn't have.

`Unsupported audio format` is the error I get too with invalid paths. The unicode error is not one i've been able to reproduce but, [passing the correct path has supposedly cleared that error](http://blender.stackexchange.com/questions/31336/audio-visualizer-script-error). If it's OK with you i'll remove that error message from the bug report and consider this fixed if patched? The anecdotal nature of the unicode error made me think twice about including it..i shouldn't have.

blender-admin commented

2015-05-25 14:13:18 +02:00

This issue was referenced by 39b85e452f

This issue was referenced by 39b85e452faae543d10831e4fa66fdffbc22e0a1

Campbell Barton commented

2015-05-25 14:13:59 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2015-05-25 14:13:59 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

bpy.ops.graph.sound_bake() doesn't check valid filepath #44815

windows

posix style (linux, osx)