MSAA on Windows for Intel GPU and #45186

New Issue

Benoit Bolsee · 2015-06-25T08:26:17+02:00

Benoit Bolsee commented

2015-06-25 08:26:17 +02:00

The Windows WGL code in Blender gives preference to double buffer swap copy method over multisample anti-aliasing (not in Linux, then why in Windows??) : fewer AA samples will be chosen if it is the condition to get swap copy.
On Intel integrated GPU this removes the possibily to use AA because you cannot get swap copy and AA at the same time.

This patch reverses the order of priority: swap copy will be abandonned if another swap method (undefined or exchange) provides the requested number of AA samples. If no AA samples is requested, then swap copy still has the priority of course.

The Windows WGL code in Blender gives preference to double buffer swap copy method over multisample anti-aliasing (not in Linux, then why in Windows??) : fewer AA samples will be chosen if it is the condition to get swap copy. On Intel integrated GPU this removes the possibily to use AA because you cannot get swap copy and AA at the same time. This patch reverses the order of priority: swap copy will be abandonned if another swap method (undefined or exchange) provides the requested number of AA samples. If no AA samples is requested, then swap copy still has the priority of course.

Benoit Bolsee commented

2015-06-25 08:26:17 +02:00

Changed status to: 'Open'

Benoit Bolsee commented

2015-06-25 08:26:17 +02:00

Added subscriber: @BenoitBolsee

Benoit Bolsee commented

2015-06-25 08:34:29 +02:00

msaa.patch

[msaa.patch](https://archive.blender.org/developer/F197207/msaa.patch)

Benoit Bolsee commented

2015-06-25 08:40:28 +02:00

Added subscribers: @ideasman42, @dfelinto

Benoit Bolsee commented

2015-06-25 08:45:18 +02:00

msaa.patch
The first patch was incomplete, this is the good one

[msaa.patch](https://archive.blender.org/developer/F197208/msaa.patch) The first patch was incomplete, this is the good one

Bastien Montagne commented

2015-06-27 15:54:55 +02:00

Added subscriber: @mont29

Antonis Ryakiotakis was assigned by Bastien Montagne

2015-06-27 15:54:55 +02:00

Bastien Montagne commented

2015-06-27 15:54:55 +02:00

Antony, I guess this patch is for you. :)

Dalai Felinto commented

2015-07-01 17:47:51 +02:00

I don't like how our ghost system work, where we need to manually provide a fallback for every single setting we would like to see supported (I ran into that issue with multiview, where in Linux the stereo quadbuffer mode was not supported in some machines, and the fallback was just a broken context ghost).

That said, I think the patch seems fine on top of what we have in terms of design. I just hope things change eventually.

I have no windows at hand, so I leave it to @Psy-Fi to give a definitive review of the code.

I don't like how our ghost system work, where we need to manually provide a fallback for every single setting we would like to see supported (I ran into that issue with multiview, where in Linux the stereo quadbuffer mode was not supported in some machines, and the fallback was just a broken context ghost). That said, I think the patch seems fine on top of what we have in terms of design. I just hope things change eventually. I have no windows at hand, so I leave it to @Psy-Fi to give a definitive review of the code.

Aaron Carlisle commented

2015-07-01 19:33:27 +02:00

Added subscriber: @Blendify

Benoit Bolsee commented

2015-07-01 22:45:30 +02:00

I created a proper patch for this task:
[D1384 ](https://developer.blender.org/D1384)

Thanks @dfelinto for showing me the method.

I created a proper patch for this task: [[D1384](https://archive.blender.org/developer/D1384) ](https://developer.blender.org/D1384) Thanks @dfelinto for showing me the method.

Aaron Carlisle commented

2015-08-07 18:24:19 +02:00

Changed status from 'Open' to: 'Resolved'

Aaron Carlisle closed this issue

2015-08-07 18:24:19 +02:00

Aaron Carlisle commented

2015-08-07 18:24:19 +02:00

Committed 422ffd252a this should have been closed a while ago

Committed 422ffd252ac5f73f27f3c91b75b5d20a0ed7d460 this should have been closed a while ago

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

MSAA on Windows for Intel GPU and #45186