Deprecate legacy MFace data storage #45474

New Issue

Campbell Barton · 2015-07-17T22:48:59+02:00

Campbell Barton commented

2015-07-17 22:48:59 +02:00

Remove use of MFace where tellellation triangles are appropriate.

The goal of this task is to continue work from D1405, which introduced tessellation triangles.

In summary, MFace is a legacy storage format for faces, and ideally should only be used for saving for older blender versions (The legacy mesh format options)/

Done

DerivedMesh Drawing (many commits)
Project paint 416d164fec
Dynamic paint D1429, e48c4d73d3
imapaint_pick_uv cdd1be44c5
Smoke D1424 cc5d48e8dd
source/blender/editors/armature/meshlaplacian.c e3f86c6580
source/blender/modifiers/intern/MOD_remesh.c e5e9fbfaf0
source/blender/blenkernel/intern/rigidbody.c 23a4f547e7
source/blender/editors/transform/transform_snap.c 717046ad2a 60822ec183
BVHTree (currently support both MFace and LoopTri until everything is moved over)
Collision modifier c582e186d9
Softbody 63215aea6f 31fe49626f
source/blender/modifiers/intern/MOD_laplaciandeform.c 20ec508ca3
source/blender/modifiers/intern/MOD_laplaciansmooth.c f1a9a8cbfd
DerivedMesh tangents 2ec00ea0c1
Cloth c4b2bef163
Fluid 03b2bccca8

TODO

This task is to keep track of TODO

Isolated areas:

...will need to detect 2x tri's as quads here:

Larger areas of code:

Particles
Blender Internal Renderer
Cycles
Cycles Baking

Remove use of MFace where tellellation triangles are appropriate. The goal of this task is to continue work from [D1405](https://archive.blender.org/developer/D1405), which introduced tessellation triangles. In summary, `MFace` is a legacy storage format for faces, and ideally should only be used for saving for older blender versions (The legacy mesh format options)/ Done ---- - DerivedMesh Drawing *(many commits)* - Project paint 416d164fec - Dynamic paint [D1429](https://archive.blender.org/developer/D1429), e48c4d73d3 - `imapaint_pick_uv` cdd1be44c5 - Smoke [D1424](https://archive.blender.org/developer/D1424) cc5d48e8dd - `source/blender/editors/armature/meshlaplacian.c` e3f86c6580 - `source/blender/modifiers/intern/MOD_remesh.c` e5e9fbfaf0 - `source/blender/blenkernel/intern/rigidbody.c` 23a4f547e7 - `source/blender/editors/transform/transform_snap.c` 717046ad2a 60822ec183 - BVHTree *(currently support both MFace and LoopTri until everything is moved over)* - Collision modifier c582e186d9 - Softbody 63215aea6f 31fe49626f - `source/blender/modifiers/intern/MOD_laplaciandeform.c` 20ec508ca3 - `source/blender/modifiers/intern/MOD_laplaciansmooth.c` f1a9a8cbfd - DerivedMesh tangents 2ec00ea0c1 - Cloth c4b2bef163 - Fluid 03b2bccca8 TODO ---- This task is to keep track of TODO ---- **Isolated areas:** ...*will need to detect 2x tri's as quads here:* ---- **Larger areas of code:** - Particles - Blender Internal Renderer - Cycles - Cycles Baking

Campbell Barton commented

2015-07-17 22:48:59 +02:00

Changed status to: 'Open'

Campbell Barton commented

2015-07-17 22:48:59 +02:00

Added subscriber: @ideasman42

Campbell Barton self-assigned this 2015-07-17 22:50:07 +02:00

Campbell Barton commented

2015-07-17 22:50:07 +02:00

Added subscriber: @Psy-Fi

Bastien Montagne commented

2015-07-17 23:35:46 +02:00

Added subscriber: @mont29

Martin Felke commented

2015-07-18 09:39:35 +02:00

Added subscriber: @scorpion81

Sergey Sharybin commented

2015-07-21 10:32:14 +02:00

Added subscriber: @Sergey

Philipp Oeser commented

2015-07-27 11:16:32 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2015-07-27 11:16:32 +02:00

will look into cloth

Philipp Oeser commented

2015-07-27 17:11:26 +02:00

... which will touch collisions, which will touch softbody/particles.... so atm it seems this will happen all in one go....

Aaron Carlisle commented

2015-07-28 17:49:20 +02:00

Added subscriber: @Blendify

Campbell Barton commented

2015-07-31 11:28:11 +02:00

@lichtwerk, The part of the code that all happens in one go is done now. But cloth logic is still using MFace 's.
Looks like this shares some code with softbody, which is now using looptri's, though the way springs work may make cloth more complicated. For now softbody ignores NGons completely, since the option is called "stiff quads", I think its OK, we could add some logic to add springs to an ngon's opposite vertices, though I have the impression for cloth/physics meshes, its not likely users rely on a lot of ngons anyway.

@lichtwerk, The part of the code that all happens in one go is done now. But cloth logic is still using `MFace` 's. Looks like this shares some code with softbody, which is now using looptri's, though the way springs work may make cloth more complicated. For now softbody ignores NGons completely, since the option is called "stiff quads", I think its OK, we could add some logic to add springs to an ngon's opposite vertices, though I have the impression for cloth/physics meshes, its not likely users rely on a lot of ngons anyway.

Philipp Oeser commented

2015-07-31 11:42:52 +02:00

@ideasman42: OKi, thanx for this, we already had contact, just wanted to post here too that time is sparse the next days so please go ahead...
[in my limited uneducated tests in cloth --> this was working fine with tesselated looptris]

@ideasman42: OKi, thanx for this, we already had contact, just wanted to post here too that time is sparse the next days so please go ahead... [in my limited uneducated tests in cloth --> this was working fine with tesselated looptris]

Campbell Barton commented

2015-08-28 19:01:58 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2015-08-28 19:01:58 +02:00

Campbell Barton commented

2015-08-28 19:01:58 +02:00

This is done for the mostpart, a few areas remain - such as particles and blender-internal render.
But this is a much bigger change to move to looptri.

So closing this task.

This is done for the mostpart, a few areas remain - such as particles and blender-internal render. But this is a much bigger change to move to looptri. So closing this task.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Deprecate legacy MFace data storage #45474

Done

TODO