Highlight active item in pop-up menu (eg: Editor Type) #45643

New Issue

Paweł Łyczkowski · 2015-08-01T15:22:14+02:00

2015-08-01 15:22:14 +02:00

Currently the only way for newcomers to learn what is the currently chosen Editor in an Area is to compare the icon in the Editor Type combo-box with the list of icons when the combo box is open (it's not something that long time users think about).

Paweł Łyczkowski commented

2015-08-01 15:22:14 +02:00

Changed status to: 'Open'

Paweł Łyczkowski commented

2015-08-01 15:22:14 +02:00

Added subscribers: @PawelLyczkowski-1, @JulianEisel, @JonathanWilliamson

Paweł Łyczkowski commented

2015-08-01 15:23:43 +02:00

Here is my proposition:

Here is my proposition: ![asdf.png](https://archive.blender.org/developer/F216815/asdf.png)

Paweł Łyczkowski commented

2015-08-01 15:25:49 +02:00

Added subscriber: @ideasman42

ronan ducluzeau commented

2015-08-01 15:33:38 +02:00

Added subscriber: @zeauro

ronan ducluzeau commented

2015-08-01 15:33:38 +02:00

I have to say that I did not immediately notice this little dot.
I think that problem is the massive text that list represents.
IMHO, it would be better if inactive editors were greyed out.

I have to say that I did not immediately notice this little dot. I think that problem is the massive text that list represents. IMHO, it would be better if inactive editors were greyed out.

Paweł Łyczkowski commented

2015-08-01 15:42:29 +02:00

@zeauro Grayed out means "inactive", as in "not possible to activate".

It could be some sort of highlight, for instance the standard one but with 50% opacity.

Here is a mockup with a highlight by Nicolas Wirrmann:

@zeauro Grayed out means "inactive", as in "not possible to activate". It could be some sort of highlight, for instance the standard one but with 50% opacity. Here is a mockup with a highlight by Nicolas Wirrmann: ![asdf.jpg](https://archive.blender.org/developer/F216822/asdf.jpg)

Julian Eisel commented

2015-08-01 15:55:36 +02:00

I like the idea, general +1 from here. I even think the dot is enough, we could introduce this for all/more menus of this type, people will become used to it then.

ronan ducluzeau commented

2015-08-01 18:16:14 +02:00

It seems that an highlight at 50 % is counterproductive. It looks less readable as is.
It is why I wanted to say item text highlighted for active editor.
It could be simply a different color. The one mostly used for active item.

IMHO, a full item background totally colored looks too much to selection under mouse.

But I think that an horizontal symbol works better to interrupt vertical scanning.
I propose a subtil outline or a symbol doubled on right and left side to frame the item.
Sorry, I made a mistake in my mock-up. I should have capture User preferences.

It seems that an highlight at 50 % is counterproductive. It looks less readable as is. It is why I wanted to say item text highlighted for active editor. It could be simply a different color. The one mostly used for active item. ![AEHlight2.jpg](https://archive.blender.org/developer/F216899/AEHlight2.jpg) IMHO, a full item background totally colored looks too much to selection under mouse. But I think that an horizontal symbol works better to interrupt vertical scanning. I propose a subtil outline or a symbol doubled on right and left side to frame the item. Sorry, I made a mistake in my mock-up. I should have capture User preferences. ![AEHlight.jpg](https://archive.blender.org/developer/F216891/AEHlight.jpg)

tyoc213 commented

2015-08-01 22:38:26 +02:00

Added subscriber: @tyoc213

Sergey Sharybin commented

2015-08-03 18:23:30 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2015-08-03 18:23:30 +02:00

I'm not sure why you're re-inventing something here. We've got similar functionality in other menus: layout, scene selection and it is to be generalized for the case being discussed here (if it can't be used already).

Julian Eisel commented

2015-08-03 18:40:25 +02:00

In templateID menus, like the layout or scene menu, the active item is highlighted until another item is highlighted. This isn't a great solution either as it disappears as soon as you enter the menu with the mouse.
Instead I think we could try to find a better solution here and use it for these menus as well.

In templateID menus, like the layout or scene menu, the active item is highlighted until another item is highlighted. This isn't a great solution either as it disappears as soon as you enter the menu with the mouse. Instead I think we could try to find a better solution here and use it for these menus as well.

Campbell Barton commented

2015-08-06 02:55:22 +02:00

While its nice to make improvements to menu behavior, I don't think this is that big a problem.
So rather than adding more UI overlay info... am leaning towards using the existing selection (a little like how other pop-ups already remember their last used values).

@JulianEisel, While using the selection gets lots once the user interacts, I don't think users are opening menus... spending long time to select and item... then forgetting whats active?

This is at least a quick visual hint which is active so you don't need to play some icon-matching game early on before you memorize them.

Even so... can see points for & against this.

While its nice to make improvements to menu behavior, I don't think this is _that_ big a problem. So rather than adding more UI overlay info... am leaning towards using the existing selection *(a little like how other pop-ups already remember their last used values)*. @JulianEisel, While using the selection gets lots once the user interacts, I don't think users are opening menus... spending long time to select and item... then forgetting whats active? This is at least a quick visual hint which is active so you don't need to play some icon-matching game early on before you memorize them. Even so... can see points for & against this.

Campbell Barton commented

2015-08-06 02:57:32 +02:00

Added experimental diff, D1450 which implements highlighting-currently-selected item.

Added experimental diff, [D1450](https://archive.blender.org/developer/D1450) which implements highlighting-currently-selected item.

Campbell Barton changed title from ~~Highlight active Editor Type.~~ to Highlight active item in pop-up menu (eg: Editor Type)

2015-08-08 14:21:00 +02:00

Campbell Barton commented

2015-09-02 16:27:20 +02:00

Did anyone try the patch D1450 ?

Did anyone try the patch [D1450](https://archive.blender.org/developer/D1450) ?

Paweł Łyczkowski commented

2015-09-02 16:44:30 +02:00

@ideasman42

I will. Give me 1-2 days to learn how to do it (it's about time I did).

@ideasman42 I will. Give me 1-2 days to learn how to do it (it's about time I did).

Julian Eisel commented

2015-09-05 20:35:29 +02:00

I tested the patch right after you created it. It's doing what it's supposed to do, and IMHO it's okay as a solution.

Jonathan Williamson commented

2015-09-09 16:54:24 +02:00

@ideasman42 D1450 works well, although personally I find it weird. I find it weird because when I open the menu I immediately feel like my cursor has jumped, since I'm expecting the highlight to be at my cursor location. Admittedly I've never really found the original issue to be a problem, but that could simply be experience.

@ideasman42 [D1450](https://archive.blender.org/developer/D1450) works well, although personally I find it weird. I find it weird because when I open the menu I immediately feel like my cursor has jumped, since I'm expecting the highlight to be at my cursor location. Admittedly I've never really found the original issue to be a problem, but that could simply be experience.

Jonathan Williamson commented

2015-09-09 16:55:46 +02:00

I should add, I'm not convinced that the core issue is actually a problem because we already change out the icon on the menu to be the current selection. In other words a new user can learn what editor is active by what icon is displayed. Seems to me this is more effective than a highlight of some kind would be.

Campbell Barton commented

2015-09-09 19:08:26 +02:00

Also not convinced this is really needed or useful enough to justify the change.

Paweł Łyczkowski commented

2015-09-09 19:34:14 +02:00

I should add, I'm not convinced that the core issue is actually a problem because we already change out the icon on the menu to be the current selection. In other words a new user can learn what editor is active by what icon is displayed.

Please keep in mind that a new user is not informed at any point what each editor is. Usually this is not a problem since usually windows have their name in a tab above them is software, and these names guide the user through the program:

(This screenshot is from Godot which is open source, so it should be okay to post it here)

Blender doesn't do that, and doesn't even indicate the editor type in the editor chooser drop-down menu (which is itself hard to find). The only way is icon-comparing mental gymnastics - it's not hard, but each such thing adds up to the general program's inaccessibility.

>I should add, I'm not convinced that the core issue is actually a problem because we already change out the icon on the menu to be the current selection. In other words a new user can learn what editor is active by what icon is displayed. Please keep in mind that a new user is not informed at any point what each editor is. Usually this is not a problem since usually windows have their name in a tab above them is software, and these names guide the user through the program: ![shot_150909_192346.png](https://archive.blender.org/developer/F231760/shot_150909_192346.png) *(This screenshot is from Godot which is open source, so it should be okay to post it here)* Blender doesn't do that, and doesn't even indicate the editor type in the editor chooser drop-down menu (which is itself hard to find). The only way is icon-comparing mental gymnastics - it's not hard, but each such thing adds up to the general program's inaccessibility.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Highlight active item in pop-up menu (eg: Editor Type) #45643