Skin modifier root exploit #45669

Closed
opened 2015-08-04 01:00:32 +02:00 by Karja Krähwald · 9 comments

System Information
Windows 7 64, GTX 980

Blender Version
Broken: c27589e + 00857be

Short description of error
There is an exploit that allows to create more than 1 root on a connected surface with the skin modifier.

Wiki says for skin modifiers root:

Each set of connected vertices should have one root node. Mark Root enforces the one-root per set rule, so it is not necessary to manually unmark roots.

Since an exploit is sort of a bug, I think its not wrong to report it.
Its behaviour is definitely not intended - one-root per set rule is broken.
But I also want to point out that this "bug" is quite friendly and useful for modeling.
Please take a look in the file.

Exact steps for others to reproduce the error
SkinModRootExploit.blend

**System Information** Windows 7 64, GTX 980 **Blender Version** Broken: c27589e + 00857be **Short description of error** There is an exploit that allows to create more than 1 root on a connected surface with the skin modifier. Wiki says for skin modifiers root: > Each set of connected vertices should have one root node. Mark Root enforces the one-root per set rule, so it is not necessary to manually unmark roots. Since an exploit is sort of a bug, I think its not wrong to report it. Its behaviour is definitely not intended - one-root per set rule is broken. But I also want to point out that this "bug" is quite friendly and useful for modeling. Please take a look in the file. **Exact steps for others to reproduce the error** [SkinModRootExploit.blend](https://archive.blender.org/developer/F218551/SkinModRootExploit.blend)

Changed status to: 'Open'

Changed status to: 'Open'

Added subscriber: @karja

Added subscriber: @karja

Added subscribers: @mont29, @ideasman42, @Sergey

Added subscribers: @mont29, @ideasman42, @Sergey

@ideasman42, @mont29 any ideas here?

@ideasman42, @mont29 any ideas here?

So basically, we should be able to have several roots per mesh, as long as we only have one root per mesh 'island'… Does make sense to me, but will let @ideasman42 decide here, afaik he maintains that modifier.

So basically, we should be able to have several roots per mesh, as long as we only have one root per mesh 'island'… Does make sense to me, but will let @ideasman42 decide here, afaik he maintains that modifier.

Actually, to be precise, user here want to be able to define roots for 'fake' islands generated by hidden geometry… So on second thought, not sure we want to support that. Which also means we should check when merging different islands of a same mesh (or different meshes), that we only keep one root… Meh, this is serious corner-case. :|

Actually, to be precise, user here want to be able to define roots for 'fake' islands generated by hidden geometry… So on second thought, not sure we want to support that. Which also means we should check when merging different islands of a same mesh (or different meshes), that we only keep one root… Meh, this is serious corner-case. :|

I was not sure where to put this. I guess it looks way more like a feature request, but I found it very surprising or contradictary that the modifier is still working properly with multiple roots, although it deletes all previous with the root button.

I was not sure where to put this. I guess it looks way more like a feature request, but I found it very surprising or contradictary that the modifier is still working properly with multiple roots, although it deletes all previous with the root button.

Changed status from 'Open' to: 'Archived'

Changed status from 'Open' to: 'Archived'
Campbell Barton self-assigned this 2015-08-29 06:44:47 +02:00

Hi @karja, I see you put quite some effort into this report,

On checking the use-case, its really quite obscure that you would choose to hide some parts of geometry - just so you can cause an island - in what is not initially an island. (using the mask modifier).
While there would undoubtedly be some use case for this. It seems rather contrived.

We could drop the requirement and allow multiple roots on a single mesh island... but this is going to cause problems (odd behavior at least) as well.

So I'm going to close this bug, currently this is working as intended.

Hi @karja, I see you put quite some effort into this report, On checking the use-case, its really quite obscure that you would choose to hide some parts of geometry - just so you can cause an island - in what is not initially an island. (using the mask modifier). While there would undoubtedly be some use case for this. It seems rather contrived. We could drop the requirement and allow multiple roots on a single mesh island... but this is going to cause problems (odd behavior at least) as well. So I'm going to close this bug, currently this is working as intended.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#45669
No description provided.