Inset: VCol not correctly initiated for new vertices #45954

New Issue

João Pereira Lemos Costa · 2015-08-29T20:08:27+02:00

João Pereira Lemos Costa commented

2015-08-29 20:08:27 +02:00

System Information
Windows 10, NVidia GeForce GTX 765M

Blender Version
Broken: (example: 2.69.7 4b206af, see splash screen)
Worked: (optional)

Short description of error

After an inset the normals of the surface start acting weird, having shadows where it's not suposed to.

This only happens when insetingn though, and when creating geometry with extrude or any other tool this doesn't happen:

Further more, I can clean the results and make the shadows disappear by removing the edges that hold the faces in the region together and recreating the faces, like this:

But new face is in contact with one "broken" face when created it gives even wronger looking results

Haven't been able to reproduce it in any other project so I don't know if its a proper bug or something I've done through the modeling processing.

Exact steps for others to reproduce the error

Boat.blend

Selecting at least three faces
Inseting them

**System Information** Windows 10, NVidia GeForce GTX 765M **Blender Version** Broken: (example: 2.69.7 4b206af, see splash screen) Worked: (optional) **Short description of error** After an inset the normals of the surface start acting weird, having shadows where it's not suposed to. ![2015-08-29_19-45-31.png](https://archive.blender.org/developer/F229018/2015-08-29_19-45-31.png) ![2015-08-29_19-46-39.png](https://archive.blender.org/developer/F229017/2015-08-29_19-46-39.png) This only happens when insetingn though, and when creating geometry with extrude or any other tool this doesn't happen: ![2015-08-29_19-46-54.png](https://archive.blender.org/developer/F229015/2015-08-29_19-46-54.png) Further more, I can clean the results and make the shadows disappear by removing the edges that hold the faces in the region together and recreating the faces, like this: ![2015-08-29_20-01-38.png](https://archive.blender.org/developer/F229023/2015-08-29_20-01-38.png) ![2015-08-29_20-00-39.png](https://archive.blender.org/developer/F229024/2015-08-29_20-00-39.png) But new face is in contact with one "broken" face when created it gives even wronger looking results ![2015-08-29_19-47-36.png](https://archive.blender.org/developer/F229016/2015-08-29_19-47-36.png) Haven't been able to reproduce it in any other project so I don't know if its a proper bug or something I've done through the modeling processing. **Exact steps for others to reproduce the error** [Boat.blend](https://archive.blender.org/developer/F229028/Boat.blend) 1) Selecting at least three faces 2) Inseting them

João Pereira Lemos Costa commented

2015-08-29 20:08:27 +02:00

Changed status to: 'Open'

João Pereira Lemos Costa commented

2015-08-29 20:08:27 +02:00

Added subscriber: @jpereira

João Pereira Lemos Costa commented

2015-08-29 20:41:20 +02:00

Sorry for forgetting the version:

2.75a c27589e

Sorry for forgetting the version: 2.75a c27589e

Bastien Montagne commented

2015-08-29 21:41:04 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2015-08-29 21:41:04 +02:00

This is not normals, but vertex colors, which does not get correctly initiated (or even better, interpolated?) it seems…

Bastien Montagne changed title from ~~Normals weird shading after inset~~ to Inset: VCol not correctly initiated for new vertices

2015-08-29 21:41:55 +02:00

Campbell Barton was assigned by Bastien Montagne

2015-08-29 22:23:46 +02:00

Bastien Montagne commented

2015-08-29 22:23:46 +02:00

Added subscriber: @ideasman42

Bastien Montagne commented

2015-08-29 22:23:46 +02:00

Issue is actually rather simple - interpolation as done in bm_loop_customdata_merge() cannot work well with char-based data, like CD_MLOOPCOL (a = a + b will easily overflow…).

@ideasman42 quick and dirty fix would be to do a = a * 0.5; b = b * 0.5; a = a + b; b = a; instead. Other solution would be to use CustomData_data_mix_value instead of lower-level add/multiply… Will let you decide what's best here.

Issue is actually rather simple - interpolation as done in `bm_loop_customdata_merge()` cannot work well with char-based data, like `CD_MLOOPCOL` (`a = a + b` will easily overflow…). @ideasman42 quick and dirty fix would be to do `a = a * 0.5; b = b * 0.5; a = a + b; b = a;` instead. Other solution would be to use `CustomData_data_mix_value` instead of lower-level add/multiply… Will let you decide what's best here.

blender-admin commented

2015-08-31 18:51:30 +02:00

This issue was referenced by 705776db1f

This issue was referenced by 705776db1fbaa5a7563d7efae89f0c984afdea6d

Campbell Barton commented

2015-08-31 18:57:03 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2015-08-31 18:57:03 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Inset: VCol not correctly initiated for new vertices #45954