world preview
Closed, ResolvedPublic

Description

Blender Version
Broken: (all)
Worked: (none)

Short description of error




Exact steps for others to reproduce the error

open, and go to world vontext menu - we will see unneed texture in world preview
change anything - we will see update and proper world preview

Related Objects

Mentioned Here
P317 Fix T46624
Alexey (Inwader77) updated the task description. (Show Details)
Alexey (Inwader77) raised the priority of this task from to Needs Triage.
Alexey (Inwader77) set Type to Bug.
Alexey (Inwader77) added a comment.EditedOct 28 2015, 6:40 PM

and else, if we add texture for brush and go to world preview - working properly
but if we switch on ramp mode for this texture, and go to world preciew - working with bug
if we add texture for world and switch off all influence, and go to world preview - working with bug

Developer note:

That's a bit tricky one to solve without adding complexity around sbuts->preview and without adding per-context type preview render. Some simple solution is possible tho:

1diff --git a/source/blender/makesrna/intern/rna_space.c b/source/blender/makesrna/intern/rna_space.c
2index df5bbe8..52b84fa 100644
3--- a/source/blender/makesrna/intern/rna_space.c
4+++ b/source/blender/makesrna/intern/rna_space.c
5@@ -1102,6 +1102,14 @@ static EnumPropertyItem *rna_SpaceProperties_context_itemf(bContext *UNUSED(C),
6​ return item;
7​ }
8
9+static void rna_SpaceProperties_context_update(Main *UNUSED(bmain), Scene *UNUSED(scene), PointerRNA *ptr)
10+{
11+ SpaceButs *sbuts = (SpaceButs *)(ptr->data);
12+ if (ELEM(sbuts->mainb, BCONTEXT_WORLD, BCONTEXT_MATERIAL, BCONTEXT_TEXTURE)) {
13+ sbuts->preview = 1;
14+ }
15+}
16+
17​ static void rna_SpaceProperties_align_set(PointerRNA *ptr, int value)
18​ {
19​ SpaceButs *sbuts = (SpaceButs *)(ptr->data);
20@@ -2845,7 +2853,7 @@ static void rna_def_space_buttons(BlenderRNA *brna)
21​ RNA_def_property_enum_items(prop, buttons_context_items);
22​ RNA_def_property_enum_funcs(prop, NULL, "rna_SpaceProperties_context_set", "rna_SpaceProperties_context_itemf");
23​ RNA_def_property_ui_text(prop, "Context", "Type of active data to display and edit");
24- RNA_def_property_update(prop, NC_SPACE | ND_SPACE_PROPERTIES, NULL);
25+ RNA_def_property_update(prop, NC_SPACE | ND_SPACE_PROPERTIES, "rna_SpaceProperties_context_update");
26
27​ prop = RNA_def_property(srna, "align", PROP_ENUM, PROP_NONE);
28​ RNA_def_property_enum_sdna(prop, NULL, "align");

@Campbell Barton (campbellbarton), do you have strong opinion here?