Action editor key frames not displaying sometimes #46649

New Issue

Viktor · 2015-10-30T21:38:36+01:00

Viktor commented

2015-10-30 21:38:36 +01:00

Sometimes when working with multiply animations and switching through them in the action editor. The Keyframes stop displaying for certain action.
When the Panel with the action editor View is removed and added again, the displaying is working again.
This bug was seen in Version 2.76 and daily Build from 10/30/2015.

Error:

Fixed after closing and opening action editor view

My Project without Mesh. Bug is seen in walk_back_cycle action.
animation_editor_error_project.blend

This bug is very annoying in my workflow.

Greetings and thank you for your work!

Sometimes when working with multiply animations and switching through them in the action editor. The Keyframes stop displaying for certain action. When the Panel with the action editor View is removed and added again, the displaying is working again. This bug was seen in Version 2.76 and daily Build from 10/30/2015. Error: ![action_editor_display_missing_error.png](https://archive.blender.org/developer/F248574/action_editor_display_missing_error.png) Fixed after closing and opening action editor view ![action_editor_display_missing_error_after_panel_recreate.png](https://archive.blender.org/developer/F248575/action_editor_display_missing_error_after_panel_recreate.png) My Project without Mesh. Bug is seen in walk_back_cycle action. [animation_editor_error_project.blend](https://archive.blender.org/developer/F248581/animation_editor_error_project.blend) This bug is very annoying in my workflow. Greetings and thank you for your work!

Viktor commented

2015-10-30 21:38:36 +01:00

Changed status to: 'Open'

Viktor commented

2015-10-30 21:38:36 +01:00

Added subscriber: @melenberg.v

Julian Eisel commented

2015-10-30 21:58:48 +01:00

Added subscriber: @JulianEisel

Julian Eisel commented

2015-10-30 21:58:48 +01:00

Please don't set priority on you own, this should be handled by devs.

Joshua Leung commented

2015-10-31 01:32:27 +01:00

Added subscriber: @JoshuaLeung

Joshua Leung commented

2015-10-31 01:32:27 +01:00

From the screenshots, it looks like a case of the view being scrolled all the way down (see scrollbar on the far right), which can happen when the previous action had more channels than the current one does.

It should be a matter of ensuring that the view2d gets reset in these cases, though this is complicated by not actually knowing how large the new set of channels is until they've been drawn once.

From the screenshots, it looks like a case of the view being scrolled all the way down (see scrollbar on the far right), which can happen when the previous action had more channels than the current one does. It should be a matter of ensuring that the view2d gets reset in these cases, though this is complicated by not actually knowing how large the new set of channels is until they've been drawn once.

Bastien Montagne commented

2016-01-22 15:28:14 +01:00

Added subscriber: @mont29

Julian Eisel was assigned by Bastien Montagne

2016-01-22 15:28:14 +01:00

Bastien Montagne commented

2016-01-22 15:28:14 +01:00

Julian, we are after release now, care to handle this one? ;)

Julian Eisel commented

2016-04-20 00:27:19 +02:00

Something like this would work: P351: Experiment for #46649

diff --git a/source/blender/editors/include/UI_view2d.h b/source/blender/editors/include/UI_view2d.h
index 4caacb6..3d8d378 100644
--- a/source/blender/editors/include/UI_view2d.h
+++ b/source/blender/editors/include/UI_view2d.h
@@ -231,7 +231,7 @@ void UI_view2d_text_cache_draw(struct ARegion *ar);
 void ED_operatortypes_view2d(void);
 void ED_keymap_view2d(struct wmKeyConfig *keyconf);
 
-void UI_view2d_smooth_view(struct bContext *C, struct ARegion *ar,
+void UI_view2d_smooth_view(const struct bContext *C, struct ARegion *ar,
                            const struct rctf *cur, const int smooth_viewtx);
 #define UI_MARKER_MARGIN_Y (42 * UI_DPI_FAC)
 
diff --git a/source/blender/editors/interface/view2d_ops.c b/source/blender/editors/interface/view2d_ops.c
index f60fed3..cb52b77 100644
--- a/source/blender/editors/interface/view2d_ops.c
+++ b/source/blender/editors/interface/view2d_ops.c
@@ -1420,7 +1420,7 @@ static float smooth_view_rect_to_fac(const rctf *rect_a, const rctf *rect_b)
 /* will start timer if appropriate */
 /* the arguments are the desired situation */
 void UI_view2d_smooth_view(
-        bContext *C, ARegion *ar,
+        const bContext *C, ARegion *ar,
         const rctf *cur, const int smooth_viewtx)
 {
        wmWindowManager *wm = CTX_wm_manager(C);
diff --git a/source/blender/editors/space_action/action_edit.c b/source/blender/editors/space_action/action_edit.c
index b69547b..0520159 100644
--- a/source/blender/editors/space_action/action_edit.c
+++ b/source/blender/editors/space_action/action_edit.c
@@ -1763,3 +1763,21 @@ void ACTION_OT_mirror(wmOperatorType *ot)
 }
 
 /* ************************************************************************** */
+/* NON-OPERATOR STUFF */
+
+void action_view_ensure(const bContext *C, ARegion *ar, SpaceAction *saction)
+{
+       static bAction *last_action = NULL;
+
+       if (!last_action || last_action != saction->action) { /* view has just been initialized or changed */
+               if (!ar->v2d.sms && ar->v2d.cur.ymax < ar->v2d.tot.ymin) {
+                       rctf rect = ar->v2d.cur;
+                       rect.ymin = ar->v2d.tot.ymin;
+                       rect.ymax = rect.ymin + ar->winy;
+
+                       UI_view2d_smooth_view(C, ar, &rect, U.smooth_viewtx);
+               }
+               last_action = saction->action;
+       }
+}
+
diff --git a/source/blender/editors/space_action/action_intern.h b/source/blender/editors/space_action/action_intern.h
index 17f1f40..b88d3d7 100644
--- a/source/blender/editors/space_action/action_intern.h
+++ b/source/blender/editors/space_action/action_intern.h
@@ -129,7 +129,9 @@ enum eActKeys_Mirror_Mode {
        ACTKEYS_MIRROR_XAXIS,
        ACTKEYS_MIRROR_MARKER,
 };
-       
+
+void action_view_ensure(const struct bContext *C, struct ARegion *ar, struct SpaceAction *saction);
+
 /* ***************************************** */
 /* action_ops.c */
 void action_operatortypes(void);
diff --git a/source/blender/editors/space_action/space_action.c b/source/blender/editors/space_action/space_action.c
index 53c5a00..c444305 100644
--- a/source/blender/editors/space_action/space_action.c
+++ b/source/blender/editors/space_action/space_action.c
@@ -216,6 +216,8 @@ static void action_main_region_draw(const bContext *C, ARegion *ar)
        scrollers = UI_view2d_scrollers_calc(C, v2d, unit, V2D_GRID_CLAMP, V2D_ARG_DUMMY, V2D_ARG_DUMMY);
        UI_view2d_scrollers_draw(C, v2d, scrollers);
        UI_view2d_scrollers_free(scrollers);
+
+       action_view_ensure(C, ar, saction);
 }
 
 /* add handlers, stuff you only do once or on area/region changes */

Ugly, but it works ;)
It's only checking vertical offset currently, could add for horizontal too.

Something like this would work: [P351: Experiment for #46649](https://archive.blender.org/developer/P351.txt) ``` diff --git a/source/blender/editors/include/UI_view2d.h b/source/blender/editors/include/UI_view2d.h index 4caacb6..3d8d378 100644 --- a/source/blender/editors/include/UI_view2d.h +++ b/source/blender/editors/include/UI_view2d.h @@ -231,7 +231,7 @@ void UI_view2d_text_cache_draw(struct ARegion *ar); void ED_operatortypes_view2d(void); void ED_keymap_view2d(struct wmKeyConfig *keyconf); -void UI_view2d_smooth_view(struct bContext *C, struct ARegion *ar, +void UI_view2d_smooth_view(const struct bContext *C, struct ARegion *ar, const struct rctf *cur, const int smooth_viewtx); #define UI_MARKER_MARGIN_Y (42 * UI_DPI_FAC) diff --git a/source/blender/editors/interface/view2d_ops.c b/source/blender/editors/interface/view2d_ops.c index f60fed3..cb52b77 100644 --- a/source/blender/editors/interface/view2d_ops.c +++ b/source/blender/editors/interface/view2d_ops.c @@ -1420,7 +1420,7 @@ static float smooth_view_rect_to_fac(const rctf *rect_a, const rctf *rect_b) /* will start timer if appropriate */ /* the arguments are the desired situation */ void UI_view2d_smooth_view( - bContext *C, ARegion *ar, + const bContext *C, ARegion *ar, const rctf *cur, const int smooth_viewtx) { wmWindowManager *wm = CTX_wm_manager(C); diff --git a/source/blender/editors/space_action/action_edit.c b/source/blender/editors/space_action/action_edit.c index b69547b..0520159 100644 --- a/source/blender/editors/space_action/action_edit.c +++ b/source/blender/editors/space_action/action_edit.c @@ -1763,3 +1763,21 @@ void ACTION_OT_mirror(wmOperatorType *ot) } /* ************************************************************************** */ +/* NON-OPERATOR STUFF */ + +void action_view_ensure(const bContext *C, ARegion *ar, SpaceAction *saction) +{ + static bAction *last_action = NULL; + + if (!last_action || last_action != saction->action) { /* view has just been initialized or changed */ + if (!ar->v2d.sms && ar->v2d.cur.ymax < ar->v2d.tot.ymin) { + rctf rect = ar->v2d.cur; + rect.ymin = ar->v2d.tot.ymin; + rect.ymax = rect.ymin + ar->winy; + + UI_view2d_smooth_view(C, ar, &rect, U.smooth_viewtx); + } + last_action = saction->action; + } +} + diff --git a/source/blender/editors/space_action/action_intern.h b/source/blender/editors/space_action/action_intern.h index 17f1f40..b88d3d7 100644 --- a/source/blender/editors/space_action/action_intern.h +++ b/source/blender/editors/space_action/action_intern.h @@ -129,7 +129,9 @@ enum eActKeys_Mirror_Mode { ACTKEYS_MIRROR_XAXIS, ACTKEYS_MIRROR_MARKER, }; - + +void action_view_ensure(const struct bContext *C, struct ARegion *ar, struct SpaceAction *saction); + /* ***************************************** */ /* action_ops.c */ void action_operatortypes(void); diff --git a/source/blender/editors/space_action/space_action.c b/source/blender/editors/space_action/space_action.c index 53c5a00..c444305 100644 --- a/source/blender/editors/space_action/space_action.c +++ b/source/blender/editors/space_action/space_action.c @@ -216,6 +216,8 @@ static void action_main_region_draw(const bContext *C, ARegion *ar) scrollers = UI_view2d_scrollers_calc(C, v2d, unit, V2D_GRID_CLAMP, V2D_ARG_DUMMY, V2D_ARG_DUMMY); UI_view2d_scrollers_draw(C, v2d, scrollers); UI_view2d_scrollers_free(scrollers); + + action_view_ensure(C, ar, saction); } /* add handlers, stuff you only do once or on area/region changes */ ``` Ugly, but it works ;) It's only checking vertical offset currently, could add for horizontal too.

Julian Eisel was unassigned by Dalai Felinto

2019-12-23 16:37:23 +01:00

Sybren A. Stüvel commented

2020-01-06 15:43:09 +01:00

Added subscriber: @dr.sybren

Sybren A. Stüvel commented

2020-01-06 15:43:09 +01:00

This is a known architecture/design limitation of the GUI, so marking as Known Issue.

@JulianEisel IIRC we've had more list panels auto-scroll into view. Do you think such an approach could be easily applied here too? If it is, please include this in your planning.

This is a known architecture/design limitation of the GUI, so marking as Known Issue. @JulianEisel IIRC we've had more list panels auto-scroll into view. Do you think such an approach could be easily applied here too? If it is, please include this in your planning.

Julian Eisel was assigned by Sybren A. Stüvel

2020-01-06 15:44:41 +01:00

Sybren A. Stüvel commented

2020-01-06 15:44:41 +01:00

PS: if this is not something easy/quick to do, feel free to close it as architecture/design limitation.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Action editor key frames not displaying sometimes #46649