CMake: proposal to conditionally link using generator expressions #46725
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#46725
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Motivation
Currently we have a quite kludgy solution for linking libraries, where we manually order library linking when building
blender
orblenderplayer
.This was originally done because library linking needed to conditionally use a stub, or the real library (for
blenderplayer
).This task proposes to do things the correct way and use the
target_link_libraries
command (target-scoped conditions).See: https://developer.blender.org/diffusion/B/browse/master/build_files/cmake/macros.cmake;56933373e29e1ed076bfb8ab4b50c447e66f00ff$497
The problem with this is we are having to guess the right linking order - for more complex cases, sometimes including the library multiple times... until it works,
Its quite haphazard and kludgey.
Its also not clear when looking at cmake files what links to what (though the includes give a reasonable explanation).
Solution
Modern CMake versions contain more APIs for target-scoped conditions and features. For example, we can link conditionally to one library or another depending on a property of the target being linked.
With C++ files with trivial implementations:
When running ninja we see:
and as the last two lines show, we have linked to the libbf_editors or the libstubs as desired.
This could be used to simplify the cmake buildsystem somewhat.
So we could use a command for eg:
Changed status to: 'Open'
Added subscriber: @steveire
Link conditionally with cmake generator expressionsto CMake: proposal to conditionally link using generator expressionsNote, I had a patch for listing libs in each CMake file (along with source and includes), committed to a temp branch.
https://developer.blender.org/rBS71a1c7ab1d316bea90f19b9061af0d50543e50e0
Added subscriber: @hewi
Added subscriber: @ideasman42
Changed status from 'Open' to: 'Resolved'
Removed subscriber: @hewi