Some instances are not rendered to scale one 0 #46937

New Issue

Luis Miguel Pérez González · 2015-12-07T16:06:51+01:00

2015-12-07 16:06:51 +01:00

System Information
CPU: Intel Core i7-2600 3.40GHz
RAM: 16 GB
GFX: nVidia Geforce GTX 560 Ti
OS: Windows 7 Professional 64bits

Blender Version
Broken: 2.76b Hash: f337fea
Worked: (all win64) 2.76-rc3, 2.75a, 2.74rc2, 2.73a, 2.72b, 2.71, 2.70a, 2.69

  Note: in versions 2.71, 2.70a and 2.69 using the keyboard shortcut "s + 0" scale x, y, z 0.0001 (not 0)

Short description of error
To scale the last instance created to 0, the other instances (the same group) not be rendered.
*Anomaly detected: to put 2 values of the scale 0.0001, and the other to 0, only a few faces of other instances they are rendered. (scale example: x = 0.0001, y = 0.0001, z = 0)

Exact steps for others to reproduce the error

Create a group of geometry (ctrl g)
Create multiple instances of the group
Scale the last instance 0
Render the scene (the instance are not rendered)

last_instance_scale_0.blend

**System Information** CPU: Intel Core i7-2600 3.40GHz RAM: 16 GB GFX: nVidia Geforce GTX 560 Ti OS: Windows 7 Professional 64bits **Blender Version** Broken: 2.76b Hash: f337fea Worked: (all win64) 2.76-rc3, 2.75a, 2.74rc2, 2.73a, 2.72b, 2.71, 2.70a, 2.69 ``` Note: in versions 2.71, 2.70a and 2.69 using the keyboard shortcut "s + 0" scale x, y, z 0.0001 (not 0) ``` **Short description of error** To scale the last instance created to 0, the other instances (the same group) not be rendered. *Anomaly detected: to put 2 values of the scale 0.0001, and the other to 0, only a few faces of other instances they are rendered. (scale example: x = 0.0001, y = 0.0001, z = 0) **Exact steps for others to reproduce the error** - Create a group of geometry (ctrl g) - Create multiple instances of the group - Scale the last instance 0 - Render the scene (the instance are not rendered) [last_instance_scale_0.blend](https://archive.blender.org/developer/F264128/last_instance_scale_0.blend)

Luis Miguel Pérez González commented

2015-12-07 16:06:51 +01:00

Changed status to: 'Open'

Luis Miguel Pérez González commented

2015-12-07 16:06:51 +01:00

Added subscriber: @Wilson-14

Sergey Sharybin commented

2015-12-08 09:48:40 +01:00

Added subscriber: @Sergey

Sergey Sharybin self-assigned this 2015-12-08 09:48:41 +01:00

Sergey Sharybin commented

2015-12-08 09:48:41 +01:00

I'm not sure how this is possible to work in 2.72-2.76 actually, in own tests it never works since 2.72. The regression in behavior is caused by the following commit 1526620.

it is just a Blender Internal render code which isn't compatible with such kind of instancing. This depends on the order of objects listed in the scene and happens when "origin" object is created from the group scaled to zero. In this case re-scaling ti to non-zero group size does not work.

Will try to improve the instancing code, but it's already quite fragile so it might be just considered a TODO.

I'm not sure how this is possible to work in 2.72-2.76 actually, in own tests it never works since 2.72. The regression in behavior is caused by the following commit 1526620. it is just a Blender Internal render code which isn't compatible with such kind of instancing. This depends on the order of objects listed in the scene and happens when "origin" object is created from the group scaled to zero. In this case re-scaling ti to non-zero group size does not work. Will try to improve the instancing code, but it's already quite fragile so it might be just considered a TODO.

Sergey Sharybin commented

2015-12-08 10:34:37 +01:00

Added subscriber: @ideasman42

Sergey Sharybin commented

2015-12-08 10:34:37 +01:00

Developer note:

Tried to make it so render object is created with unit matrix and being instanced by the instancing code. This turned up to be not so much striaghtforward because of how object data is stored (it's applying transform) and how other instances calculates offset matricies (relative to the original instance). Don't think running into such complexity is really something to happen as a bugfix, more like something what belongs to more major instancing code refactor in Blender Internal.

However, we might consider the following quick solution:

P298: Fix #46937

diff --git a/source/blender/render/intern/source/convertblender.c b/source/blender/render/intern/source/convertblender.c
index 846255b..94dbce2 100644
--- a/source/blender/render/intern/source/convertblender.c
+++ b/source/blender/render/intern/source/convertblender.c
@@ -5097,9 +5097,16 @@ static void database_init_objects(Render *re, unsigned int renderlay, int nolamp
 							}
 						}
 
-						if (obi==NULL)
-							/* can't instance, just create the object */
-							init_render_object(re, obd, ob, dob, dob_extra->obmat, timeoffset);
+						if (obi==NULL) {
+							/* Can't instance, just create the object.
+							 * Only do this if the instance size is not zero, otherwise
+							 * we'll have major issue with instancing the same render
+							 * object by other groups. See #46937 for the details.
+							 */
+							if (fabsf(mat4_to_scale(obd->obmat)) >= 1e-7f) {
+								init_render_object(re, obd, ob, dob, dob_extra->obmat, timeoffset);
+							}
+						}
 						
 						if (dob->type != OB_DUPLIGROUP) {
 							obd->flag |= OB_DONE;

Basically, we skip instances if they're too small and can't be visible anyway. Could break some corner cases perhaps.

@ideasman42, do you have strong opinion here?

Developer note: Tried to make it so render object is created with unit matrix and being instanced by the instancing code. This turned up to be not so much striaghtforward because of how object data is stored (it's applying transform) and how other instances calculates offset matricies (relative to the original instance). Don't think running into such complexity is really something to happen as a bugfix, more like something what belongs to more major instancing code refactor in Blender Internal. However, we might consider the following quick solution: [P298: Fix #46937](https://archive.blender.org/developer/P298.txt) ``` diff --git a/source/blender/render/intern/source/convertblender.c b/source/blender/render/intern/source/convertblender.c index 846255b..94dbce2 100644 --- a/source/blender/render/intern/source/convertblender.c +++ b/source/blender/render/intern/source/convertblender.c @@ -5097,9 +5097,16 @@ static void database_init_objects(Render *re, unsigned int renderlay, int nolamp } } - if (obi==NULL) - /* can't instance, just create the object */ - init_render_object(re, obd, ob, dob, dob_extra->obmat, timeoffset); + if (obi==NULL) { + /* Can't instance, just create the object. + * Only do this if the instance size is not zero, otherwise + * we'll have major issue with instancing the same render + * object by other groups. See #46937 for the details. + */ + if (fabsf(mat4_to_scale(obd->obmat)) >= 1e-7f) { + init_render_object(re, obd, ob, dob, dob_extra->obmat, timeoffset); + } + } if (dob->type != OB_DUPLIGROUP) { obd->flag |= OB_DONE; ``` Basically, we skip instances if they're too small and can't be visible anyway. Could break some corner cases perhaps. @ideasman42, do you have strong opinion here?

Luis Miguel Pérez González commented

2015-12-08 12:12:21 +01:00

Thank you for answering so quickly.
I think that any solution would be useful.
Make elements appear and disappear through scale is a useful resource in work "motion graphics". To have "instances" speeds up the work.

(sorry for my bad English)

Thank you for answering so quickly. I think that any solution would be useful. Make elements appear and disappear through scale is a useful resource in work "motion graphics". To have "instances" speeds up the work. (sorry for my bad English)

Germano Cavalcante commented

2015-12-10 02:38:13 +01:00

Added subscriber: @mano-wii

Sergey Sharybin commented

2016-01-04 20:38:38 +01:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2016-01-04 20:38:38 +01:00

Sergey Sharybin commented

2016-01-04 20:38:38 +01:00

Unfortunately, the proposed patch wouldn't work well -- it wouldn't render halos in the same way as they are in current Blender (scaling object to zero will still render halo on it's center, i.e.).

Here's another idea which kind of implements idea of having object in the database created with unit matrix:

P309: Another patch for #46937

diff --git a/source/blender/render/intern/source/convertblender.c b/source/blender/render/intern/source/convertblender.c
index 69e45fe..71f539d 100644
--- a/source/blender/render/intern/source/convertblender.c
+++ b/source/blender/render/intern/source/convertblender.c
@@ -4650,6 +4650,10 @@ static void add_render_object(Render *re, Object *ob, Object *par, DupliObject *
 
 	/* one render object for the data itself */
 	if (allow_render) {
+		float obmat- [x][4];
+		copy_m4_m4(obmat, ob->obmat);
+		unit_m4(ob->obmat);
+
 		obr= RE_addRenderObject(re, ob, par, index, 0, ob->lay);
 		if ((dob && !dob->animated) || (ob->transflag & OB_RENDER_DUPLI)) {
 			obr->flag |= R_INSTANCEABLE;
@@ -4659,7 +4663,7 @@ static void add_render_object(Render *re, Object *ob, Object *par, DupliObject *
 
 		/* only add instance for objects that have not been used for dupli */
 		if (!(ob->transflag & OB_RENDER_DUPLI)) {
-			obi = RE_addRenderInstance(re, obr, ob, par, index, 0, NULL, ob->lay, dob);
+			obi = RE_addRenderInstance(re, obr, ob, par, index, 0, obmat, ob->lay, dob);
 			if (dob) set_dupli_tex_mat(re, obi, dob, omat);
 		}
 		else
@@ -4670,6 +4674,8 @@ static void add_render_object(Render *re, Object *ob, Object *par, DupliObject *
 			if (ma && ma->material_type == MA_TYPE_VOLUME)
 				add_volume(re, obr, ma);
 		}
+
+		copy_m4_m4(ob->obmat, obmat);
 	}
 
 	/* and one render object per particle system */

This is better approach, but is quite hackish in implementation and wouldn't work well for particles, also texture space might be wrong.

Al this requires some more major changes in the render database which are rather a TODO. Meanwhile you can animate renderability/viewport visibility of the object instead. So thanks for the report, but it's now part of TODO (http://wiki.blender.org/index.php/Dev:Source/Development/Todo/Render#Render_Engine)

Unfortunately, the proposed patch wouldn't work well -- it wouldn't render halos in the same way as they are in current Blender (scaling object to zero will still render halo on it's center, i.e.). Here's another idea which kind of implements idea of having object in the database created with unit matrix: [P309: Another patch for #46937](https://archive.blender.org/developer/P309.txt) ```diff diff --git a/source/blender/render/intern/source/convertblender.c b/source/blender/render/intern/source/convertblender.c index 69e45fe..71f539d 100644 --- a/source/blender/render/intern/source/convertblender.c +++ b/source/blender/render/intern/source/convertblender.c @@ -4650,6 +4650,10 @@ static void add_render_object(Render *re, Object *ob, Object *par, DupliObject * /* one render object for the data itself */ if (allow_render) { + float obmat- [x][4]; + copy_m4_m4(obmat, ob->obmat); + unit_m4(ob->obmat); + obr= RE_addRenderObject(re, ob, par, index, 0, ob->lay); if ((dob && !dob->animated) || (ob->transflag & OB_RENDER_DUPLI)) { obr->flag |= R_INSTANCEABLE; @@ -4659,7 +4663,7 @@ static void add_render_object(Render *re, Object *ob, Object *par, DupliObject * /* only add instance for objects that have not been used for dupli */ if (!(ob->transflag & OB_RENDER_DUPLI)) { - obi = RE_addRenderInstance(re, obr, ob, par, index, 0, NULL, ob->lay, dob); + obi = RE_addRenderInstance(re, obr, ob, par, index, 0, obmat, ob->lay, dob); if (dob) set_dupli_tex_mat(re, obi, dob, omat); } else @@ -4670,6 +4674,8 @@ static void add_render_object(Render *re, Object *ob, Object *par, DupliObject * if (ma && ma->material_type == MA_TYPE_VOLUME) add_volume(re, obr, ma); } + + copy_m4_m4(ob->obmat, obmat); } /* and one render object per particle system */ ``` This is better approach, but is quite hackish in implementation and wouldn't work well for particles, also texture space might be wrong. Al this requires some more major changes in the render database which are rather a TODO. Meanwhile you can animate renderability/viewport visibility of the object instead. So thanks for the report, but it's now part of TODO (http://wiki.blender.org/index.php/Dev:Source/Development/Todo/Render#Render_Engine)

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Some instances are not rendered to scale one 0 #46937