Crashes with white balance filter #47156

New Issue

Aaron Carlisle · 2016-01-10T21:24:25+01:00

Aaron Carlisle commented

2016-01-10 21:24:25 +01:00

System Information
Windows 10
Intel HD 4600

Blender Version
Broken: 2.76.5
Worked: N/A

Short description of error
Blender Crashes when adding a white balance to an adjustment layer strip or meta strip.

Exact steps for others to reproduce the error

Add image strip
Add a second image
Add an adjustment layer above them
Add white balance filter to the adjustment layer strip
Re-do using meta strip

**System Information** Windows 10 Intel HD 4600 **Blender Version** Broken: 2.76.5 Worked: N/A **Short description of error** Blender Crashes when adding a white balance to an adjustment layer strip or meta strip. **Exact steps for others to reproduce the error** - Add image strip - Add a second image - Add an adjustment layer above them - Add white balance filter to the adjustment layer strip - Re-do using meta strip

Aaron Carlisle commented

2016-01-10 21:24:25 +01:00

Changed status to: 'Open'

Aaron Carlisle commented

2016-01-10 21:24:25 +01:00

Added subscriber: @Blendify

Thomas Dinges commented

2016-01-10 21:35:15 +01:00

Added subscriber: @ThomasDinges

Thomas Beck was assigned by Thomas Dinges

2016-01-10 21:35:15 +01:00

Thomas Dinges commented

2016-01-10 21:35:15 +01:00

Hey Thomas, can you please check? Afaik you added it. :)

Thomas Beck commented

2016-01-10 22:11:49 +01:00

Will check, but can't promise that I can do much this week (first week after holidays for me ;) )

Thomas Beck commented

2016-01-10 22:16:01 +01:00

Just checked if I can redo it but can't... see

@Blendify Always supply a file to make sure that I can redo it..
@ThomasDinges Did it crash on your side?

Greetings, Thomas

Just checked if I can redo it but can't... see ![WB.png](https://archive.blender.org/developer/F272221/WB.png) @Blendify Always supply a file to make sure that I can redo it.. @ThomasDinges Did it crash on your side? Greetings, Thomas

Campbell Barton commented

2016-01-11 04:52:10 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-01-11 04:52:10 +01:00

Please attach a blend file which fails (including image files).

Campbell Barton commented

2016-01-11 05:11:29 +01:00

Committed likely fix: 60fa2644cb, @Blendify could you confirm?

@plasmasolutions, I noticed the division here can easily perform a divide-by-zero:
https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/seqmodifier.c;b211e4193f2ea1a1cffef6b4b76ae5597922fec2$199-201

It's casting nan to char in premul_float_to_straight_uchar,

Also, even for typical operation, this will cause channels to go above 1.0. For HDR renders this is useful to support,
but probably color correction shouldn't be pushing colors into HDR range?

Committed likely fix: 60fa2644cb, @Blendify could you confirm? @plasmasolutions, I noticed the division here can easily perform a divide-by-zero: https://developer.blender.org/diffusion/B/browse/master/source/blender/blenkernel/intern/seqmodifier.c;b211e4193f2ea1a1cffef6b4b76ae5597922fec2$199-201 It's casting `nan` to `char` in `premul_float_to_straight_uchar`, Also, even for typical operation, this will cause channels to go above 1.0. For HDR renders this is useful to support, but probably color correction shouldn't be pushing colors into HDR range?

Bastien Montagne commented

2016-01-19 14:30:46 +01:00

Added subscriber: @mont29

Bastien Montagne commented

2016-01-19 14:30:46 +01:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-01-19 14:30:46 +01:00

Bastien Montagne commented

2016-01-19 14:30:46 +01:00

Assuming this is fixed for now, we can always reopen if not…

Aaron Carlisle commented

2016-01-19 15:02:21 +01:00

Changed status from 'Resolved' to: 'Archived'

Aaron Carlisle commented

2016-01-19 15:02:21 +01:00

I am still getting a crash but having trouble finding the limiting factor. And the scene is too big to share. I will try to get a backtrace later this week to see if that can show something.

Thomas Beck commented

2016-01-19 23:25:55 +01:00

Added subscriber: @troy_s

Thomas Beck commented

2016-01-19 23:25:55 +01:00

Hi @ideasman42,

writing from Sweden atm. - was urgently sent to a client last week as a programmer drone and therefore just saw your message. HDRs should indeed be able to go above 1.0, completely agree about the division by zero tough, that should be avoided! Do we have an internal division method that catches those cases or should I just do it manually (by never going beneath 0.00001 for every channel for example)?

I'll talk to @troy_s about the color correction as soon as I'm back... unfortunately won't be until Sunday this week.
@Blendify As said, a file (as simple as possible) where I can reproduce issues helps here - if you find something, pack it into a file and upload it.

Greetings, Thomas

Hi @ideasman42, writing from Sweden atm. - was urgently sent to a client last week as a programmer drone and therefore just saw your message. HDRs should indeed be able to go above 1.0, completely agree about the division by zero tough, that should be avoided! Do we have an internal division method that catches those cases or should I just do it manually (by never going beneath 0.00001 for every channel for example)? I'll talk to @troy_s about the color correction as soon as I'm back... unfortunately won't be until Sunday this week. @Blendify As said, a file (as simple as possible) where I can reproduce issues helps here - if you find something, pack it into a file and upload it. Greetings, Thomas

Troy Sobotka commented

2016-01-20 07:04:24 +01:00

I haven't exactly looked at the code, but I'm pretty sure that it isn't a Bradford transform, which could be added later as a toggle.

"but probably color correction shouldn't be pushing colors into HDR range?"

This sort of operation has to be done blind. That is, it should assume that all images fed to it are scene referred, that is, ranging from zero to infinity with no concept of black or white. This aligns with Cycles internal model, and I don't see any adverse issue here?

@ideasman42 do you see an issue I can't? I trust your wizened eyes on these sorts of matters. From a strictly colour transform side, there's not really much here.

I haven't exactly looked at the code, but I'm pretty sure that it isn't a Bradford transform, which could be added later as a toggle. "but probably color correction shouldn't be pushing colors into HDR range?" This sort of operation has to be done blind. That is, it should assume that all images fed to it are scene referred, that is, ranging from zero to infinity with no concept of black or white. This aligns with Cycles internal model, and I don't see any adverse issue here? @ideasman42 do you see an issue I can't? I trust your wizened eyes on these sorts of matters. From a strictly colour transform side, there's not really much here.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crashes with white balance filter #47156