FBX partial animation fix #47397

New Issue

Evan Todd · 2016-02-11T20:09:35+01:00

Evan Todd commented

2016-02-11 20:09:35 +01:00

This patch addresses several issues related to animations which do not key every channel in an armature. These issues only manifest when the "Key All Bones" option is off, which is required for partial animations.

When sampling animations, the armature is not reset when switching from one action to the next. If an action leaves some channels unkeyed, you'll see a pose from the previous action on those channels. This patch resets the armature between actions.
The exported bind pose is whatever pose the armature happens to be in at export time, rather than the T-pose specified in edit mode. Animations that only key certain channels often rely on the bind pose being accurate. This patch resets armatures to the bind pose before exporting.
For single-frame animations (poses), the exporter simplifies all keyframes out of existence, because there is never any change. This patch keeps the first keyframe if it is different from the bind pose.

fbx_partial_animation_fix.diff

This patch addresses several issues related to animations which do not key every channel in an armature. These issues only manifest when the "Key All Bones" option is off, which is required for partial animations. 1) When sampling animations, the armature is not reset when switching from one action to the next. If an action leaves some channels unkeyed, you'll see a pose from the previous action on those channels. This patch resets the armature between actions. 2) The exported bind pose is whatever pose the armature happens to be in at export time, rather than the T-pose specified in edit mode. Animations that only key certain channels often rely on the bind pose being accurate. This patch resets armatures to the bind pose before exporting. 3) For single-frame animations (poses), the exporter simplifies all keyframes out of existence, because there is never any change. This patch keeps the first keyframe if it is different from the bind pose. [fbx_partial_animation_fix.diff](https://archive.blender.org/developer/F282180/fbx_partial_animation_fix.diff)

Evan Todd commented

2016-02-11 20:09:35 +01:00

Changed status to: 'Open'

Evan Todd commented

2016-02-11 20:09:35 +01:00

Added subscriber: @et1337

Bastien Montagne was assigned by Aaron Carlisle

2016-02-11 20:13:14 +01:00

Aaron Carlisle commented

2016-02-11 20:13:14 +01:00

Added subscriber: @Blendify

Evan Todd commented

2016-02-11 20:21:36 +01:00

Quick typo fix to accommodate non-armature animations.

fbx_partial_animation_fix2.diff

My test case:

character.blend

Quick typo fix to accommodate non-armature animations. [fbx_partial_animation_fix2.diff](https://archive.blender.org/developer/F282185/fbx_partial_animation_fix2.diff) My test case: [character.blend](https://archive.blender.org/developer/F282187/character.blend)

Evan Todd commented

2016-02-11 22:11:11 +01:00

Here's a version that also exports components all together, i.e., it exports X, Y, and Z position even if only X position is keyed. Certain pipelines can't handle individual components correctly (I'm using Assimp)

fbx_partial_animation_fix3.diff

Here's a version that also exports components all together, i.e., it exports X, Y, and Z position even if only X position is keyed. Certain pipelines can't handle individual components correctly (I'm using Assimp) [fbx_partial_animation_fix3.diff](https://archive.blender.org/developer/F282204/fbx_partial_animation_fix3.diff)

Bastien Montagne commented

2016-02-11 22:14:34 +01:00

Can you please create a diff? https://developer.blender.org/differential/diff/create/

Would be simpler to review the patch :)

Can you please create a diff? https://developer.blender.org/differential/diff/create/ Would be simpler to review the patch :)

Bastien Montagne commented

2016-02-12 09:33:51 +01:00

Changed status from 'Open' to: 'Archived'

Bastien Montagne closed this issue

2016-02-12 09:33:51 +01:00

Bastien Montagne commented

2016-02-12 09:33:51 +01:00