Error PADPLUSKEY [ latin1 ] #48369

New Issue

Daniel Rivera · 2016-05-07T18:03:53+02:00

Daniel Rivera commented

2016-05-07 18:03:53 +02:00

System Information
Linux familia-pc 4.4.8-1-MANJARO #1 SMP PREEMPT Thu Apr 21 00:21:08 UTC 2016 x86_64 GNU/Linux

Blender Version
Broken: 2.77

Short description of error
[ PADPLUSKEY ] key does not work in the Latin American keyboard

Temporary solution
[ File: wm_event_system.c add line 2942 ]

case GHOST_kKeyUnknown: return PADPLUSKEY;

**System Information** Linux familia-pc 4.4.8-1-MANJARO #1 SMP PREEMPT Thu Apr 21 00:21:08 UTC 2016 x86_64 GNU/Linux **Blender Version** Broken: 2.77 **Short description of error** [ PADPLUSKEY ] key does not work in the Latin American keyboard ![error_plus_key_latin1_mod.png](https://archive.blender.org/developer/F309716/error_plus_key_latin1_mod.png) **Temporary solution** [ File: wm_event_system.c add line 2942 ] + case GHOST_kKeyUnknown: return PADPLUSKEY;

Daniel Rivera commented

2016-05-07 18:03:53 +02:00

Changed status to: 'Open'

Daniel Rivera self-assigned this 2016-05-07 18:03:53 +02:00

Daniel Rivera commented

2016-05-07 18:03:53 +02:00

Added subscriber: @dr2d4

Bastien Montagne commented

2016-05-08 11:11:59 +02:00

Added subscriber: @mont29

Bastien Montagne commented

2016-05-08 11:11:59 +02:00

Can’t confirm this here, switched to EN keyboard layout and still getting correct padplus event.

Note that Ghost converts XKey values to its own in convertXKey() (in GHOST_SystemX11.cpp), you'd rather want to put a print in this func so see which value you get when hitting padplus (x11 define: #define XK_KP_Add 0xffab).

Also, is padplus the only key affected? would expect you'd get same issue with padminus, etc., at least…

Can’t confirm this here, switched to EN keyboard layout and still getting correct padplus event. Note that Ghost converts XKey values to its own in `convertXKey()` (in `GHOST_SystemX11.cpp`), you'd rather want to put a print in this func so see which value you get when hitting padplus (x11 define: `#define XK_KP_Add 0xffab`). Also, is padplus the only key affected? would expect you'd get same issue with padminus, etc., at least…

Daniel Rivera was unassigned by Bastien Montagne

2016-05-08 11:44:33 +02:00

Daniel Rivera commented

2016-05-09 01:47:59 +02:00

Thanks works well by assigning 0x002b the padplus however I think that it should be updated soon since blender loses functionality for the Spanish-speaking without this key

File: GHOST_SystemX11.cpp
+ #define XK_KP_Add 0x002b

Thanks works well by assigning **0x002b** the padplus however I think that it should be updated soon since blender loses functionality for the Spanish-speaking without this key File: GHOST_SystemX11.cpp **+ #define XK_KP_Add 0x002b**

Daniel Rivera commented

2016-05-09 08:09:10 +02:00

Reviewing more detail I found that

On laptop with GNU/Linux and Latin American keyboard:

Emulated NumPad = False

  PADPLUS = ERROR
  PADMINUS = ERROR

Emulated NumPad = True

  PADPLUS = ERROR
  PADMINUS = CORRECT

Reviewing more detail I found that On laptop with GNU/Linux and Latin American keyboard: **Emulated NumPad = False** ``` PADPLUS = ERROR PADMINUS = ERROR ``` **Emulated NumPad = True** ``` PADPLUS = ERROR PADMINUS = CORRECT

Bastien Montagne commented

2016-05-09 09:07:25 +02:00

There is something else going on here, related to your keyboard or (more likely) your Xorg keyboard settings somehow.

0x002b is Xorg keycode for XK_plus, i.e. the plus sign on main keyboard. So if you are getting that value when hitting the numpad plus key, something is wrong imho.

Never the less, GHOST handles the XK_minus but not the XK_plus code, not sure why, sounds suspicious to me too.

There is something else going on here, related to your keyboard or (more likely) your Xorg keyboard settings somehow. `0x002b` is Xorg keycode for `XK_plus`, i.e. the plus sign on *main* keyboard. So if you are getting that value when hitting the numpad plus key, something is wrong imho. Never the less, GHOST handles the `XK_minus` but not the `XK_plus` code, not sure why, sounds suspicious to me too.

Bastien Montagne commented

2016-05-09 09:19:32 +02:00

Hum… in fact, there is no support for XK_plus because in theory there is no keyboard layout with direct access to that key (it’s usually shift-equal).

Now, you mention pad emulation, does it mean you do not have any physical numpad? Also, please try with e.g. a livecd of the latest ubuntu distribution, this really feels like a bad mapping of your keyboard in your OS…

Hum… in fact, there is no support for `XK_plus` because in theory there is no keyboard layout with direct access to that key (it’s usually shift-equal). Now, you mention pad emulation, does it mean you do not have any physical numpad? Also, please try with e.g. a livecd of the latest ubuntu distribution, this really feels like a bad mapping of your keyboard in your OS…

Daniel Rivera commented

2016-05-09 20:07:30 +02:00

The same goes for ubuntu

And my keyboard layout is

The same goes for ubuntu ![ubuntu.png](https://archive.blender.org/developer/F309918/ubuntu.png) And my keyboard layout is ![keyboard.png](https://archive.blender.org/developer/F309920/keyboard.png)

Daniel Rivera commented

2016-05-09 21:04:35 +02:00

The error is in that adds a:

File: GHOST_SystemX11.cpp : GMAP (type, XK_minus, GHOST_kKeyMinus);

but is not added on:

GXMap (type, XK_plus, GHOST_kKeyPlus);

so to activate the numeric keypad Pad Plus does not work on Latin keyboards

Info: keysymdef.h

/*
 * Latin 1
 * (ISO/IEC 8859-1 = Unicode U+0020..U+00FF)
 * Byte 3 = 0
 */

- define XK_plus                          0x002b  /* U+002B PLUS SIGN */
- define XK_minus                         0x002d  /* U+002D HYPHEN-MINUS */

if you add XK_plus keyboard works properly with English and Latin American

The error is in that adds a: **File: GHOST_SystemX11.cpp** : GMAP (type, **XK_minus**, GHOST_kKeyMinus); but is not added on: GXMap (type, **XK_plus**, GHOST_kKeyPlus); so to activate the numeric keypad Pad Plus does not work on Latin keyboards **Info: keysymdef.h** ``` /* * Latin 1 * (ISO/IEC 8859-1 = Unicode U+0020..U+00FF) * Byte 3 = 0 */ - define XK_plus 0x002b /* U+002B PLUS SIGN */ - define XK_minus 0x002d /* U+002D HYPHEN-MINUS */ ``` if you add XK_plus keyboard works properly with English and Latin American

Bastien Montagne commented

2016-05-09 21:49:59 +02:00

Aaaaaaaaaah! that explains a lot!

Those are not padplus/minus at all! those are 'just' plus/minus (padplus/padminus are numpad keys only).

So, didn’t know some keyboard layouts had direct access to plus key (without some modifier like shift), this changes things - guess we'll have to add support for GHOST_kKeyPlus then… Won't change anything to current state though, since this key does not exists for default QWERTY english layout, it won't be used in default keymaps - but at least you''l be able to add it to custom shortcuts.

Note that emulated numpad is something else, not sure how good this is supported by linux (that feature is supposed to generate actual numpad key events, but the way those virtual numpad keys are layed out is totally not tied to the 'regular' keyboard layout).

Aaaaaaaaaah! that explains a lot! Those **are not padplus/minus** at all! those are 'just' plus/minus (padplus/padminus are numpad keys **only**). So, didn’t know some keyboard layouts had direct access to plus key (without some modifier like shift), this changes things - guess we'll have to add support for GHOST_kKeyPlus then… Won't change anything to current state though, since this key does not exists for default QWERTY english layout, it won't be used in default keymaps - but at least you''l be able to add it to custom shortcuts. Note that emulated numpad is something else, not sure how good this is supported by linux (that feature is supposed to generate actual numpad key events, but the way those virtual numpad keys are layed out is totally not tied to the 'regular' keyboard layout).

blender-admin commented

2016-05-10 08:29:03 +02:00

This issue was referenced by ce65fae8f3

This issue was referenced by ce65fae8f32c058ef50eb1a9a0a82472c4a68040

Bastien Montagne commented

2016-05-10 08:31:36 +02:00

Changed status from 'Open' to: 'Resolved'

Bastien Montagne closed this issue

2016-05-10 08:31:36 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Error PADPLUSKEY [ latin1 ] #48369