Measureit by Antonioya (fix current review bugs) #48704

New Issue

Brendon Murphy · 2016-06-22T01:40:56+02:00

Brendon Murphy commented

2016-06-22 01:40:56 +02:00

Hi, This is the task for measureit addon by @antoniov
This addon provider render able measure tools in the 3d view.
BA Thread: http://blenderartists.org/forum/showthread.php?371788-Add-on-v1-6-MeasureIt-measurement-tools
Git hub: https://github.com/Antonioya/blender/tree/master/measureit
File: http://blenderartists.org/forum/showthread.php?371788-Add-on-v1-6-MeasureIt-measurement-tools
Thanks

Hi, This is the task for measureit addon by @antoniov This addon provider render able measure tools in the 3d view. BA Thread: http://blenderartists.org/forum/showthread.php?371788-Add-on-v1-6-MeasureIt-measurement-tools Git hub: https://github.com/Antonioya/blender/tree/master/measureit File: http://blenderartists.org/forum/showthread.php?371788-Add-on-v1-6-MeasureIt-measurement-tools Thanks

Brendon Murphy commented

2016-06-22 01:40:56 +02:00

Changed status to: 'Open'

Brendon Murphy self-assigned this 2016-06-22 01:40:56 +02:00

Brendon Murphy commented

2016-06-22 01:40:56 +02:00

Added subscribers: @BrendonMurphy, @antoniov

Brendon Murphy changed title from ~~Measureit by Antonioya (New Addons Contrib~~ to Measureit by Antonioya (New Addons Contrib)

2016-06-22 01:49:02 +02:00

Brendon Murphy changed title from ~~Measureit by Antonioya (New Addons Contrib)~~ to Measureit by Antonioya (Promote Addons Release)

2016-07-03 11:25:31 +02:00

Brendon Murphy commented

2016-07-26 00:09:17 +02:00

link to contrib: https://developer.blender.org/diffusion/BAC/browse/master/measureit/

Campbell Barton commented

2016-07-27 09:25:03 +02:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-07-27 09:25:03 +02:00

Checked over the addon,

Blocking Issues

Saving an image is using the "//" prefix which isn't expanded, call bpy.path.abspath() on the path before passing to save_render. (Currently Im getting an error Error: MeasureIt: Unable to save temporary render image. Define a valid render path)
try/except is used in a way which can hide real bugs (measureit_geometry.py:92 has ~540 lines of code in a try block, where failing on a non index error will pass) ... in general this should be avoided since a mistake in the code, or a minor API change can cause an error which will silently fail.

General Issues

Wildcard * imports should be avoided .

Checked over the addon, Blocking Issues **** - Saving an image is using the "//" prefix which isn't expanded, call `bpy.path.abspath()` on the path before passing to save_render. (Currently Im getting an error `Error: MeasureIt: Unable to save temporary render image. Define a valid render path`) - try/except is used in a way which can hide real bugs (measureit_geometry.py:92 has ~540 lines of code in a try block, where failing on a non index error will `pass`) ... in general this should be avoided since a mistake in the code, or a minor API change can cause an error which will silently fail. General Issues **** - Wildcard `*` imports [should be avoided ](http://docs.quantifiedcode.com/python-anti-patterns/maintainability/from_module_import_all_used.html).

Brendon Murphy removed their assignment 2016-07-27 10:00:33 +02:00

Antonio Vazquez was assigned by Brendon Murphy

2016-07-27 10:00:33 +02:00

Brendon Murphy commented

2016-08-03 02:54:24 +02:00

@antoniov
measureit is committed to release.

note: there are some pending issues here. I have discussed with antoniov & he is aware of issues & will attend to these after gp2 work is finalized & during bcon3.
added warning to bl info 'warning': 'Temporary: pending review fixes #48704',
thanks & welcome.

@antoniov measureit is committed to release. note: there are some pending issues here. I have discussed with antoniov & he is aware of issues & will attend to these after gp2 work is finalized & during bcon3. added warning to bl info 'warning': 'Temporary: pending review fixes #48704', thanks & welcome.

Brendon Murphy changed title from ~~Measureit by Antonioya (Promote Addons Release)~~ to Measureit by Antonioya (fix current review bugs)

2016-08-03 02:55:07 +02:00

Antonio Vazquez commented

2016-08-10 11:31:15 +02:00

I have done several commits to Addon repo with the fixes. I have tested in Windows but I would like someone using other OS will test, especially the render option with "//" prefix.

Brendon Murphy commented

2016-08-10 11:39:05 +02:00

Changed status from 'Open' to: 'Resolved'

Brendon Murphy closed this issue

2016-08-10 11:39:05 +02:00

Brendon Murphy commented

2016-08-10 11:39:05 +02:00

thanks @antoniov & welcome to addons project
closing as resolved

thanks @antoniov & welcome to addons project closing as resolved

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Measureit by Antonioya (fix current review bugs) #48704