Crash when trying to adjust Frame in Graph Editor #49034

Closed
opened 2016-08-07 14:32:06 +02:00 by wueo · 14 comments

windows 7 64 bit

Broken: 2.77a , blender-2.77-566dd4e-win64.zip

Short description of error

Crash when adjusting slider in Graph editor at active keyframe on Frame slider

Exact steps for others to reproduce the error

in Graph editor when clicking and holding on Frame and value sliders to adjust by dragging mouse then blender crashed, tryed many times and working every time.Crash screenshot.jpg

windows 7 64 bit Broken: 2.77a , blender-2.77-566dd4e-win64.zip **Short description of error** Crash when adjusting slider in Graph editor at active keyframe on Frame slider **Exact steps for others to reproduce the error** in Graph editor when clicking and holding on Frame and value sliders to adjust by dragging mouse then blender crashed, tryed many times and working every time.![Crash screenshot.jpg](https://archive.blender.org/developer/F333820/Crash_screenshot.jpg)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @mushroomeo

Added subscriber: @mushroomeo
Member

Added subscriber: @JoshuaLeung

Added subscriber: @JoshuaLeung
Member

Have you checked whether this still happens for you in the current test builds (https://builder.blender.org/download)?

I can't reproduce any crashes here from a clean file in current master. If you're still having crashes, could you upload a file where this is happening so that we can check if there are any other hidden factors at play here.

Have you checked whether this still happens for you in the current test builds (https://builder.blender.org/download)? I can't reproduce any crashes here from a clean file in current master. If you're still having crashes, could you upload a file where this is happening so that we can check if there are any other hidden factors at play here.
Author

hi, i tryed yesterday the newest daily release of 7.8.2016. just found out how to reproduce it. if i click on frame and value and decrease it till it hits 0 on timeline then it crashes, blender immediatly closes... here is screenshot and blend file{F334245}

Crash.jpg

hi, i tryed yesterday the newest daily release of 7.8.2016. just found out how to reproduce it. if i click on frame and value and decrease it till it hits 0 on timeline then it crashes, blender immediatly closes... here is screenshot and blend file{[F334245](https://archive.blender.org/developer/F334245/SmilingCrashBandit.blend)} ![Crash.jpg](https://archive.blender.org/developer/F334246/Crash.jpg)
Author
[SmilingCrashBandit.blend](https://archive.blender.org/developer/F334250/SmilingCrashBandit.blend)
Member

Ah.. you need to drag down (to start dragging both) before starting to move left/right. Indeed this crashes. Will investigate :)

Ah.. you need to drag down (to start dragging both) before starting to move left/right. Indeed this crashes. Will investigate :)

Added subscriber: @Almisuifre

Added subscriber: @Almisuifre

Added subscribers: @JulianEisel, @ideasman42, @Sergey

Added subscribers: @JulianEisel, @ideasman42, @Sergey
Campbell Barton was assigned by Sergey Sharybin 2017-05-15 14:51:08 +02:00

This is use-after-free issue.

@ideasman42, AFAIR, multibut edit is your area, mind having a look here? Or maybe @JulianEisel likes such a reports?

This is use-after-free issue. @ideasman42, AFAIR, multibut edit is your area, mind having a look here? Or maybe @JulianEisel likes such a reports?
Member

An update:
So this seems to happen when you move the keyframe past the other keyframes, triggering the keyframe sorting (sort_time_fcurve()) . Disabling that step solves the crash here, but is kindof undesirable in that the curve doesn't get resorted/recalculated.

Do we have any callbacks that we only run after all interaction with a button is finished? If we do, we could just defer this curve sorting till then?

An update: So this seems to happen when you move the keyframe past the other keyframes, triggering the keyframe sorting (`sort_time_fcurve()`) . Disabling that step solves the crash here, but is kindof undesirable in that the curve doesn't get resorted/recalculated. Do we have any callbacks that we only run after all interaction with a button is finished? If we do, we could just defer this curve sorting till then?

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Committed fix, though the case of buttons force-exiting drag isn't well supported (undo pushes aren't made for eg).

Ideally it would work so this case would have the same logic as releasing the mouse cursor.

Committed fix, though the case of buttons force-exiting drag isn't well supported (undo pushes aren't made for eg). Ideally it would work so this case would have the same logic as releasing the mouse cursor.

This issue was referenced by d415a1cbd6

This issue was referenced by d415a1cbd646b28f8b19da304b66dc580eb08763
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
6 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#49034
No description provided.