When Toggling all Layers using the Tilde Key directly after a Scene Switch, the Render Camera is removed #49463

New Issue

Rainer Trummer · 2016-09-27T10:32:41+02:00

Rainer Trummer commented

2016-09-27 10:32:41 +02:00

System Information
Windows 7 x64, Quadro 4000

Blender Version
Broken: 2.77a, 2.78 any build so far

Short description of error
I've made a demo file to test. In this file there are three scenes. If you switch from Scene to Scene.001, and then directly after that hit the Tilde key (which calls bpy.ops.view3d.layers()), the active render camera is removed from the slot.

Exact steps for others to reproduce the error
Open the provided Blend, switch to Scene.001, hit Tilde. The Scene.camera property becomes None:

Debug_Camera_Loss.blend

**System Information** Windows 7 x64, Quadro 4000 **Blender Version** Broken: 2.77a, 2.78 any build so far **Short description of error** I've made a demo file to test. In this file there are three scenes. If you switch from Scene to Scene.001, and then directly after that hit the Tilde key (which calls bpy.ops.view3d.layers()), the active render camera is removed from the slot. **Exact steps for others to reproduce the error** Open the provided Blend, switch to Scene.001, hit Tilde. The Scene.camera property becomes None: ![CameraLoss.gif](https://archive.blender.org/developer/F369159/CameraLoss.gif) [Debug_Camera_Loss.blend](https://archive.blender.org/developer/F369161/Debug_Camera_Loss.blend)

Rainer Trummer commented

2016-09-27 10:32:42 +02:00

Changed status to: 'Open'

Rainer Trummer commented

2016-09-27 10:32:42 +02:00

Added subscriber: @RainerTrummer

Sergey Sharybin commented

2016-09-27 11:18:04 +02:00

Added subscriber: @Sergey

Sergey Sharybin commented

2016-09-27 11:18:04 +02:00

Can confirm the issue, but not sure yet what's going on.

Julian Eisel commented

2016-09-28 00:05:12 +02:00

Added subscriber: @JulianEisel

Julian Eisel commented

2016-09-28 00:05:12 +02:00

Main reason this happens is because the camera for Scene.001 is coming from a different scene. This is generally supported and I don't see any issues with it, so don't think we should prevent this.

Would propose this fix: P404: Possible fix for #49463

diff --git a/source/blender/editors/space_view3d/view3d_header.c b/source/blender/editors/space_view3d/view3d_header.c
index 0713377..d960992 100644
--- a/source/blender/editors/space_view3d/view3d_header.c
+++ b/source/blender/editors/space_view3d/view3d_header.c
@@ -68,8 +68,10 @@ static void do_view3d_header_buttons(bContext *C, void *arg, int event);
 #define B_SEL_EDGE  111
 #define B_SEL_FACE  112
 
-/* XXX quickly ported across */
-static void handle_view3d_lock(bContext *C)
+/**
+ * If needed, sync scene with changed 3D view layers and update all 3D views for changed scene data.
+ */
+static void view3d_layers_update(bContext *C)
 {
        Main *bmain = CTX_data_main(C);
        Scene *scene = CTX_data_scene(C);
@@ -81,7 +83,6 @@ static void handle_view3d_lock(bContext *C)
                        /* copy to scene */
                        scene->lay = v3d->lay;
                        scene->layact = v3d->layact;
-                       scene->camera = v3d->camera;
 
                        /* not through notifier, listener don't have context
                         * and non-open screens or spaces need to be updated too */
@@ -170,7 +171,7 @@ static int view3d_layers_exec(bContext *C, wmOperator *op)
                }
        }
        
-       if (v3d->scenelock) handle_view3d_lock(C);
+       if (v3d->scenelock) view3d_layers_update(C);
        
        DAG_on_visible_update(CTX_data_main(C), false);

Really don't see why you'd update scene camera when changing 3D view layers... probably this function used to be called after changing 3D View camera.

Main reason this happens is because the camera for Scene.001 is coming from a different scene. This is generally supported and I don't see any issues with it, so don't think we should prevent this. Would propose this fix: [P404: Possible fix for #49463](https://archive.blender.org/developer/P404.txt) ```diff diff --git a/source/blender/editors/space_view3d/view3d_header.c b/source/blender/editors/space_view3d/view3d_header.c index 0713377..d960992 100644 --- a/source/blender/editors/space_view3d/view3d_header.c +++ b/source/blender/editors/space_view3d/view3d_header.c @@ -68,8 +68,10 @@ static void do_view3d_header_buttons(bContext *C, void *arg, int event); #define B_SEL_EDGE 111 #define B_SEL_FACE 112 -/* XXX quickly ported across */ -static void handle_view3d_lock(bContext *C) +/** + * If needed, sync scene with changed 3D view layers and update all 3D views for changed scene data. + */ +static void view3d_layers_update(bContext *C) { Main *bmain = CTX_data_main(C); Scene *scene = CTX_data_scene(C); @@ -81,7 +83,6 @@ static void handle_view3d_lock(bContext *C) /* copy to scene */ scene->lay = v3d->lay; scene->layact = v3d->layact; - scene->camera = v3d->camera; /* not through notifier, listener don't have context * and non-open screens or spaces need to be updated too */ @@ -170,7 +171,7 @@ static int view3d_layers_exec(bContext *C, wmOperator *op) } } - if (v3d->scenelock) handle_view3d_lock(C); + if (v3d->scenelock) view3d_layers_update(C); DAG_on_visible_update(CTX_data_main(C), false); ``` Really don't see why you'd update scene camera when changing 3D view layers... probably this function used to be called after changing 3D View camera.

Rainer Trummer commented

2016-09-29 10:24:10 +02:00

@JulianEisel I tried to apply this as a patch today, but it failed for me (didn't find the lines to change). To I need to target a specific commit to make it work?