UV Sticky mode is not respected with Border select #50132

New Issue

Cenek Strichel · 2016-11-28T12:15:09+01:00

Cenek Strichel commented

2016-11-28 12:15:09 +01:00

Blender Version
2.78a

Short description of error
Sticky mode is not used with border select in UV editor.

If you click on UV:	But with border select:

**Blender Version** 2.78a **Short description of error** Sticky mode is not used with border select in UV editor. |If you click on UV:|But with border select:| | -- | -- | |![click.png](https://archive.blender.org/developer/F407080/click.png)|![border.png](https://archive.blender.org/developer/F407082/border.png)|

Cenek Strichel commented

2016-11-28 12:15:09 +01:00

Changed status to: 'Open'

Cenek Strichel commented

2016-11-28 12:15:10 +01:00

Added subscriber: @Cenda

Anthony Edlin commented

2016-11-29 02:13:20 +01:00

Added subscriber: @AnthonyEdlin

Anthony Edlin commented

2016-11-29 02:13:20 +01:00

Can confirm this is current behavior. Also circle select and lasso select also don't follow sticky mode. Not sure if this is desired behavior or not. Shouldn't be that hard to add to those operators, could mark todo for someone that wants an easier task.

Campbell Barton commented

2016-11-29 08:45:28 +01:00

Added subscriber: @ideasman42

Campbell Barton commented

2016-11-29 08:45:28 +01:00

As noted this doesn't work, but more a case of not being implemented then a software error.

Nice TODO for new developer - move to quick hacks.

As noted this doesn't work, but more a case of not being implemented then a software error. Nice TODO for new developer - move to quick hacks.

cris commented

2016-11-30 21:33:20 +01:00

Added subscriber: @ShyGuyMath

cris self-assigned this 2016-11-30 21:33:20 +01:00

cris commented

2016-11-30 21:33:20 +01:00

I'd like to try this, if no one has made a claim!

Anthony Edlin commented

2016-12-01 04:25:01 +01:00

Sure go for it, you can assign me I'll help test and review once you have a patch.

cris removed their assignment 2016-12-01 04:43:27 +01:00

Anthony Edlin was assigned by cris

2016-12-01 04:43:27 +01:00

cris commented

2016-12-01 04:43:27 +01:00

Okay, cool thanks!

Anthony Edlin removed their assignment 2016-12-01 04:52:20 +01:00

cris was assigned by Anthony Edlin

2016-12-01 04:52:20 +01:00

Cenek Strichel commented

2016-12-07 14:27:43 +01:00

Also Selection Mode is not respected by Border Select. Edge and Island mode is not usable with Border Select.

Robert Fornof commented

2017-01-01 21:45:25 +01:00

Added subscriber: @amdbcg

Darshan Kadu commented

2017-01-19 15:14:09 +01:00

Added subscriber: @DarshanKadu

Darshan Kadu commented

2017-01-19 15:14:09 +01:00

Hi is this task done !
I would like to take this task .

Hi is this task done ! I would like to take this task .

cris commented

2017-01-19 15:22:21 +01:00

Hi darshan, sorry things have been very busy in my life. Yeah you are more then free to take it off my hands.

umar haruna abdullahi commented

2017-01-28 12:27:44 +01:00

Added subscriber: @umarabdullahi-2

umar haruna abdullahi commented

2017-01-28 12:27:44 +01:00

Me too i want to try if you allow

Darshan Kadu commented

2017-01-29 06:25:58 +01:00

ya sure you can help me in this task !!

Darshan Kadu commented

2017-02-24 19:16:30 +01:00

index 193b006cf0..27525f7755 100644
--- a/source/blender/editors/uvedit/uvedit_ops.c
+++ b/source/blender/editors/uvedit/uvedit_ops.c
@@ -2842,6 +2842,65 @@ static void uv_select_flush_from_tag_loop(SpaceImage *sima, Scene *scene, Object

 /* ********************border select operator**************** */

+bool uv_touched_vetex(int hitv[4], int v, int sticky, int hitlen) {
+       int  i = 0;
+
+       for (i = 0; i<hitlen; i++) {
+               if (hitv[i] == v) {
+                       if (sticky == SI_STICKY_VERTEX)
+                               return true;
+               }
+       }
+
+       return false;
+}
+
+void uv_get_hit_vertex(BMLoop *l, MLoopUV *luv, MLoopUV *luv_next, MTexPoly *tf,
+                                       BMFace *efa,const bool cd_loop_uv_offset, NearestHit *hit ,int index) {
+
+       memset(hit, 0, sizeof(hit));
+
+       hit->l = l;
+       hit->luv = luv;
+       hit->luv_next = BM_ELEM_CD_GET_VOID_P(l->next, cd_loop_uv_offset);
+       hit->tf = tf;
+       hit->efa = efa;
+       hit->lindex = index;
+       return;
+}
+
+void uv_select_sticky_border(BMEditMesh *em, Scene *scene, Image *ima, int v, NearestHit *hit, int sticky) {
+       BMFace *efa;
+       BMIter iter, liter;
+       BMLoop *l;
+       MTexPoly *tf;
+       int *hitv = NULL;
+       int hitlen = 0, i = 0;
+
+       const int cd_loop_uv_offset = CustomData_get_offset(&em->bm->ldata, CD_MLOOPUV);
+       const int cd_poly_tex_offset = CustomData_get_offset(&em->bm->pdata, CD_MTEXPOLY);
+
+       if (hit->efa == NULL || sticky == SI_STICKY_DISABLE)
+               return;
+
+       hitv = BLI_array_alloca(hitv, hit->efa->len);
+       copy_vn_i(hitv, hit->efa->len, 0xFFFFFFFF);
+       hitv[hit->lindex] = BM_elem_index_get(hit->l->v);
+       hitlen = hit->efa->len;
+       printf("%d    %d\n", hit->efa->len, hitlen);
+       BM_ITER_MESH(efa, &iter, em->bm, BM_FACES_OF_MESH) {
+               tf = BM_ELEM_CD_GET_VOID_P(efa, cd_poly_tex_offset);
+               if (!uvedit_face_visible_test(scene, ima, efa, tf))
+                       continue;
+               BM_ITER_ELEM_INDEX(l, &liter, efa, BM_LOOPS_OF_FACE, i) {
+                       if (uv_touched_vetex(hitv, BM_elem_index_get(l->v), sticky, hit->efa->len)) {
+                               uvedit_uv_select_enable(em, scene, l, false, cd_loop_uv_offset);
+                       }
+               }
+       }
+
+}
+
 static int uv_border_select_exec(bContext *C, wmOperator *op)
 {
        SpaceImage *sima = CTX_wm_space_image(C);
@@ -2855,8 +2914,10 @@ static int uv_border_select_exec(bContext *C, wmOperator *op)
        BMLoop *l;
        BMIter iter, liter;
        MTexPoly *tf;
-       MLoopUV *luv;
+       MLoopUV *luv ,*luv_next;
+       NearestHit hit;
        rctf rectf;
+       int sticky,i=0;
        bool changed, pinned, select, extend;
        const bool use_face_center = (ts->uv_flag & UV_SYNC_SELECTION) ?
                                    (ts->selectmode == SCE_SELECT_FACE) :
@@ -2874,6 +2935,8 @@ static int uv_border_select_exec(bContext *C, wmOperator *op)
        pinned = RNA_boolean_get(op->ptr, "pinned");
        extend = RNA_boolean_get(op->ptr, "extend");

+       sticky = (sima) ? sima->sticky : 1;
+
        if (!extend)
                uv_select_all_perform(scene, ima, em, SEL_DESELECT);

@@ -2911,19 +2974,28 @@ static int uv_border_select_exec(bContext *C, wmOperator *op)
                        tf = BM_ELEM_CD_GET_VOID_P(efa, cd_poly_tex_offset);
                        if (!uvedit_face_visible_test(scene, ima, efa, tf))
                                continue;
-                       BM_ITER_ELEM (l, &liter, efa, BM_LOOPS_OF_FACE) {
+                       BM_ITER_ELEM_INDEX (l, &liter, efa, BM_LOOPS_OF_FACE, i) {
                                luv = BM_ELEM_CD_GET_VOID_P(l, cd_loop_uv_offset);
+                               luv_next = BM_ELEM_CD_GET_VOID_P(l->next, cd_loop_uv_offset);

                                if (!pinned || (ts->uv_flag & UV_SYNC_SELECTION)) {

                                        /* UV_SYNC_SELECTION - can't do pinned selection */
                                        if (BLI_rctf_isect_pt_v(&rectf, luv->uv)) {
                                                uvedit_uv_select_set(em, scene, l, select, false, cd_loop_uv_offset);
+                                               if (sticky == SI_STICKY_VERTEX) {
+                                                       uv_get_hit_vertex(l, luv, luv_next, tf, efa, cd_loop_uv_offset, &hit, i);
+                                                       uv_select_sticky_border(em, scene, ima, BM_elem_index_get(l->v), &hit, sticky);
+                                               }
                                        }
                                }
                                else if (pinned) {
                                        if ((luv->flag & MLOOPUV_PINNED) && BLI_rctf_isect_pt_v(&rectf, luv->uv)) {
                                                uvedit_uv_select_set(em, scene, l, select, false, cd_loop_uv_offset);
+                                               if (sticky == SI_STICKY_VERTEX) {
+                                                       uv_get_hit_vertex(l, luv, luv_next, tf, efa, cd_loop_uv_offset, &hit, i);
+                                                       uv_select_sticky_border(em, scene, ima, BM_elem_index_get(l->v), &hit, sticky);
+                                               }
                                        }
                                }
                        }

``` index 193b006cf0..27525f7755 100644 --- a/source/blender/editors/uvedit/uvedit_ops.c +++ b/source/blender/editors/uvedit/uvedit_ops.c @@ -2842,6 +2842,65 @@ static void uv_select_flush_from_tag_loop(SpaceImage *sima, Scene *scene, Object /* ********************border select operator**************** */ +bool uv_touched_vetex(int hitv[4], int v, int sticky, int hitlen) { + int i = 0; + + for (i = 0; i<hitlen; i++) { + if (hitv[i] == v) { + if (sticky == SI_STICKY_VERTEX) + return true; + } + } + + return false; +} + +void uv_get_hit_vertex(BMLoop *l, MLoopUV *luv, MLoopUV *luv_next, MTexPoly *tf, + BMFace *efa,const bool cd_loop_uv_offset, NearestHit *hit ,int index) { + + memset(hit, 0, sizeof(hit)); + + hit->l = l; + hit->luv = luv; + hit->luv_next = BM_ELEM_CD_GET_VOID_P(l->next, cd_loop_uv_offset); + hit->tf = tf; + hit->efa = efa; + hit->lindex = index; + return; +} + +void uv_select_sticky_border(BMEditMesh *em, Scene *scene, Image *ima, int v, NearestHit *hit, int sticky) { + BMFace *efa; + BMIter iter, liter; + BMLoop *l; + MTexPoly *tf; + int *hitv = NULL; + int hitlen = 0, i = 0; + + const int cd_loop_uv_offset = CustomData_get_offset(&em->bm->ldata, CD_MLOOPUV); + const int cd_poly_tex_offset = CustomData_get_offset(&em->bm->pdata, CD_MTEXPOLY); + + if (hit->efa == NULL || sticky == SI_STICKY_DISABLE) + return; + + hitv = BLI_array_alloca(hitv, hit->efa->len); + copy_vn_i(hitv, hit->efa->len, 0xFFFFFFFF); + hitv[hit->lindex] = BM_elem_index_get(hit->l->v); + hitlen = hit->efa->len; + printf("%d %d\n", hit->efa->len, hitlen); + BM_ITER_MESH(efa, &iter, em->bm, BM_FACES_OF_MESH) { + tf = BM_ELEM_CD_GET_VOID_P(efa, cd_poly_tex_offset); + if (!uvedit_face_visible_test(scene, ima, efa, tf)) + continue; + BM_ITER_ELEM_INDEX(l, &liter, efa, BM_LOOPS_OF_FACE, i) { + if (uv_touched_vetex(hitv, BM_elem_index_get(l->v), sticky, hit->efa->len)) { + uvedit_uv_select_enable(em, scene, l, false, cd_loop_uv_offset); + } + } + } + +} + static int uv_border_select_exec(bContext *C, wmOperator *op) { SpaceImage *sima = CTX_wm_space_image(C); @@ -2855,8 +2914,10 @@ static int uv_border_select_exec(bContext *C, wmOperator *op) BMLoop *l; BMIter iter, liter; MTexPoly *tf; - MLoopUV *luv; + MLoopUV *luv ,*luv_next; + NearestHit hit; rctf rectf; + int sticky,i=0; bool changed, pinned, select, extend; const bool use_face_center = (ts->uv_flag & UV_SYNC_SELECTION) ? (ts->selectmode == SCE_SELECT_FACE) : @@ -2874,6 +2935,8 @@ static int uv_border_select_exec(bContext *C, wmOperator *op) pinned = RNA_boolean_get(op->ptr, "pinned"); extend = RNA_boolean_get(op->ptr, "extend"); + sticky = (sima) ? sima->sticky : 1; + if (!extend) uv_select_all_perform(scene, ima, em, SEL_DESELECT); @@ -2911,19 +2974,28 @@ static int uv_border_select_exec(bContext *C, wmOperator *op) tf = BM_ELEM_CD_GET_VOID_P(efa, cd_poly_tex_offset); if (!uvedit_face_visible_test(scene, ima, efa, tf)) continue; - BM_ITER_ELEM (l, &liter, efa, BM_LOOPS_OF_FACE) { + BM_ITER_ELEM_INDEX (l, &liter, efa, BM_LOOPS_OF_FACE, i) { luv = BM_ELEM_CD_GET_VOID_P(l, cd_loop_uv_offset); + luv_next = BM_ELEM_CD_GET_VOID_P(l->next, cd_loop_uv_offset); if (!pinned || (ts->uv_flag & UV_SYNC_SELECTION)) { /* UV_SYNC_SELECTION - can't do pinned selection */ if (BLI_rctf_isect_pt_v(&rectf, luv->uv)) { uvedit_uv_select_set(em, scene, l, select, false, cd_loop_uv_offset); + if (sticky == SI_STICKY_VERTEX) { + uv_get_hit_vertex(l, luv, luv_next, tf, efa, cd_loop_uv_offset, &hit, i); + uv_select_sticky_border(em, scene, ima, BM_elem_index_get(l->v), &hit, sticky); + } } } else if (pinned) { if ((luv->flag & MLOOPUV_PINNED) && BLI_rctf_isect_pt_v(&rectf, luv->uv)) { uvedit_uv_select_set(em, scene, l, select, false, cd_loop_uv_offset); + if (sticky == SI_STICKY_VERTEX) { + uv_get_hit_vertex(l, luv, luv_next, tf, efa, cd_loop_uv_offset, &hit, i); + uv_select_sticky_border(em, scene, ima, BM_elem_index_get(l->v), &hit, sticky); + } } } } ```

Darshan Kadu commented

2017-02-24 19:18:46 +01:00

This is the patch i have created for border selection .Using this the sticky mode(veres selection ) for border selection is same as mouse selection.

Ray molenkamp commented

2017-02-24 19:19:36 +01:00

Added subscriber: @LazyDodo

Ray molenkamp commented

2017-02-24 19:19:36 +01:00

Please make differential with this patch to make reviewing it a little easier

https://developer.blender.org/differential/diff/create/

Please make differential with this patch to make reviewing it a little easier https://developer.blender.org/differential/diff/create/

Darshan Kadu commented

2017-02-24 19:46:54 +01:00

https://developer.blender.org/differential/diff/8311/#a335e5e2
this is the diff patch

[[ https://developer.blender.org/differential/diff/8311/#a335e5e2 ]] this is the diff patch

Darshan Kadu commented

2017-02-24 20:12:03 +01:00

https://developer.blender.org/D2526
this is the differential i have created .

https://developer.blender.org/D2526 this is the differential i have created .

Campbell Barton commented

2017-02-27 14:47:07 +01:00

uv_select_sticky_border is called in a loop, this isnt needed since you can use LOOPS_OF_VERT iterator to find all face corners attached to the vertex.

`uv_select_sticky_border` is called in a loop, this isnt needed since you can use LOOPS_OF_VERT iterator to find all face corners attached to the vertex.

cris was unassigned by Campbell Barton

2017-03-03 15:09:48 +01:00

Darshan Kadu commented

2017-04-03 10:19:54 +02:00

I have updated the diff
Here is the link https://developer.blender.org/D2596

I have updated the diff Here is the link https://developer.blender.org/D2596

Hugo Sales commented

2018-02-22 21:22:14 +01:00

Added subscriber: @HugoSales