Cycles-Regression: invisible shaders are optimized and compiled although they shouldn't #50181

New Issue

mathieu menuet · 2016-12-04T17:53:02+01:00

mathieu menuet commented

2016-12-04 17:53:02 +01:00

Note that this report follows a discussion on IRC with @angavrilov @ThomasDinges and @lukasstockner97. It seems it worked as expected (shaders not visible also not compiled and not optimized) before, but I couldn't find the revision where it broke. So @ThomasDinges proposed to report it as a bug.

System Information
all vendors

Blender Version
Broken: latest master

Short description of error
Objects can be hidden because of layer visibility, or invisible only for rendering, or culled by camera/distance culling. Their mesh are not processed in the scene preparation, but their shaders do, increasing frame render times for nothing. List of required shader should be created after camera/distance culling.

Exact steps for others to reproduce the error
Open this Blend: bug hidden shaders compiled and optimized.blend with --debug-cycles and hit F12. See that material.001 is getting optimized and compiled also only cube.001 (hidden on an invisible layer) has it.

Note that this report follows a discussion on IRC with @angavrilov @ThomasDinges and @lukasstockner97. It seems it worked as expected (shaders not visible also not compiled and not optimized) before, but I couldn't find the revision where it broke. So @ThomasDinges proposed to report it as a bug. **System Information** all vendors **Blender Version** Broken: latest master **Short description of error** Objects can be hidden because of layer visibility, or invisible only for rendering, or culled by camera/distance culling. Their mesh are not processed in the scene preparation, but their shaders do, increasing frame render times for nothing. List of required shader should be created after camera/distance culling. **Exact steps for others to reproduce the error** Open this Blend: [bug hidden shaders compiled and optimized.blend](https://archive.blender.org/developer/F414056/bug_hidden_shaders_compiled_and_optimized.blend) with --debug-cycles and hit F12. See that material.001 is getting optimized and compiled also only cube.001 (hidden on an invisible layer) has it.

mathieu menuet commented

2016-12-04 17:53:02 +01:00

Changed status to: 'Open'

mathieu menuet commented

2016-12-04 17:53:02 +01:00

Added subscribers: @angavrilov, @LukasStockner, @ThomasDinges, @bliblubli

mathieu menuet commented

2016-12-04 17:53:35 +01:00

Added subscribers: @brecht, @Sergey

Sergey Sharybin commented

2016-12-04 22:22:28 +01:00

Don't currently have time to check this, but if someone can test whether it's ca03edd it'll give some clues :)

Don't currently have time to check this, but if someone can test whether it's ca03edd it'll give some clues :)

mathieu menuet commented

2016-12-07 19:48:24 +01:00

Tried different revisions, will try more tomorrow, but at least in may 2015, it worked. So it happened after may 2015. Just one year and a half of commits to check :D

mathieu menuet commented

2016-12-17 09:13:10 +01:00

This comment was removed by @bliblubli

*This comment was removed by @bliblubli*

Sergey Sharybin commented

2017-03-22 18:00:10 +01:00

Changed status from 'Open' to: 'Archived'

Sergey Sharybin closed this issue

2017-03-22 18:00:10 +01:00

Sergey Sharybin self-assigned this 2017-03-22 18:00:10 +01:00

Sergey Sharybin commented

2017-03-22 18:00:10 +01:00

Did some more deeper research. The commit mentioned above has nothing to do with this issue. In fact, i don't see issue here at all. At least there is no change in behavior since Blender version 2.75. All older versions did not have any logging around materials. All the versions starting from 2.75 are reporting 7 shaders synchronized to the shader manager.

More detailed SVM statistics are rather recent feature, so using that to show whether material is compiled in or not is not reliable.

Verdict: there is not a regression in the past couple of years and the layer system will work fully different in Blender 2.8. So wouldn't consider this a bug, but rather a a subject for reconsideration.

Thanks for the report anyway.

Did some more deeper research. The commit mentioned above has nothing to do with this issue. In fact, i don't see issue here at all. At least there is no change in behavior since Blender version 2.75. All older versions did not have any logging around materials. All the versions starting from 2.75 are reporting 7 shaders synchronized to the shader manager. More detailed SVM statistics are rather recent feature, so using that to show whether material is compiled in or not is not reliable. Verdict: there is not a regression in the past couple of years and the layer system will work fully different in Blender 2.8. So wouldn't consider this a bug, but rather a a subject for reconsideration. Thanks for the report anyway.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles-Regression: invisible shaders are optimized and compiled although they shouldn't #50181