requirements.txt vs setup.py #50387

New Issue

Francesco Siddi · 2017-01-07T17:01:54+01:00

Francesco Siddi commented

2017-01-07 17:01:54 +01:00

Currently installing Pillar with pip install -e . does not install al requirements needed by the app. Is there a particular reason for it? At the beginning of the file there is a text saying Setup file for testing, not for packaging/distribution.

The requirements.txt seems to contain all requirements.

Currently installing Pillar with `pip install -e .` does not install al requirements needed by the app. Is there a particular reason for it? At the beginning of the file there is a text saying **Setup file for testing, not for packaging/distribution**. The `requirements.txt` seems to contain all requirements.

Sybren A. Stüvel was assigned by Francesco Siddi

2017-01-07 17:01:54 +01:00

Francesco Siddi commented

2017-01-07 17:01:54 +01:00

Changed status to: 'Open'

Francesco Siddi commented

2017-01-07 17:01:54 +01:00

Added subscriber: @fsiddi

Dalai Felinto commented

2017-01-09 10:28:58 +01:00

Added subscriber: @dfelinto

Sybren A. Stüvel commented

2017-02-14 10:36:58 +01:00

pip install -e . runs setup.py, which should install the dependencies needed by the app. They might be different versions than in requirements.txt, as generally setup.py contains only minimum versions supported.

For setting up a dev or prod environment, I would always recommend pip install -r requirements.txt and then pip install -e ..

Let's use this ticket to clean up the requirements.txt files, though. I have a plan for this, but it does require a more strict directory layout on our dev machines:

All projects are direct subdirectories of the same dir $DIR; on my machine this is /home/sybren/workspace/cloud. The exact directory doesn't matter, as long as it contains all Cloud projects.
Projects are checked out in $DIR/pillar, $DIR/flamenco, $DIR/attract, $DIR/pillar-python-sdk, and $DIR/blender-cloud.
In each project we refer to the requirements.txt files of their dependencies, so in $DIR/flamenco/requirements.txt we include -r ../pillar/requirements.txt. In a similar way, $DIR/blender-cloud/requirements.txt will refer to the Pillar, Flamenco and Attract files.

This does give us less freedom over where we place things on our development machines. However, it does free us from the hassle of keeping all the requirements synced up between projects.

`pip install -e .` runs `setup.py`, which should install the dependencies needed by the app. They might be different versions than in `requirements.txt`, as generally `setup.py` contains only minimum versions supported. For setting up a dev or prod environment, I would always recommend `pip install -r requirements.txt` and then `pip install -e .`. Let's use this ticket to clean up the requirements.txt files, though. I have a plan for this, but it does require a more strict directory layout on our dev machines: - All projects are direct subdirectories of the same dir `$DIR`; on my machine this is `/home/sybren/workspace/cloud`. The exact directory doesn't matter, as long as it contains all Cloud projects. - Projects are checked out in `$DIR/pillar`, `$DIR/flamenco`, `$DIR/attract`, `$DIR/pillar-python-sdk`, and `$DIR/blender-cloud`. - In each project we refer to the `requirements.txt` files of their dependencies, so in `$DIR/flamenco/requirements.txt` we include `-r ../pillar/requirements.txt`. In a similar way, `$DIR/blender-cloud/requirements.txt` will refer to the Pillar, Flamenco and Attract files. This does give us less freedom over where we place things on our development machines. However, it does free us from the hassle of keeping all the requirements synced up between projects.

Dalai Felinto commented

2017-02-14 11:01:20 +01:00

Let's also take this as a chance to implement requirements-dev.txt for unittest and docs related packages.

Let's also take this as a chance to implement `requirements-dev.txt` for unittest and docs related packages.

Sybren A. Stüvel commented

2017-03-03 12:23:28 +01:00

On in, while porting to Python 3.6