Adding new hook while in Edit mode breaks when trying to undo/redo the operator #50423

Open
opened 2017-01-13 08:50:31 +01:00 by Serge Lyatin · 21 comments

System Information
Win7 (32bit)

Blender Version
Broken: 2.78a

Short description of error

Exact steps for others to reproduce the error

  • Add Path from Curve menu, add new Armature
  • Assign Bone to control point as Hook
  • Blank Hook modifier appears along with real one

Screencast: screencast0001-0250.mp4

**System Information** Win7 (32bit) **Blender Version** Broken: 2.78a **Short description of error** **Exact steps for others to reproduce the error** - Add Path from Curve menu, add new Armature - Assign Bone to control point as Hook - Blank Hook modifier appears along with real one Screencast: [screencast0001-0250.mp4](https://archive.blender.org/developer/F431944/screencast0001-0250.mp4)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @SergeL

Added subscriber: @SergeL

#101763 was marked as duplicate of this issue

#101763 was marked as duplicate of this issue

#80280 was marked as duplicate of this issue

#80280 was marked as duplicate of this issue

#74486 was marked as duplicate of this issue

#74486 was marked as duplicate of this issue

#64612 was marked as duplicate of this issue

#64612 was marked as duplicate of this issue

Added subscribers: @JulianEisel, @Sergey, @mont29

Added subscribers: @JulianEisel, @Sergey, @mont29

Yuck, that’s ugly undo/redo issue again… Not sure we can do much about that kind of glitches currently, problem is that you are in Edit mode, which does not handle undo/redo of things like modifiers etc. Unless maybe @Sergey or @JulianEisel have ideas?

Yuck, that’s ugly undo/redo issue again… Not sure we can do much about that kind of glitches currently, problem is that you are in Edit mode, which does not handle undo/redo of things like modifiers etc. Unless maybe @Sergey or @JulianEisel have ideas?
Bastien Montagne changed title from Hook modifier duplicating to Adding new hook while in Edit mode breaks when trying to undo/redo the operator 2017-01-13 10:40:12 +01:00

Added subscriber: @RayMairlot

Added subscriber: @RayMairlot

Added subscriber: @mano-wii

Added subscriber: @mano-wii

This is still a issue in blender 2.83.

This is still a issue in blender 2.83.

Removed subscriber: @RayMairlot

Removed subscriber: @RayMairlot

Added subscribers: @Mets, @dr.sybren, @ideasman42

Added subscribers: @Mets, @dr.sybren, @ideasman42

The problem is that an action can either store an undo step for edit mode (which doesn't include things outside of edit mode, such as the pose bone properties) or it can store the entire scene in memory (which doesn't include edito mode data). Deleting a bone changes both sets of data, so it cannot be properly un-done with just one step. This is a limitation that needs proper design work to resolve.

The problem is that an action can either store an undo step for edit mode (which doesn't include things outside of edit mode, such as the pose bone properties) or it can store the entire scene in memory (which doesn't include edito mode data). Deleting a bone changes both sets of data, so it cannot be properly un-done with just one step. This is a limitation that needs proper design work to resolve.

Added subscriber: @a690089735

Added subscriber: @a690089735

Added subscribers: @TodorNikolov, @iss

Added subscribers: @TodorNikolov, @iss

@dr.sybren any news on this? Any plans for the redesign to happen during 3.x?
This bug has the potential to wipe out hours of work (happened to me). It's hard to accept that it has been known for 5+ years, is considered "Normal" severity, and is assigned to no one.

@dr.sybren any news on this? Any plans for the redesign to happen during 3.x? This bug has the potential to wipe out hours of work (happened to me). It's hard to accept that it has been known for 5+ years, is considered "Normal" severity, and is assigned to no one.

Added subscriber: @DrMc

Added subscriber: @DrMc

I've been looking for a bug to start developing - Sybren suggested the getting started list but others have picked off most of that. @dr.sybren do you think this would be a tractable bug for a experienced developer who is new to Blender?

I've been looking for a bug to start developing - Sybren suggested the getting started list but others have picked off most of that. @dr.sybren do you think this would be a tractable bug for a experienced developer who is new to Blender?

@DrMc I wouldn't pick this one, fixing it properly requires knowledge of how the undo system works, and that's far from trivial. I know of a bug that I didn't file yet, so I'll do that and assign it to you, I think it's a nicer one ;-)

@DrMc I wouldn't pick this one, fixing it properly requires knowledge of how the undo system works, and that's far from trivial. I know of a bug that I didn't file yet, so I'll do that and assign it to you, I think it's a nicer one ;-)
Member

Added subscriber: @walt-3

Added subscriber: @walt-3
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
10 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#50423
No description provided.