converting all to mesh doesn't work when a boolean and solidify are present in scene. #50950

Closed
opened 2017-03-15 11:59:54 +01:00 by matali23 · 6 comments

System Information
all vendors

Blender Version
Broken: e8021f5

Short description of error
converting all objects to mesh (alt+C) doesn't work when boolean and solidify are used together. Converting each mesh one after another work.

Exact steps for others to reproduce the error
Open attached file, hit alt+C and seletct "to mesh". Modifiers are removed but the boolean is not applied. Only select the cube and repeat the conversion, it works.
bug to mesh bool v2.blend

**System Information** all vendors **Blender Version** Broken: e8021f5 **Short description of error** converting all objects to mesh (alt+C) doesn't work when boolean and solidify are used together. Converting each mesh one after another work. **Exact steps for others to reproduce the error** Open attached file, hit alt+C and seletct "to mesh". Modifiers are removed but the boolean is not applied. Only select the cube and repeat the conversion, it works. [bug to mesh bool v2.blend](https://archive.blender.org/developer/F509758/bug_to_mesh_bool_v2.blend)
Author

Changed status to: 'Open'

Changed status to: 'Open'
Author

Added subscriber: @matali23

Added subscriber: @matali23

Added subscriber: @mano-wii

Added subscriber: @mano-wii

Reasons for Bug:

  • The OBJECT_OT_convert operator is calling the mesh_get_derived_final with a CustomDataMask that includes all types. This causes it to recalculate the entire DerivedMesh unnecessarily. It could use only the Masks that the modifiers require. (So it would be more efficient). However I do not even know why the DerivedMesh would no inform the CustomDataMask required for conversion. I think that parameter could be ob->lastDataMask;

  • Another reason for the BUG is that the {BKE_object_free_modifiers(newob)` turns the DerivedMesh of the Object NULL before it is used to calculate the next object. This call could be made in another loop.

Reasons for Bug: - The `OBJECT_OT_convert operator` is calling the `mesh_get_derived_final` with a CustomDataMask that includes all types. This causes it to recalculate the entire DerivedMesh unnecessarily. It could use only the Masks that the modifiers require. (So it would be more efficient). However I do not even know why the DerivedMesh would no inform the CustomDataMask required for conversion. I think that parameter could be `ob->lastDataMask`; - Another reason for the BUG is that the {BKE_object_free_modifiers(newob)` turns the DerivedMesh of the Object NULL before it is used to calculate the next object. This call could be made in another loop.

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

This issue was referenced by 750c0dd4de

This issue was referenced by 750c0dd4debce8c79c3875fe54f1a1d57cf047da
Sign in to join this conversation.
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blender/blender#50950
No description provided.