Material viewport mode crash on node with more than 64 outputs. #51007

New Issue

Lex · 2017-03-20T15:20:51+01:00

Lex commented

2017-03-20 15:20:51 +01:00

System Information
Windows 10 x64 home on Nvidia GTX 1070 with latest WHQL drivers.

Blender Version
2.78c

Short description of error
"Material" viewport mode will crash if any if material group nodes contains more than 64 inputs/outputs. "Render" viewport mode will work fine though...

Exact steps for others to reproduce the error

Open attached file.
Switch viewport mode to "Material".
In next 1-10 seconds Blender will crash .

P.S. It may sounds funny & not practical limitation but not for me - in my "[Real Materials ]]" series those [ http:*www.techkind.org/Blender/showcase_non-metals_dust_settings.jpg | tricky collapseable sections with options sliders allows to keep things simple and use more than 64 material parameters...

[Bugreports] Material viewport mode crash on node with more than 64 outputs.blend

**System Information** Windows 10 x64 home on Nvidia GTX 1070 with latest WHQL drivers. **Blender Version** 2.78c **Short description of error** "Material" viewport mode will crash if any if material group nodes contains more than 64 inputs/outputs. "Render" viewport mode will work fine though... **Exact steps for others to reproduce the error** 1. Open attached file. 2. Switch viewport mode to "Material". 3. [In next 1-10 seconds Blender will crash ](http://www.techkind.org/Blender/[Bugreports]_64_outputs.png). P.S. It may sounds funny & not practical limitation but not for me - in my "[Real Materials ]]" series those [[ http:*www.techkind.org/Blender/showcase_non-metals_dust_settings.jpg | tricky collapseable sections ](https:*blendermarket.com/products/real-materials-vol-6) with options sliders allows to keep things simple and use more than 64 material parameters... [[Bugreports] Material viewport mode crash on node with more than 64 outputs.blend](https://archive.blender.org/developer/F516529/_Bugreports__Material_viewport_mode_crash_on_node_with_more_than_64_outputs.blend)

Lex commented

2017-03-20 15:20:51 +01:00

Changed status to: 'Open'

Lex commented

2017-03-20 15:20:51 +01:00

Added subscriber: @Lex4art

Sergey Sharybin commented

2017-03-22 17:25:25 +01:00

Added subscribers: @mont29, @Sergey

Sergey Sharybin self-assigned this 2017-03-22 17:25:25 +01:00

Sergey Sharybin commented

2017-03-22 17:25:25 +01:00

The issue is coming from hardcoded MAX_SOCKET set to 64. I've tried to remove such a static limit, but it's not so trivial within the current nodes design, especially for the texture nodes. I think it is safe to bump this constant to 512. This will only be ~16K extra stack memory usage per thread during evaluation which is really small for the modern systems.

@mont29, do you have any string opinion here?

The issue is coming from hardcoded MAX_SOCKET set to 64. I've tried to remove such a static limit, but it's not so trivial within the current nodes design, especially for the texture nodes. I think it is safe to bump this constant to 512. This will only be ~16K extra stack memory usage per thread during evaluation which is really small for the modern systems. @mont29, do you have any string opinion here?

Lex commented

2017-03-22 17:36:18 +01:00

In #51007#424324, @Sergey wrote:
The issue is coming from hardcoded MAX_SOCKET set to 64. I've tried to remove such a static limit, but it's not so trivial within the current nodes design, especially for the texture nodes. I think it is safe to bump this constant to 512. This will only be ~16K extra stack memory usage per thread during evaluation which is really small for the modern systems.

At least prevent it from crashing Blender, please ). "Material" viewport mode will not work with my complex materials anyway , too many nodes...

> In #51007#424324, @Sergey wrote: > The issue is coming from hardcoded MAX_SOCKET set to 64. I've tried to remove such a static limit, but it's not so trivial within the current nodes design, especially for the texture nodes. I think it is safe to bump this constant to 512. This will only be ~16K extra stack memory usage per thread during evaluation which is really small for the modern systems. At least prevent it from crashing Blender, please ). "Material" viewport mode will [not work with my complex materials anyway ](https://developer.blender.org/T49381), too many nodes...

Bastien Montagne commented

2017-03-22 17:44:54 +01:00

@Sergey think raising hard limit is fine yes.