CacheFile Open Operator Crashes Blender #51052

New Issue

lvxejay · 2017-03-26T09:08:21+02:00

lvxejay commented

2017-03-26 09:08:21 +02:00

System Information

Blender Version

Broken: blender-2.78-34a502c16a-linux-glibc219-x86_64]

Short description of error
Running bpy.ops.cachefile.open(filepath='path/to/abc/here'), crashes Blender.

Exact steps for others to reproduce the error
Run in Blender python console or text editor:

bpy.ops.cachefile.open(filepath='path/to/abc/here')

Result = Blender Crash

**System Information** **Blender Version** Broken: blender-2.78-34a502c16a-linux-glibc219-x86_64] **Short description of error** Running bpy.ops.cachefile.open(filepath='path/to/abc/here'), crashes Blender. **Exact steps for others to reproduce the error** Run in Blender python console or text editor: ``` bpy.ops.cachefile.open(filepath='path/to/abc/here') ``` Result = Blender Crash

lvxejay commented

2017-03-26 09:08:21 +02:00

Changed status to: 'Open'

lvxejay commented

2017-03-26 09:08:21 +02:00

Added subscriber: @lvxejay

lvxejay commented

2017-03-26 10:51:35 +02:00

When called from the Dynamic Context Menu (spacebar), it works just fine

lvxejay commented

2017-03-26 11:03:27 +02:00

Operator requires an execution override to work properly:

bpy.ops.cachefile.open('INVOKE_REGION_WIN')

This should probably be the default behavior for this operator call.

Operator requires an execution override to work properly: ``` bpy.ops.cachefile.open('INVOKE_REGION_WIN') ``` This should probably be the default behavior for this operator call.

Martin Felke commented

2017-05-23 20:04:18 +02:00

Added subscriber: @scorpion81

Martin Felke commented

2017-05-23 20:04:18 +02:00

Seems to be an invalid pointer when this operator is directly executed from python instead of being invoked before.

P480: Possible fix for #51052 (invalid pointer when bpy.ops.cachefile.open() is called)

diff --git a/source/blender/editors/io/io_cache.c b/source/blender/editors/io/io_cache.c
index c5eea94..b6aa193 100644
--- a/source/blender/editors/io/io_cache.c
+++ b/source/blender/editors/io/io_cache.c
@@ -98,6 +98,12 @@ static int cachefile_open_exec(bContext *C, wmOperator *op)
 	/* hook into UI */
 	PropertyPointerRNA *pprop = op->customdata;
 
+	/* this seems a NULL pointer here when bpy.ops.cachefile.open() is called from python... */
+	if (!pprop) {
+		cachefile_init(C, op);
+		pprop = op->customdata;
+	}
+
 	if (pprop->prop) {
 		/* when creating new ID blocks, use is already 1, but RNA
 		 * pointer se also increases user, so this compensates it */

Seems to be an invalid pointer when this operator is directly executed from python instead of being invoked before. [P480: Possible fix for #51052 (invalid pointer when bpy.ops.cachefile.open() is called)](https://archive.blender.org/developer/P480.txt) ```diff diff --git a/source/blender/editors/io/io_cache.c b/source/blender/editors/io/io_cache.c index c5eea94..b6aa193 100644 --- a/source/blender/editors/io/io_cache.c +++ b/source/blender/editors/io/io_cache.c @@ -98,6 +98,12 @@ static int cachefile_open_exec(bContext *C, wmOperator *op) /* hook into UI */ PropertyPointerRNA *pprop = op->customdata; + /* this seems a NULL pointer here when bpy.ops.cachefile.open() is called from python... */ + if (!pprop) { + cachefile_init(C, op); + pprop = op->customdata; + } + if (pprop->prop) { /* when creating new ID blocks, use is already 1, but RNA * pointer se also increases user, so this compensates it */ ```

blender-admin commented

2017-07-10 09:06:25 +02:00

This issue was referenced by blender/blender@2c10e8a3cf

This issue was referenced by blender/blender@2c10e8a3cfff3cc3c12b0359bbfc11c0a7eadecc

Campbell Barton commented

2017-07-10 09:29:00 +02:00

Changed status from 'Open' to: 'Resolved'

Campbell Barton closed this issue

2017-07-10 09:29:00 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

CacheFile Open Operator Crashes Blender #51052