[Cycles/Material view] Modulo function in material doesn't match cycles. #51434

New Issue

Closed

opened 2017-05-07 20:59:59 +02:00 by Ray molenkamp · 8 comments

Ray molenkamp commented

2017-05-07 20:59:59 +02:00

Member

System Information
Win7/x64

Blender Version
Broken: latest master
Worked: probably always has been broken.

Short description of error
the math_modulo shader in gpu_shader_material.glsl has a small bug, it makes up for the sign being wrong, but that is not enough

void math_modulo(float val1, float val2, out float outval)
{
	if (val2 == 0.0)
		outval = 0.0;
	else
		outval = mod(val1, val2);

	/* change sign to match C convention, mod in GLSL will take absolute for negative numbers,
	 * see https://www.opengl.org/sdk/docs/man/html/mod.xhtml */
	outval = (val1 > 0.0) ? outval : -outval;
}

last line should probably be

	outval = (val1 > 0.0) ? outval : -(val2-outval);

Exact steps for others to reproduce the error
Based on a (as simple as possible) attached .blend file with minimum amount of steps

mod_breakage.blend

render with cycles, compare with material view... not the same

![mat_view.jpg](https://archive.blender.org/developer/F591418/mat_view.jpg) **System Information** Win7/x64 **Blender Version** Broken: latest master Worked: probably always has been broken. **Short description of error** the math_modulo shader in gpu_shader_material.glsl has a small bug, it makes up for the sign being wrong, but that is not enough ``` void math_modulo(float val1, float val2, out float outval) { if (val2 == 0.0) outval = 0.0; else outval = mod(val1, val2); /* change sign to match C convention, mod in GLSL will take absolute for negative numbers, * see https://www.opengl.org/sdk/docs/man/html/mod.xhtml */ outval = (val1 > 0.0) ? outval : -outval; } ``` last line should probably be ``` outval = (val1 > 0.0) ? outval : -(val2-outval); ``` **Exact steps for others to reproduce the error** Based on a (as simple as possible) attached .blend file with minimum amount of steps [mod_breakage.blend](https://archive.blender.org/developer/F591417/mod_breakage.blend) render with cycles, compare with material view... not the same

Ray molenkamp commented

2017-05-07 20:59:59 +02:00

Author

Member

Changed status to: 'Open'

Changed status to: 'Open'

Ray molenkamp commented

2017-05-07 20:59:59 +02:00

Author

Member

Added subscriber: @LazyDodo

Added subscriber: @LazyDodo

Mike Erwin was assigned by Ray molenkamp

2017-05-07 21:02:03 +02:00

Ray molenkamp commented

2017-05-07 21:02:03 +02:00

Author

Member

Added subscriber: @MikeErwin

Added subscriber: @MikeErwin

Ray molenkamp commented

2017-05-07 21:02:03 +02:00

Author

Member

@MikeErwin here's some low hanging fruit, didn't want to commit without you looking at it.

@MikeErwin here's some low hanging fruit, didn't want to commit without you looking at it.

Carlo Andreacchio commented

2017-05-09 11:51:23 +02:00

Added subscriber: @candreacchio

Added subscriber: @candreacchio

Carlo Andreacchio commented

2017-05-09 11:51:23 +02:00

Patch created at D2661

Patch created at [D2661](https://archive.blender.org/developer/D2661)

blender-admin commented

2017-05-09 12:31:19 +02:00

This issue was referenced by ffc95a33b6

This issue was referenced by ffc95a33b62821e8eb66cf7003942e37976d20d7

Sergey Sharybin commented

2017-05-09 12:33:42 +02:00

Owner

Changed status from 'Open' to: 'Resolved'

Changed status from 'Open' to: 'Resolved'

Sergey Sharybin closed this issue

2017-05-09 12:33:42 +02:00

Sign in to join this conversation.

No Label

Animation & Rigging

Asset Browser Project Overview

Automated Testing

Blender Asset Bundle

Dependency Graph

Development Management

EEVEE & Viewport

Images & Movies

Motion Tracking

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Render Pipeline

Sculpt, Paint & Texture

Video Sequencer

Virtual Reality

Blender 2.8 Project

Milestone 1: Basic, Local Asset Browser

Good First Issue

Animation & Rigging

Development Management

EEVEE & Viewport

Nodes & Physics

Pipeline, Assets & IO

Platforms, Builds & Tests

Render & Cycles

Sculpt, Paint & Texture

Needs Info from Developers

Needs Information from User

No Milestone

No project

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#51434

No description provided.