Page MenuHome

gawain doesn't build with MSVC
Closed, ResolvedPublic

Description

inline is not defined in MSVC:
https://builder.blender.org/builders/win64_cmake_vc2013/builds/1368/steps/compile/logs/stdio

We should use __inline in those cases, with a conditional ifdef for linux/win. We have this in Blender itself, but we can't bring GPL code into Mozilla, so gawain gotta decide how to best address this.

(It fails in shader_interface.c)

Details

Type
Bug

Event Timeline

this doesn't look like a function that will be called enough to justify the inline? so short term i suggest just removing the keyword so things get building again, for future things you might want to inline just toss a

#ifdef _MSV_VER 
#define inline __inline
#endif

^^^ live typed in this ticket, no license issues

in a generic gawain headers somewhere

I agree with @LazyDodo (LazyDodo) about removing "inline". Simplest solution & I've found static private functions to be as effective as inline. If we ever need public inline functions we can define this in gawain/common.h

Mike Erwin (merwin) closed this task as Resolved.Jun 7 2017, 10:31 PM